[INFO] fetching crate gurk 0.1.2... [INFO] checking gurk-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate gurk 0.1.2 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate gurk 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gurk 0.1.2 [INFO] finished tweaking crates.io crate gurk 0.1.2 [INFO] tweaked toml for crates.io crate gurk 0.1.2 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate gurk 0.1.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bd7be1147d4b3372dbde6f86fe00d3d39a98d13f64714a83b285cd13ef155204 [INFO] running `Command { std: "docker" "start" "-a" "bd7be1147d4b3372dbde6f86fe00d3d39a98d13f64714a83b285cd13ef155204", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bd7be1147d4b3372dbde6f86fe00d3d39a98d13f64714a83b285cd13ef155204", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bd7be1147d4b3372dbde6f86fe00d3d39a98d13f64714a83b285cd13ef155204", kill_on_drop: false }` [INFO] [stdout] bd7be1147d4b3372dbde6f86fe00d3d39a98d13f64714a83b285cd13ef155204 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2ffc8675187513c75c7ebf792518d134a63fba5a22ab1681e605c9cd6481a8e0 [INFO] running `Command { std: "docker" "start" "-a" "2ffc8675187513c75c7ebf792518d134a63fba5a22ab1681e605c9cd6481a8e0", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.19 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling libc v0.2.73 [INFO] [stderr] Compiling syn v1.0.35 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling pin-project-internal v0.4.22 [INFO] [stderr] Compiling serde_derive v1.0.114 [INFO] [stderr] Compiling serde v1.0.114 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking arc-swap v0.4.7 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking smallvec v1.4.1 [INFO] [stderr] Checking futures-core v0.3.5 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Checking futures-task v0.3.5 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling unicode-segmentation v1.6.0 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Compiling anyhow v1.0.32 [INFO] [stderr] Compiling serde_json v1.0.57 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking bytes v0.5.6 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking itoa v0.4.6 [INFO] [stderr] Checking pin-project-lite v0.1.7 [INFO] [stderr] Checking textwrap v0.12.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.3 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Compiling proc-macro-error v1.0.3 [INFO] [stderr] Compiling num-integer v0.1.43 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking base64 v0.12.3 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking signal-hook-registry v1.2.0 [INFO] [stderr] Checking parking_lot_core v0.7.2 [INFO] [stderr] Checking net2 v0.2.34 [INFO] [stderr] Checking mio v0.7.0 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking dirs-sys v0.3.5 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking clap v2.33.1 [INFO] [stderr] Checking dirs v3.0.1 [INFO] [stderr] Checking mio v0.6.22 [INFO] [stderr] Checking signal-hook v0.1.16 [INFO] [stderr] Checking parking_lot v0.10.2 [INFO] [stderr] Checking mio-uds v0.6.8 [INFO] [stderr] Compiling syn-mid v0.5.0 [INFO] [stderr] Compiling thiserror-impl v1.0.20 [INFO] [stderr] Compiling tokio-macros v0.2.5 [INFO] [stderr] Checking tokio v0.2.22 [INFO] [stderr] Compiling structopt-derive v0.4.8 [INFO] [stderr] Checking thiserror v1.0.20 [INFO] [stderr] Checking pin-project v0.4.22 [INFO] [stderr] Checking futures-util v0.3.5 [INFO] [stderr] Checking structopt v0.3.15 [INFO] [stderr] Checking crossterm v0.17.7 [INFO] [stderr] Checking tui v0.10.0 [INFO] [stderr] Checking chrono v0.4.13 [INFO] [stderr] Checking toml v0.5.6 [INFO] [stderr] Checking gurk v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `signal_client` is never read [INFO] [stdout] --> src/app.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 15 | pub struct App { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 19 | pub signal_client: signal::SignalClient, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `source_device`, `message`, `is_receipt`, `is_read`, and `is_delivery` are never read [INFO] [stdout] --> src/signal.rs:201:9 [INFO] [stdout] | [INFO] [stdout] 199 | pub struct Envelope { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 200 | pub source: String, [INFO] [stdout] 201 | pub source_device: u8, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 204 | pub message: Option, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 205 | pub is_receipt: bool, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 206 | pub is_read: Option, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 207 | pub is_delivery: Option, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Envelope` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `timestamp` and `expires_in_seconds` are never read [INFO] [stdout] --> src/signal.rs:217:9 [INFO] [stdout] | [INFO] [stdout] 216 | pub struct InnerMessage { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] 217 | pub timestamp: u64, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 218 | pub message: Option, [INFO] [stdout] 219 | pub expires_in_seconds: u64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `InnerMessage` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:71:65 [INFO] [stdout] | [INFO] [stdout] 51 | let (tx, mut rx) = tokio::sync::mpsc::channel(100); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | tokio::spawn(async move { signal_client.stream_messages(tx).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:168:12 [INFO] [stdout] | [INFO] [stdout] 138 | let log_file = if verbose { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 169 | | config, [INFO] [stdout] 170 | | data, [INFO] [stdout] 171 | | should_quit: false, [INFO] [stdout] 172 | | signal_client, [INFO] [stdout] 173 | | log_file, [INFO] [stdout] 174 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signal.rs:80:53 [INFO] [stdout] | [INFO] [stdout] 73 | let mut child = cmd.spawn()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | let cmd_handle = tokio::spawn(async { child.await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gurk` (bin "gurk" test) due to 4 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `signal_client` is never read [INFO] [stdout] --> src/app.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 15 | pub struct App { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 19 | pub signal_client: signal::SignalClient, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `source_device`, `message`, `is_receipt`, `is_read`, and `is_delivery` are never read [INFO] [stdout] --> src/signal.rs:201:9 [INFO] [stdout] | [INFO] [stdout] 199 | pub struct Envelope { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 200 | pub source: String, [INFO] [stdout] 201 | pub source_device: u8, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 204 | pub message: Option, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 205 | pub is_receipt: bool, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 206 | pub is_read: Option, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 207 | pub is_delivery: Option, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Envelope` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `timestamp` and `expires_in_seconds` are never read [INFO] [stdout] --> src/signal.rs:217:9 [INFO] [stdout] | [INFO] [stdout] 216 | pub struct InnerMessage { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] 217 | pub timestamp: u64, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 218 | pub message: Option, [INFO] [stdout] 219 | pub expires_in_seconds: u64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `InnerMessage` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:71:65 [INFO] [stdout] | [INFO] [stdout] 51 | let (tx, mut rx) = tokio::sync::mpsc::channel(100); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | tokio::spawn(async move { signal_client.stream_messages(tx).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:168:12 [INFO] [stdout] | [INFO] [stdout] 138 | let log_file = if verbose { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 169 | | config, [INFO] [stdout] 170 | | data, [INFO] [stdout] 171 | | should_quit: false, [INFO] [stdout] 172 | | signal_client, [INFO] [stdout] 173 | | log_file, [INFO] [stdout] 174 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signal.rs:80:53 [INFO] [stdout] | [INFO] [stdout] 73 | let mut child = cmd.spawn()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | let cmd_handle = tokio::spawn(async { child.await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gurk` (bin "gurk") due to 4 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "2ffc8675187513c75c7ebf792518d134a63fba5a22ab1681e605c9cd6481a8e0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2ffc8675187513c75c7ebf792518d134a63fba5a22ab1681e605c9cd6481a8e0", kill_on_drop: false }` [INFO] [stdout] 2ffc8675187513c75c7ebf792518d134a63fba5a22ab1681e605c9cd6481a8e0