[INFO] fetching crate gui 0.6.2... [INFO] checking gui-0.6.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate gui 0.6.2 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate gui 0.6.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gui 0.6.2 [INFO] finished tweaking crates.io crate gui 0.6.2 [INFO] tweaked toml for crates.io crate gui 0.6.2 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 23 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f7eeef6ec168f3583e867196fa5199537a267ab4d62540aeb85d1bdb89e2ab53 [INFO] running `Command { std: "docker" "start" "-a" "f7eeef6ec168f3583e867196fa5199537a267ab4d62540aeb85d1bdb89e2ab53", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f7eeef6ec168f3583e867196fa5199537a267ab4d62540aeb85d1bdb89e2ab53", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f7eeef6ec168f3583e867196fa5199537a267ab4d62540aeb85d1bdb89e2ab53", kill_on_drop: false }` [INFO] [stdout] f7eeef6ec168f3583e867196fa5199537a267ab4d62540aeb85d1bdb89e2ab53 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3ca854798d0aa9686cbdab2041e41188a1b9f8581cba4ca6bd9d84124ee69de5 [INFO] running `Command { std: "docker" "start" "-a" "3ca854798d0aa9686cbdab2041e41188a1b9f8581cba4ca6bd9d84124ee69de5", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling gui-derive v0.6.2 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking gui v0.6.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handleable.rs:22:77 [INFO] [stdout] | [INFO] [stdout] 22 | async fn handle(&self, cap: &mut dyn MutCap, event: E) -> Option { [INFO] [stdout] | ______________________________________________________--------_______________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | | // By default we just pass through the event, which will cause it to [INFO] [stdout] 24 | | // bubble up to the parent. [INFO] [stdout] 25 | | Some(event) [INFO] [stdout] 26 | | } [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handleable.rs:32:78 [INFO] [stdout] | [INFO] [stdout] 32 | async fn react(&self, message: M, cap: &mut dyn MutCap) -> Option { [INFO] [stdout] | _________________________----------___________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | | Some(message) [INFO] [stdout] 34 | | } [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/placeholder.rs:43:79 [INFO] [stdout] | [INFO] [stdout] 43 | async fn handle(&self, _cap: &mut dyn MutCap, _event: E) -> Option { [INFO] [stdout] | _______________________________________________________---------_______________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | | unreachable!() [INFO] [stdout] 45 | | } [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/placeholder.rs:47:80 [INFO] [stdout] | [INFO] [stdout] 47 | async fn react(&self, _message: M, _cap: &mut dyn MutCap) -> Option { [INFO] [stdout] | _________________________-----------____________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | | unreachable!() [INFO] [stdout] 49 | | } [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui.rs:94:9 [INFO] [stdout] | [INFO] [stdout] 90 | fn merge(e1: Option, e2: Option) -> Option [INFO] [stdout] | ------------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | match (e1, e2) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui.rs:114:18 [INFO] [stdout] | [INFO] [stdout] 111 | pre_hook_event: Option, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | unhandled: Option, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | event: Option<&E>, [INFO] [stdout] 114 | ) -> Option { [INFO] [stdout] | __________________^ [INFO] [stdout] 115 | | let mut result = None; [INFO] [stdout] 116 | | [INFO] [stdout] 117 | | for idx in ui.hooked.clone().as_ref() { [INFO] [stdout] ... | [INFO] [stdout] 128 | | merge(merge(pre_hook_event, unhandled), result) [INFO] [stdout] 129 | | } [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui.rs:142:18 [INFO] [stdout] | [INFO] [stdout] 139 | pre_hook_event: Option, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | unhandled: Option, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | _event: Option<&E>, [INFO] [stdout] 142 | ) -> Option { [INFO] [stdout] | __________________^ [INFO] [stdout] 143 | | debug_assert!(pre_hook_event.is_none()); [INFO] [stdout] 144 | | unhandled [INFO] [stdout] 145 | | } [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui.rs:608:14 [INFO] [stdout] | [INFO] [stdout] 606 | event: E, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 607 | ) -> Pin> + '_>> { [INFO] [stdout] 608 | Box::pin(async move { [INFO] [stdout] | ______________^ [INFO] [stdout] 609 | | // The clone we perform here allows us to decouple the Widget from [INFO] [stdout] 610 | | // the Ui, which in turn makes it possible to pass a mutable Ui [INFO] [stdout] 611 | | // reference (in the form of a MutCap) to an immutable widget. It is [INFO] [stdout] ... | [INFO] [stdout] 622 | | } [INFO] [stdout] 623 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui.rs:779:65 [INFO] [stdout] | [INFO] [stdout] 779 | async fn send(&mut self, widget: Id, message: M) -> Option { [INFO] [stdout] | ________________________________________----------_______________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 780 | | let idx = self.validate(widget); [INFO] [stdout] 781 | | let widget = self.widgets[idx.idx].1.clone(); [INFO] [stdout] ... | [INFO] [stdout] 784 | | } [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gui` (lib) due to 10 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "3ca854798d0aa9686cbdab2041e41188a1b9f8581cba4ca6bd9d84124ee69de5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3ca854798d0aa9686cbdab2041e41188a1b9f8581cba4ca6bd9d84124ee69de5", kill_on_drop: false }` [INFO] [stdout] 3ca854798d0aa9686cbdab2041e41188a1b9f8581cba4ca6bd9d84124ee69de5