[INFO] fetching crate gst-plugin-mpegtslive 0.13.1... [INFO] checking gst-plugin-mpegtslive-0.13.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate gst-plugin-mpegtslive 0.13.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate gst-plugin-mpegtslive 0.13.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gst-plugin-mpegtslive 0.13.1 [INFO] finished tweaking crates.io crate gst-plugin-mpegtslive 0.13.1 [INFO] tweaked toml for crates.io crate gst-plugin-mpegtslive 0.13.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 85 packages to latest compatible versions [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cf5af6d120c890512ee7648ba6a82df24317e3302dc5ef43ec888b510b91eac0 [INFO] running `Command { std: "docker" "start" "-a" "cf5af6d120c890512ee7648ba6a82df24317e3302dc5ef43ec888b510b91eac0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cf5af6d120c890512ee7648ba6a82df24317e3302dc5ef43ec888b510b91eac0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cf5af6d120c890512ee7648ba6a82df24317e3302dc5ef43ec888b510b91eac0", kill_on_drop: false }` [INFO] [stdout] cf5af6d120c890512ee7648ba6a82df24317e3302dc5ef43ec888b510b91eac0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fc8f9eb7927db3f3f2af33648ae6ad3a49ba83d8dc509c0796009757e6551b55 [INFO] running `Command { std: "docker" "start" "-a" "fc8f9eb7927db3f3f2af33648ae6ad3a49ba83d8dc509c0796009757e6551b55", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling winnow v0.6.18 [INFO] [stderr] Compiling target-lexicon v0.12.16 [INFO] [stderr] Compiling smallvec v1.13.2 [INFO] [stderr] Compiling version-compare v0.2.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking option-operations v0.5.0 [INFO] [stderr] Checking muldiv v1.0.1 [INFO] [stderr] Checking bitstream-io v2.5.3 [INFO] [stderr] Compiling cfg-expr v0.16.0 [INFO] [stderr] Compiling indexmap v2.5.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Compiling serde_spanned v0.6.7 [INFO] [stderr] Compiling toml_datetime v0.6.8 [INFO] [stderr] Compiling toml_edit v0.22.20 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Compiling toml v0.8.19 [INFO] [stderr] Compiling proc-macro-crate v3.2.0 [INFO] [stderr] Compiling gst-plugin-version-helper v0.8.2 [INFO] [stderr] Compiling glib-macros v0.20.2 [INFO] [stderr] Compiling gst-plugin-mpegtslive v0.13.1 (/opt/rustwide/workdir) [INFO] [stderr] Compiling system-deps v7.0.2 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Compiling glib-sys v0.20.2 [INFO] [stderr] Compiling gobject-sys v0.20.1 [INFO] [stderr] Compiling gio-sys v0.20.1 [INFO] [stderr] Compiling gstreamer-sys v0.23.0 [INFO] [stderr] Checking glib v0.20.2 [INFO] [stderr] Checking gstreamer v0.23.1 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mpegtslive/imp.rs:343:49 [INFO] [stdout] | [INFO] [stdout] 306 | mut buffer: gst::Buffer, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 307 | ) -> Result { [INFO] [stdout] 308 | let mut state = self.state.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 343 | gst::ProxyPad::chain_default(pad, Some(&*self.obj()), buffer) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mpegtslive/imp.rs:398:54 [INFO] [stdout] | [INFO] [stdout] 349 | mut bufferlist: gst::BufferList, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 350 | ) -> Result { [INFO] [stdout] 351 | let mut state = self.state.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 398 | gst::ProxyPad::chain_list_default(pad, Some(&*self.obj()), bufferlist) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mpegtslive/imp.rs:387:35 [INFO] [stdout] | [INFO] [stdout] 358 | bufferlist.make_mut().foreach_mut(|mut buffer, _idx| { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 387 | ControlFlow::Continue(Some(buffer)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mpegtslive/imp.rs:446:20 [INFO] [stdout] | [INFO] [stdout] 409 | let templ = klass.pad_template("src").unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 410 | let srcpad = gst::GhostPad::builder_from_template(&templ) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 434 | let internal_clock = glib::Object::builder::() [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 438 | let external_clock = glib::Object::builder::() [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 446 | state: Mutex::new(MpegTSLiveSourceState { [INFO] [stdout] | ____________________^ [INFO] [stdout] 447 | | source: None, [INFO] [stdout] 448 | | external_clock, [INFO] [stdout] 449 | | last_seen_pcr: None, [INFO] [stdout] 450 | | base_pcr: None, [INFO] [stdout] 451 | | base_monotonic: None, [INFO] [stdout] 452 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mpegtslive/imp.rs:417:21 [INFO] [stdout] | [INFO] [stdout] 412 | .proxy_pad_chain_function(move |pad, parent, buffer| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 413 | let parent = parent.and_then(|p| p.parent()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 417 | |imp| imp.chain(pad, buffer), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mpegtslive/imp.rs:425:21 [INFO] [stdout] | [INFO] [stdout] 420 | .proxy_pad_chain_list_function(move |pad, parent, bufferlist| { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 421 | let parent = parent.and_then(|p| p.parent()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 425 | |imp| imp.chain_list(pad, bufferlist), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mpegtslive/imp.rs:343:49 [INFO] [stdout] | [INFO] [stdout] 306 | mut buffer: gst::Buffer, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 307 | ) -> Result { [INFO] [stdout] 308 | let mut state = self.state.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 343 | gst::ProxyPad::chain_default(pad, Some(&*self.obj()), buffer) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mpegtslive/imp.rs:617:14 [INFO] [stdout] | [INFO] [stdout] 616 | let state = self.state.lock().expect("Couldn't get state"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 617 | Some(state.external_clock.clone().upcast()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mpegtslive/imp.rs:398:54 [INFO] [stdout] | [INFO] [stdout] 349 | mut bufferlist: gst::BufferList, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 350 | ) -> Result { [INFO] [stdout] 351 | let mut state = self.state.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 398 | gst::ProxyPad::chain_list_default(pad, Some(&*self.obj()), bufferlist) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mpegtslive/imp.rs:387:35 [INFO] [stdout] | [INFO] [stdout] 358 | bufferlist.make_mut().foreach_mut(|mut buffer, _idx| { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 387 | ControlFlow::Continue(Some(buffer)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mpegtslive/imp.rs:446:20 [INFO] [stdout] | [INFO] [stdout] 409 | let templ = klass.pad_template("src").unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 410 | let srcpad = gst::GhostPad::builder_from_template(&templ) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 434 | let internal_clock = glib::Object::builder::() [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 438 | let external_clock = glib::Object::builder::() [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 446 | state: Mutex::new(MpegTSLiveSourceState { [INFO] [stdout] | ____________________^ [INFO] [stdout] 447 | | source: None, [INFO] [stdout] 448 | | external_clock, [INFO] [stdout] 449 | | last_seen_pcr: None, [INFO] [stdout] 450 | | base_pcr: None, [INFO] [stdout] 451 | | base_monotonic: None, [INFO] [stdout] 452 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mpegtslive/imp.rs:417:21 [INFO] [stdout] | [INFO] [stdout] 412 | .proxy_pad_chain_function(move |pad, parent, buffer| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 413 | let parent = parent.and_then(|p| p.parent()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 417 | |imp| imp.chain(pad, buffer), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mpegtslive/imp.rs:425:21 [INFO] [stdout] | [INFO] [stdout] 420 | .proxy_pad_chain_list_function(move |pad, parent, bufferlist| { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 421 | let parent = parent.and_then(|p| p.parent()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 425 | |imp| imp.chain_list(pad, bufferlist), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mpegtslive/imp.rs:617:14 [INFO] [stdout] | [INFO] [stdout] 616 | let state = self.state.lock().expect("Couldn't get state"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 617 | Some(state.external_clock.clone().upcast()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gst-plugin-mpegtslive` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `gst-plugin-mpegtslive` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "fc8f9eb7927db3f3f2af33648ae6ad3a49ba83d8dc509c0796009757e6551b55", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fc8f9eb7927db3f3f2af33648ae6ad3a49ba83d8dc509c0796009757e6551b55", kill_on_drop: false }` [INFO] [stdout] fc8f9eb7927db3f3f2af33648ae6ad3a49ba83d8dc509c0796009757e6551b55