[INFO] fetching crate grust 0.3.2... [INFO] checking grust-0.3.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate grust 0.3.2 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate grust 0.3.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate grust 0.3.2 [INFO] finished tweaking crates.io crate grust 0.3.2 [INFO] tweaked toml for crates.io crate grust 0.3.2 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 6 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ee5f04b8ee28e9b44d13547e8d7307706ab86469431ce2e093890e65b133b3ed [INFO] running `Command { std: "docker" "start" "-a" "ee5f04b8ee28e9b44d13547e8d7307706ab86469431ce2e093890e65b133b3ed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ee5f04b8ee28e9b44d13547e8d7307706ab86469431ce2e093890e65b133b3ed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ee5f04b8ee28e9b44d13547e8d7307706ab86469431ce2e093890e65b133b3ed", kill_on_drop: false }` [INFO] [stdout] ee5f04b8ee28e9b44d13547e8d7307706ab86469431ce2e093890e65b133b3ed [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a803f14e081616d46deb7254c5b66d978d92922b79fd715759b9b86bf9ef0305 [INFO] running `Command { std: "docker" "start" "-a" "a803f14e081616d46deb7254c5b66d978d92922b79fd715759b9b86bf9ef0305", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Checking gtypes v0.2.0 [INFO] [stderr] Compiling glib-2-0-sys v0.46.4 [INFO] [stderr] Compiling gobject-2-0-sys v0.46.4 [INFO] [stderr] Checking grust v0.3.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/gstr.rs:119:21 [INFO] [stdout] | [INFO] [stdout] 119 | let c_str = try!(CString::new(t.into())); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/gstr.rs:119:21 [INFO] [stdout] | [INFO] [stdout] 119 | let c_str = try!(CString::new(t.into())); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated trait `std::ascii::AsciiExt`: use inherent methods instead [INFO] [stdout] --> src/util.rs:24:17 [INFO] [stdout] | [INFO] [stdout] 24 | use std::ascii::AsciiExt; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated trait `std::ascii::AsciiExt`: use inherent methods instead [INFO] [stdout] --> src/util.rs:24:17 [INFO] [stdout] | [INFO] [stdout] 24 | use std::ascii::AsciiExt; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ascii::AsciiExt` [INFO] [stdout] --> src/util.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | use std::ascii::AsciiExt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ascii::AsciiExt` [INFO] [stdout] --> src/util.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | use std::ascii::AsciiExt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gstr.rs:120:12 [INFO] [stdout] | [INFO] [stdout] 116 | pub fn new(t: T) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | let c_str = try!(CString::new(t.into())); [INFO] [stdout] | ----- ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | Ok(Utf8String { inner: c_str }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mainloop.rs:95:24 [INFO] [stdout] | [INFO] [stdout] 91 | pub fn new(closure: F) -> Self [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | let boxed_closure = Box::new(closure); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | SourceCallback(unsafe { [INFO] [stdout] | ________________________^ [INFO] [stdout] 96 | | RawCallback { [INFO] [stdout] 97 | | func: into_source_func(source_func::), [INFO] [stdout] 98 | | data: box_into_pointer(boxed_closure), [INFO] [stdout] 99 | | destroy: into_destroy_notify(box_free::) [INFO] [stdout] 100 | | } [INFO] [stdout] 101 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mainloop.rs:108:24 [INFO] [stdout] | [INFO] [stdout] 104 | pub fn once(closure: F) -> Self [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | let holder = Box::new(Some(closure)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | SourceCallback(unsafe { [INFO] [stdout] | ________________________^ [INFO] [stdout] 109 | | RawCallback { [INFO] [stdout] 110 | | func: into_source_func(source_once_func::), [INFO] [stdout] 111 | | data: box_into_pointer(holder), [INFO] [stdout] 112 | | destroy: into_destroy_notify(box_free::>) [INFO] [stdout] 113 | | } [INFO] [stdout] 114 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gstr.rs:120:12 [INFO] [stdout] | [INFO] [stdout] 116 | pub fn new(t: T) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | let c_str = try!(CString::new(t.into())); [INFO] [stdout] | ----- ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | Ok(Utf8String { inner: c_str }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mainloop.rs:95:24 [INFO] [stdout] | [INFO] [stdout] 91 | pub fn new(closure: F) -> Self [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | let boxed_closure = Box::new(closure); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | SourceCallback(unsafe { [INFO] [stdout] | ________________________^ [INFO] [stdout] 96 | | RawCallback { [INFO] [stdout] 97 | | func: into_source_func(source_func::), [INFO] [stdout] 98 | | data: box_into_pointer(boxed_closure), [INFO] [stdout] 99 | | destroy: into_destroy_notify(box_free::) [INFO] [stdout] 100 | | } [INFO] [stdout] 101 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mainloop.rs:108:24 [INFO] [stdout] | [INFO] [stdout] 104 | pub fn once(closure: F) -> Self [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | let holder = Box::new(Some(closure)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | SourceCallback(unsafe { [INFO] [stdout] | ________________________^ [INFO] [stdout] 109 | | RawCallback { [INFO] [stdout] 110 | | func: into_source_func(source_once_func::), [INFO] [stdout] 111 | | data: box_into_pointer(holder), [INFO] [stdout] 112 | | destroy: into_destroy_notify(box_free::>) [INFO] [stdout] 113 | | } [INFO] [stdout] 114 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `grust` (lib) due to 4 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `grust` (lib test) due to 4 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "a803f14e081616d46deb7254c5b66d978d92922b79fd715759b9b86bf9ef0305", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a803f14e081616d46deb7254c5b66d978d92922b79fd715759b9b86bf9ef0305", kill_on_drop: false }` [INFO] [stdout] a803f14e081616d46deb7254c5b66d978d92922b79fd715759b9b86bf9ef0305