[INFO] fetching crate group-threshold-cryptography-pre-release 0.2.0... [INFO] checking group-threshold-cryptography-pre-release-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate group-threshold-cryptography-pre-release 0.2.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate group-threshold-cryptography-pre-release 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate group-threshold-cryptography-pre-release 0.2.0 [INFO] finished tweaking crates.io crate group-threshold-cryptography-pre-release 0.2.0 [INFO] tweaked toml for crates.io crate group-threshold-cryptography-pre-release 0.2.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 155 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (latest: v0.2.0) [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clap v3.2.25 (latest: v4.5.16) [INFO] [stderr] Adding clap_lex v0.2.4 (latest: v0.7.2) [INFO] [stderr] Adding criterion v0.4.0 (latest: v0.5.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding hashbrown v0.13.2 (latest: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding miracl_core v2.3.0 (latest: v2.7.0) [INFO] [stderr] Adding os_str_bytes v6.6.1 (latest: v7.0.0) [INFO] [stderr] Adding serde_with v2.3.3 (latest: v3.9.0) [INFO] [stderr] Adding serde_with_macros v2.3.3 (latest: v3.9.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d466e2361b170730bb5a1e199b5bd97ca5cef367b7d80981c6de31cd9a459db2 [INFO] running `Command { std: "docker" "start" "-a" "d466e2361b170730bb5a1e199b5bd97ca5cef367b7d80981c6de31cd9a459db2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d466e2361b170730bb5a1e199b5bd97ca5cef367b7d80981c6de31cd9a459db2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d466e2361b170730bb5a1e199b5bd97ca5cef367b7d80981c6de31cd9a459db2", kill_on_drop: false }` [INFO] [stdout] d466e2361b170730bb5a1e199b5bd97ca5cef367b7d80981c6de31cd9a459db2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ca21594ce5111965de224edc43b4c3b81e130bdcf69c45b93f79c429d97082f2 [INFO] running `Command { std: "docker" "start" "-a" "ca21594ce5111965de224edc43b4c3b81e130bdcf69c45b93f79c429d97082f2", kill_on_drop: false }` [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking cpufeatures v0.2.13 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking opaque-debug v0.3.1 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking miracl_core v2.3.0 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Compiling num-integer v0.1.46 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Compiling num-bigint v0.4.6 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Compiling ark-serialize-derive v0.4.2 [INFO] [stderr] Compiling ark-ff-macros v0.4.2 [INFO] [stderr] Compiling ark-ff-asm v0.4.2 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking chacha20poly1305 v0.10.1 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Checking hashbrown v0.13.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Compiling serde_with_macros v2.3.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking ark-std v0.4.0 [INFO] [stderr] Checking ark-serialize v0.4.2 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking ark-ff v0.4.2 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking serde_with v2.3.3 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.4.0 [INFO] [stderr] Checking ark-poly v0.4.2 [INFO] [stderr] Checking ark-ec v0.4.2 [INFO] [stderr] Checking ark-bls12-381 v0.4.0 [INFO] [stderr] Checking subproductdomain-pre-release v0.1.0 [INFO] [stderr] Checking ferveo-common-pre-release v0.1.1 [INFO] [stderr] Checking group-threshold-cryptography-pre-release v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ciphertext.rs:199:8 [INFO] [stdout] | [INFO] [stdout] 195 | let mut prf_key = SecretBox::new(Vec::new()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | Ok(ChaCha20Poly1305::new(GenericArray::from_slice(&sha256( [INFO] [stdout] | ________^ [INFO] [stdout] 200 | | prf_key.as_secret(), [INFO] [stdout] 201 | | )))) [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/key_share.rs:50:26 [INFO] [stdout] | [INFO] [stdout] 39 | let alpha_a = E::G1Prepared::from( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | let alpha_z = E::G2Prepared::from( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | let g_inv = E::G1Prepared::from(-g.into_group()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | E::multi_pairing([g_inv, alpha_a], [alpha_z, self.blinding_key.into()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/key_share.rs:50:44 [INFO] [stdout] | [INFO] [stdout] 39 | let alpha_a = E::G1Prepared::from( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | let alpha_z = E::G2Prepared::from( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | let g_inv = E::G1Prepared::from(-g.into_group()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | E::multi_pairing([g_inv, alpha_a], [alpha_z, self.blinding_key.into()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/secret_box.rs:53:14 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn new(val: T) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | Self(Box::new(val)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `group-threshold-cryptography-pre-release` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ciphertext.rs:199:8 [INFO] [stdout] | [INFO] [stdout] 195 | let mut prf_key = SecretBox::new(Vec::new()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | Ok(ChaCha20Poly1305::new(GenericArray::from_slice(&sha256( [INFO] [stdout] | ________^ [INFO] [stdout] 200 | | prf_key.as_secret(), [INFO] [stdout] 201 | | )))) [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/key_share.rs:50:26 [INFO] [stdout] | [INFO] [stdout] 39 | let alpha_a = E::G1Prepared::from( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | let alpha_z = E::G2Prepared::from( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | let g_inv = E::G1Prepared::from(-g.into_group()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | E::multi_pairing([g_inv, alpha_a], [alpha_z, self.blinding_key.into()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/key_share.rs:50:44 [INFO] [stdout] | [INFO] [stdout] 39 | let alpha_a = E::G1Prepared::from( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | let alpha_z = E::G2Prepared::from( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | let g_inv = E::G1Prepared::from(-g.into_group()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | E::multi_pairing([g_inv, alpha_a], [alpha_z, self.blinding_key.into()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/secret_box.rs:53:14 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn new(val: T) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | Self(Box::new(val)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:860:17 [INFO] [stdout] | [INFO] [stdout] 854 | let private_key_share = refresh_private_key_share::( [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 860 | / DecryptionShareSimple::create( [INFO] [stdout] 861 | | &p.validator_private_key, [INFO] [stdout] 862 | | &private_key_share, [INFO] [stdout] 863 | | &ciphertext.header().unwrap(), [INFO] [stdout] 864 | | aad, [INFO] [stdout] 865 | | g_inv, [INFO] [stdout] 866 | | ) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `group-threshold-cryptography-pre-release` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "ca21594ce5111965de224edc43b4c3b81e130bdcf69c45b93f79c429d97082f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ca21594ce5111965de224edc43b4c3b81e130bdcf69c45b93f79c429d97082f2", kill_on_drop: false }` [INFO] [stdout] ca21594ce5111965de224edc43b4c3b81e130bdcf69c45b93f79c429d97082f2