[INFO] fetching crate graphplan 0.6.1... [INFO] checking graphplan-0.6.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate graphplan 0.6.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate graphplan 0.6.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate graphplan 0.6.1 [INFO] finished tweaking crates.io crate graphplan 0.6.1 [INFO] tweaked toml for crates.io crate graphplan 0.6.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate graphplan 0.6.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8173d8795531d1b1dfe34ff450e798b7d792c1069b18f3a15be66167c08e66e7 [INFO] running `Command { std: "docker" "start" "-a" "8173d8795531d1b1dfe34ff450e798b7d792c1069b18f3a15be66167c08e66e7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8173d8795531d1b1dfe34ff450e798b7d792c1069b18f3a15be66167c08e66e7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8173d8795531d1b1dfe34ff450e798b7d792c1069b18f3a15be66167c08e66e7", kill_on_drop: false }` [INFO] [stdout] 8173d8795531d1b1dfe34ff450e798b7d792c1069b18f3a15be66167c08e66e7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 092cb686956c944803ff08c8068e48ba9ef162729d1445b8e7d594493b004079 [INFO] running `Command { std: "docker" "start" "-a" "092cb686956c944803ff08c8068e48ba9ef162729d1445b8e7d594493b004079", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling libc v0.2.44 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling serde v1.0.104 [INFO] [stderr] Compiling memchr v2.3.0 [INFO] [stderr] Compiling proc-macro2 v0.4.24 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Compiling ryu v0.2.7 [INFO] [stderr] Checking itoa v0.4.3 [INFO] [stderr] Compiling ryu v1.0.2 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Checking either v1.5.0 [INFO] [stderr] Compiling rayon-core v1.7.0 [INFO] [stderr] Compiling crossbeam-utils v0.7.0 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling crossbeam-epoch v0.8.0 [INFO] [stderr] Checking byteorder v1.2.7 [INFO] [stderr] Checking regex-automata v0.1.8 [INFO] [stderr] Checking num_cpus v1.8.0 [INFO] [stderr] Checking unicode-width v0.1.5 [INFO] [stderr] Compiling memoffset v0.5.3 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking csv-core v0.1.6 [INFO] [stderr] Checking crossbeam-queue v0.2.1 [INFO] [stderr] Checking itertools v0.8.0 [INFO] [stderr] Compiling quote v0.6.10 [INFO] [stderr] Checking regex-syntax v0.6.14 [INFO] [stderr] Compiling syn v0.15.22 [INFO] [stderr] Checking bitflags v1.0.4 [INFO] [stderr] Checking crossbeam-deque v0.7.2 [INFO] [stderr] Checking same-file v1.0.4 [INFO] [stderr] Checking cast v0.2.2 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Checking rayon v1.3.0 [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Checking criterion-plot v0.4.1 [INFO] [stderr] Checking oorandom v11.1.0 [INFO] [stderr] Checking plotters v0.2.12 [INFO] [stderr] Checking graphplan v0.6.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking regex v1.3.4 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/action.rs:58:17 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn new(id: ActionId, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | reqs: HashSet<&'a Proposition>, [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | effects: HashSet<&'a Proposition>) [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | id: ActionType::Action(id), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plangraph.rs:36:26 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn new(initial_props: HashSet<&'a Proposition>, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | goals: HashSet<&'a Proposition>, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | actions: HashSet<&'a Action>) -> Self { [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | let init_layer = Layer::PropositionLayer(initial_props); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | mutex_props: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plangraph.rs:37:28 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn new(initial_props: HashSet<&'a Proposition>, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | goals: HashSet<&'a Proposition>, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | actions: HashSet<&'a Action>) -> Self { [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | let init_layer = Layer::PropositionLayer(initial_props); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | mutex_actions: HashMap::new() [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&Action<'_, ActionId, PropositionId>` instead of cloning the inner type [INFO] [stdout] --> src/solver.rs:143:43 [INFO] [stdout] | [INFO] [stdout] 143 | available.insert(a.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&Action<'_, ActionId, PropositionId>` instead of cloning the inner type [INFO] [stdout] --> src/solver.rs:155:47 [INFO] [stdout] | [INFO] [stdout] 155 | ... available.insert(a.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&Action<'_, ActionId, PropositionId>` instead of cloning the inner type [INFO] [stdout] --> src/solver.rs:176:56 [INFO] [stdout] | [INFO] [stdout] 176 | self.accum.insert(goal_idx, next_action.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/solver.rs:361:34 [INFO] [stdout] | [INFO] [stdout] 359 | let mutexes = plangraph.mutex_actions.get(&(idx - 1)).cloned(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 360 | let mut gen = action_gen [INFO] [stdout] 361 | .or_else(|| Some(GoalSetActionGenerator::new(goals.clone(), [INFO] [stdout] | __________________________________^ [INFO] [stdout] 362 | | actions.clone(), [INFO] [stdout] 363 | | mutexes).into_iter())) [INFO] [stdout] | |_________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `graphplan` (lib) due to 5 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "092cb686956c944803ff08c8068e48ba9ef162729d1445b8e7d594493b004079", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "092cb686956c944803ff08c8068e48ba9ef162729d1445b8e7d594493b004079", kill_on_drop: false }` [INFO] [stdout] 092cb686956c944803ff08c8068e48ba9ef162729d1445b8e7d594493b004079