[INFO] fetching crate graphite_binary_macros 0.1.0... [INFO] checking graphite_binary_macros-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate graphite_binary_macros 0.1.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate graphite_binary_macros 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate graphite_binary_macros 0.1.0 [INFO] finished tweaking crates.io crate graphite_binary_macros 0.1.0 [INFO] tweaked toml for crates.io crate graphite_binary_macros 0.1.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 6 packages to latest compatible versions [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a40c9cee92a283c27acb57b4e08cda781259c1e47edb1c6ebdaa32ec3dc41b72 [INFO] running `Command { std: "docker" "start" "-a" "a40c9cee92a283c27acb57b4e08cda781259c1e47edb1c6ebdaa32ec3dc41b72", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a40c9cee92a283c27acb57b4e08cda781259c1e47edb1c6ebdaa32ec3dc41b72", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a40c9cee92a283c27acb57b4e08cda781259c1e47edb1c6ebdaa32ec3dc41b72", kill_on_drop: false }` [INFO] [stdout] a40c9cee92a283c27acb57b4e08cda781259c1e47edb1c6ebdaa32ec3dc41b72 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1ae2a0c5a89be28b245b11c48563f91433595cd74e3ce6e1693a284d7f9277d0 [INFO] running `Command { std: "docker" "start" "-a" "1ae2a0c5a89be28b245b11c48563f91433595cd74e3ce6e1693a284d7f9277d0", kill_on_drop: false }` [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking anyhow v1.0.86 [INFO] [stderr] Checking proc-macro2 v1.0.86 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking graphite_binary_macros v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:95:12 [INFO] [stdout] | [INFO] [stdout] 39 | let vis = input.parse()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let ident = input.parse()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let _: Token![:] = input.parse()?; [INFO] [stdout] 42 | let field_type = input.parse()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | [INFO] [stdout] 44 | let (special_instruction, serialize_type) = if input.peek(Token![as]) { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let instruction: Ident = input.parse()?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | let _parenthesized; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | parenthesized!(_parenthesized in input); [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 96 | | vis, [INFO] [stdout] 97 | | ident, [INFO] [stdout] 98 | | field_type, [INFO] [stdout] 99 | | special_instruction, [INFO] [stdout] 100 | | serialize_type, [INFO] [stdout] 101 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:138:12 [INFO] [stdout] | [INFO] [stdout] 123 | let ident = input.parse()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | [INFO] [stdout] 125 | let lifetime = if input.peek(Token![<]) { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | let _: Token![<] = input.parse()?; [INFO] [stdout] 127 | let lifetime = input.parse()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | let braced; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | braced!(braced in input); [INFO] [stdout] 136 | let punctuated: Punctuated = Punctuated::parse_terminated(&braced)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | [INFO] [stdout] 138 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 139 | | ident, [INFO] [stdout] 140 | | lifetime, [INFO] [stdout] 141 | | fields: punctuated.into_iter().collect(), [INFO] [stdout] 142 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:309:12 [INFO] [stdout] | [INFO] [stdout] 185 | lifetime: proc_macro2::TokenStream, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | prefix: proc_macro2::TokenStream, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | ) -> result::Result { [INFO] [stdout] 188 | let mut get_write_size_impl: proc_macro2::TokenStream = Default::default(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | let mut write_impl: proc_macro2::TokenStream = Default::default(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | let mut read_impl: proc_macro2::TokenStream = Default::default(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | let mut read_impl_construct: proc_macro2::TokenStream = Default::default(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | let mut packed = Vec::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 309 | Ok(VariantSerializeImpl { [INFO] [stdout] | ____________^ [INFO] [stdout] 310 | | read_impl, [INFO] [stdout] 311 | | read_impl_construct, [INFO] [stdout] 312 | | get_write_size_impl, [INFO] [stdout] 313 | | write_impl, [INFO] [stdout] 314 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `graphite_binary_macros` (lib test) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:95:12 [INFO] [stdout] | [INFO] [stdout] 39 | let vis = input.parse()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let ident = input.parse()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let _: Token![:] = input.parse()?; [INFO] [stdout] 42 | let field_type = input.parse()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | [INFO] [stdout] 44 | let (special_instruction, serialize_type) = if input.peek(Token![as]) { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let instruction: Ident = input.parse()?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | let _parenthesized; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | parenthesized!(_parenthesized in input); [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 96 | | vis, [INFO] [stdout] 97 | | ident, [INFO] [stdout] 98 | | field_type, [INFO] [stdout] 99 | | special_instruction, [INFO] [stdout] 100 | | serialize_type, [INFO] [stdout] 101 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:138:12 [INFO] [stdout] | [INFO] [stdout] 123 | let ident = input.parse()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | [INFO] [stdout] 125 | let lifetime = if input.peek(Token![<]) { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | let _: Token![<] = input.parse()?; [INFO] [stdout] 127 | let lifetime = input.parse()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | let braced; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | braced!(braced in input); [INFO] [stdout] 136 | let punctuated: Punctuated = Punctuated::parse_terminated(&braced)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | [INFO] [stdout] 138 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 139 | | ident, [INFO] [stdout] 140 | | lifetime, [INFO] [stdout] 141 | | fields: punctuated.into_iter().collect(), [INFO] [stdout] 142 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:309:12 [INFO] [stdout] | [INFO] [stdout] 185 | lifetime: proc_macro2::TokenStream, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | prefix: proc_macro2::TokenStream, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | ) -> result::Result { [INFO] [stdout] 188 | let mut get_write_size_impl: proc_macro2::TokenStream = Default::default(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | let mut write_impl: proc_macro2::TokenStream = Default::default(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | let mut read_impl: proc_macro2::TokenStream = Default::default(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | let mut read_impl_construct: proc_macro2::TokenStream = Default::default(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | let mut packed = Vec::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 309 | Ok(VariantSerializeImpl { [INFO] [stdout] | ____________^ [INFO] [stdout] 310 | | read_impl, [INFO] [stdout] 311 | | read_impl_construct, [INFO] [stdout] 312 | | get_write_size_impl, [INFO] [stdout] 313 | | write_impl, [INFO] [stdout] 314 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `graphite_binary_macros` (lib) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "1ae2a0c5a89be28b245b11c48563f91433595cd74e3ce6e1693a284d7f9277d0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1ae2a0c5a89be28b245b11c48563f91433595cd74e3ce6e1693a284d7f9277d0", kill_on_drop: false }` [INFO] [stdout] 1ae2a0c5a89be28b245b11c48563f91433595cd74e3ce6e1693a284d7f9277d0