[INFO] fetching crate graphic-walker-parser 0.0.10... [INFO] checking graphic-walker-parser-0.0.10 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate graphic-walker-parser 0.0.10 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate graphic-walker-parser 0.0.10 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate graphic-walker-parser 0.0.10 [INFO] finished tweaking crates.io crate graphic-walker-parser 0.0.10 [INFO] tweaked toml for crates.io crate graphic-walker-parser 0.0.10 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 19 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.21.7 (latest: v0.22.1) [INFO] [stderr] Adding sqlparser v0.36.1 (latest: v0.50.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bb8338186c0da92c82a7a23544a0d87153dcb3792f7a1a7331eedb938e22a333 [INFO] running `Command { std: "docker" "start" "-a" "bb8338186c0da92c82a7a23544a0d87153dcb3792f7a1a7331eedb938e22a333", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bb8338186c0da92c82a7a23544a0d87153dcb3792f7a1a7331eedb938e22a333", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bb8338186c0da92c82a7a23544a0d87153dcb3792f7a1a7331eedb938e22a333", kill_on_drop: false }` [INFO] [stdout] bb8338186c0da92c82a7a23544a0d87153dcb3792f7a1a7331eedb938e22a333 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8f29f425b6a3b2d5a9df27dfe23d05f7070a59338190ba899187cad406163047 [INFO] running `Command { std: "docker" "start" "-a" "8f29f425b6a3b2d5a9df27dfe23d05f7070a59338190ba899187cad406163047", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking sqlparser v0.36.1 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking graphic-walker-parser v0.0.10 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/builder.rs:142:18 [INFO] [stdout] | [INFO] [stdout] 141 | let select_body = self.build_select(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | Box::new(Query { [INFO] [stdout] | __________________^ [INFO] [stdout] 143 | | body: Box::new(SetExpr::Select(select_body)), [INFO] [stdout] 144 | | order_by: self.order_by.clone(), [INFO] [stdout] 145 | | limit: self.limit.clone(), [INFO] [stdout] ... | [INFO] [stdout] 149 | | locks: self.locks.clone(), [INFO] [stdout] 150 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/expr.rs:17:16 [INFO] [stdout] | [INFO] [stdout] 17 | value: Expr::Value(Value::Number(o.to_string(), false)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/expr.rs:36:10 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn merge_binary_op(list: Vec>) -> Option { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | Some(Expr::BinaryOp { [INFO] [stdout] | __________^ [INFO] [stdout] 37 | | left: Box::new(list[0].clone()?), [INFO] [stdout] 38 | | right: Box::new(merge_binary_op(list[1..].to_vec())?), [INFO] [stdout] 39 | | op: BinaryOperator::And, [INFO] [stdout] 40 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/expr.rs:69:15 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn get_binary_op_epxr(left: Expr, right: Expr, op: BinaryOperator) -> Expr { [INFO] [stdout] | ---------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | Expr::BinaryOp { [INFO] [stdout] 69 | left: Box::new(left), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/expr.rs:71:16 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn get_binary_op_epxr(left: Expr, right: Expr, op: BinaryOperator) -> Expr { [INFO] [stdout] | ---------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | right: Box::new(right), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/expr.rs:76:20 [INFO] [stdout] | [INFO] [stdout] 75 | pub fn get_function_expr(fun_name: String, args: Vec) -> Expr { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | Expr::Function(Function { [INFO] [stdout] | ____________________^ [INFO] [stdout] 77 | | name: ObjectName(vec![Ident { [INFO] [stdout] 78 | | value: fun_name, [INFO] [stdout] 79 | | quote_style: None, [INFO] [stdout] ... | [INFO] [stdout] 85 | | order_by: vec![], [INFO] [stdout] 86 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/expr.rs:94:20 [INFO] [stdout] | [INFO] [stdout] 91 | args: Vec, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | spec: WindowType, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | ) -> Expr { [INFO] [stdout] 94 | Expr::Function(Function { [INFO] [stdout] | ____________________^ [INFO] [stdout] 95 | | name: ObjectName(vec![Ident { [INFO] [stdout] 96 | | value: fun_name, [INFO] [stdout] 97 | | quote_style: None, [INFO] [stdout] ... | [INFO] [stdout] 103 | | order_by: vec![], [INFO] [stdout] 104 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/builder.rs:142:18 [INFO] [stdout] | [INFO] [stdout] 141 | let select_body = self.build_select(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | Box::new(Query { [INFO] [stdout] | __________________^ [INFO] [stdout] 143 | | body: Box::new(SetExpr::Select(select_body)), [INFO] [stdout] 144 | | order_by: self.order_by.clone(), [INFO] [stdout] 145 | | limit: self.limit.clone(), [INFO] [stdout] ... | [INFO] [stdout] 149 | | locks: self.locks.clone(), [INFO] [stdout] 150 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/expr.rs:17:16 [INFO] [stdout] | [INFO] [stdout] 17 | value: Expr::Value(Value::Number(o.to_string(), false)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/expr.rs:36:10 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn merge_binary_op(list: Vec>) -> Option { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | Some(Expr::BinaryOp { [INFO] [stdout] | __________^ [INFO] [stdout] 37 | | left: Box::new(list[0].clone()?), [INFO] [stdout] 38 | | right: Box::new(merge_binary_op(list[1..].to_vec())?), [INFO] [stdout] 39 | | op: BinaryOperator::And, [INFO] [stdout] 40 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/expr.rs:69:15 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn get_binary_op_epxr(left: Expr, right: Expr, op: BinaryOperator) -> Expr { [INFO] [stdout] | ---------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | Expr::BinaryOp { [INFO] [stdout] 69 | left: Box::new(left), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/expr.rs:71:16 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn get_binary_op_epxr(left: Expr, right: Expr, op: BinaryOperator) -> Expr { [INFO] [stdout] | ---------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | right: Box::new(right), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/expr.rs:76:20 [INFO] [stdout] | [INFO] [stdout] 75 | pub fn get_function_expr(fun_name: String, args: Vec) -> Expr { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | Expr::Function(Function { [INFO] [stdout] | ____________________^ [INFO] [stdout] 77 | | name: ObjectName(vec![Ident { [INFO] [stdout] 78 | | value: fun_name, [INFO] [stdout] 79 | | quote_style: None, [INFO] [stdout] ... | [INFO] [stdout] 85 | | order_by: vec![], [INFO] [stdout] 86 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/expr.rs:94:20 [INFO] [stdout] | [INFO] [stdout] 91 | args: Vec, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | spec: WindowType, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | ) -> Expr { [INFO] [stdout] 94 | Expr::Function(Function { [INFO] [stdout] | ____________________^ [INFO] [stdout] 95 | | name: ObjectName(vec![Ident { [INFO] [stdout] 96 | | value: fun_name, [INFO] [stdout] 97 | | quote_style: None, [INFO] [stdout] ... | [INFO] [stdout] 103 | | order_by: vec![], [INFO] [stdout] 104 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `graphic-walker-parser` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `graphic-walker-parser` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "8f29f425b6a3b2d5a9df27dfe23d05f7070a59338190ba899187cad406163047", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8f29f425b6a3b2d5a9df27dfe23d05f7070a59338190ba899187cad406163047", kill_on_drop: false }` [INFO] [stdout] 8f29f425b6a3b2d5a9df27dfe23d05f7070a59338190ba899187cad406163047