[INFO] fetching crate goxoy-socket-server 0.1.2... [INFO] checking goxoy-socket-server-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate goxoy-socket-server 0.1.2 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate goxoy-socket-server 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate goxoy-socket-server 0.1.2 [INFO] finished tweaking crates.io crate goxoy-socket-server 0.1.2 [INFO] tweaked toml for crates.io crate goxoy-socket-server 0.1.2 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 3 packages to latest compatible versions [INFO] [stderr] Adding goxoy-address-parser v0.0.9 (latest: v0.0.10) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0bc24b700e63884fb8e701d81f3e218ac64a3442ef3ac4c71f0f2c56219ebb74 [INFO] running `Command { std: "docker" "start" "-a" "0bc24b700e63884fb8e701d81f3e218ac64a3442ef3ac4c71f0f2c56219ebb74", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0bc24b700e63884fb8e701d81f3e218ac64a3442ef3ac4c71f0f2c56219ebb74", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0bc24b700e63884fb8e701d81f3e218ac64a3442ef3ac4c71f0f2c56219ebb74", kill_on_drop: false }` [INFO] [stdout] 0bc24b700e63884fb8e701d81f3e218ac64a3442ef3ac4c71f0f2c56219ebb74 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6d3761e98d2338ca85e8f554852a76797088f15cb6aa92b6ccd7201fdce40ef8 [INFO] running `Command { std: "docker" "start" "-a" "6d3761e98d2338ca85e8f554852a76797088f15cb6aa92b6ccd7201fdce40ef8", kill_on_drop: false }` [INFO] [stderr] Checking goxoy-address-parser v0.0.9 [INFO] [stderr] Checking goxoy-socket-client v0.1.9 [INFO] [stderr] Checking goxoy-socket-server v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unreachable statement [INFO] [stdout] --> src/socket_server.rs:208:9 [INFO] [stdout] | [INFO] [stdout] 148 | / loop { [INFO] [stdout] 149 | | if let Ok((mut socket, addr)) = server.accept() { [INFO] [stdout] 150 | | if on_new_client_fn.is_some() { [INFO] [stdout] 151 | | on_new_client_fn.unwrap()( [INFO] [stdout] ... | [INFO] [stdout] 206 | | thread::sleep(::std::time::Duration::from_millis(100)); [INFO] [stdout] 207 | | } [INFO] [stdout] | |_________- any code following this expression is unreachable [INFO] [stdout] 208 | return true; [INFO] [stdout] | ^^^^^^^^^^^^ unreachable statement [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable statement [INFO] [stdout] --> src/socket_server.rs:208:9 [INFO] [stdout] | [INFO] [stdout] 148 | / loop { [INFO] [stdout] 149 | | if let Ok((mut socket, addr)) = server.accept() { [INFO] [stdout] 150 | | if on_new_client_fn.is_some() { [INFO] [stdout] 151 | | on_new_client_fn.unwrap()( [INFO] [stdout] ... | [INFO] [stdout] 206 | | thread::sleep(::std::time::Duration::from_millis(100)); [INFO] [stdout] 207 | | } [INFO] [stdout] | |_________- any code following this expression is unreachable [INFO] [stdout] 208 | return true; [INFO] [stdout] | ^^^^^^^^^^^^ unreachable statement [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `peer_addr` [INFO] [stdout] --> src/socket_server.rs:111:27 [INFO] [stdout] | [INFO] [stdout] 111 | pub fn send(&mut self,peer_addr:String, data: Vec)->bool{ [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_peer_addr` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `peer_addr` [INFO] [stdout] --> src/socket_server.rs:111:27 [INFO] [stdout] | [INFO] [stdout] 111 | pub fn send(&mut self,peer_addr:String, data: Vec)->bool{ [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_peer_addr` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/socket_server.rs:113:13 [INFO] [stdout] | [INFO] [stdout] 113 | self.tx.as_mut().unwrap().send(data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 113 | let _ = self.tx.as_mut().unwrap().send(data); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket_server.rs:202:25 [INFO] [stdout] | [INFO] [stdout] 200 | .filter_map(|mut client| { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | //println!("sent data"); [INFO] [stdout] 202 | client.write_all(&msg).map(|_| client).ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/socket_server.rs:113:13 [INFO] [stdout] | [INFO] [stdout] 113 | self.tx.as_mut().unwrap().send(data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 113 | let _ = self.tx.as_mut().unwrap().send(data); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket_server.rs:202:25 [INFO] [stdout] | [INFO] [stdout] 200 | .filter_map(|mut client| { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | //println!("sent data"); [INFO] [stdout] 202 | client.write_all(&msg).map(|_| client).ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `goxoy-socket-server` (lib) due to 2 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `goxoy-socket-server` (lib test) due to 2 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "6d3761e98d2338ca85e8f554852a76797088f15cb6aa92b6ccd7201fdce40ef8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6d3761e98d2338ca85e8f554852a76797088f15cb6aa92b6ccd7201fdce40ef8", kill_on_drop: false }` [INFO] [stdout] 6d3761e98d2338ca85e8f554852a76797088f15cb6aa92b6ccd7201fdce40ef8