[INFO] fetching crate gotham_formdata_derive 0.0.7... [INFO] checking gotham_formdata_derive-0.0.7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate gotham_formdata_derive 0.0.7 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate gotham_formdata_derive 0.0.7 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gotham_formdata_derive 0.0.7 [INFO] finished tweaking crates.io crate gotham_formdata_derive 0.0.7 [INFO] tweaked toml for crates.io crate gotham_formdata_derive 0.0.7 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 6 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ee82b3d3692a0f3b51ed7c7acfcb70a1fd2986739da66b6289e56692bf1e691f [INFO] running `Command { std: "docker" "start" "-a" "ee82b3d3692a0f3b51ed7c7acfcb70a1fd2986739da66b6289e56692bf1e691f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ee82b3d3692a0f3b51ed7c7acfcb70a1fd2986739da66b6289e56692bf1e691f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ee82b3d3692a0f3b51ed7c7acfcb70a1fd2986739da66b6289e56692bf1e691f", kill_on_drop: false }` [INFO] [stdout] ee82b3d3692a0f3b51ed7c7acfcb70a1fd2986739da66b6289e56692bf1e691f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ebadd29ebb4f11867c3817140d93c194de5dcc47df6507e0810a2438305adb9d [INFO] running `Command { std: "docker" "start" "-a" "ebadd29ebb4f11867c3817140d93c194de5dcc47df6507e0810a2438305adb9d", kill_on_drop: false }` [INFO] [stderr] Checking syn v2.0.77 [INFO] [stderr] Checking syn-path v2.0.0 [INFO] [stderr] Checking gotham_formdata_derive v0.0.7 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait `PathEndsWith` is never used [INFO] [stdout] --> src/util.rs:35:18 [INFO] [stdout] | [INFO] [stdout] 35 | pub(crate) trait PathEndsWith { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `WithSpan` is never used [INFO] [stdout] --> src/util.rs:48:18 [INFO] [stdout] | [INFO] [stdout] 48 | pub(crate) trait WithSpan { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:30:3 [INFO] [stdout] | [INFO] [stdout] 25 | fn expand_derive(input: TokenStream, expand: F) -> TokenStream [INFO] [stdout] | ------------------ --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | expand(parse_macro_input!(input)).unwrap_or_else(|err| err.to_compile_error()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:18:4 [INFO] [stdout] | [INFO] [stdout] 16 | fn collect_to_result(self) -> Result, Error> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | self.fold( [INFO] [stdout] 18 | , Error>>::Ok(Vec::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:19:22 [INFO] [stdout] | [INFO] [stdout] 19 | |res, code| match (code, res) { [INFO] [stdout] | --- ---- ^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/form_data/mod.rs:24:15 [INFO] [stdout] | [INFO] [stdout] 24 | predicates: Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/form_data/mod.rs:114:23 [INFO] [stdout] | [INFO] [stdout] 113 | fn where_predicate_t_send(t: Type) -> WherePredicate { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | WherePredicate::Type(PredicateType { [INFO] [stdout] | __________________________^ [INFO] [stdout] 115 | | lifetimes: None, [INFO] [stdout] 116 | | bounded_ty: t, [INFO] [stdout] 117 | | colon_token: Default::default(), [INFO] [stdout] ... | [INFO] [stdout] 124 | | .collect() [INFO] [stdout] 125 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/form_data/mod.rs:134:23 [INFO] [stdout] | [INFO] [stdout] 129 | fn where_predicate_value_parse_t(t: Type) -> WherePredicate { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | let lt = Lifetime { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | WherePredicate::Type(PredicateType { [INFO] [stdout] | __________________________^ [INFO] [stdout] 135 | | lifetimes: Some(BoundLifetimes { [INFO] [stdout] 136 | | for_token: Default::default(), [INFO] [stdout] 137 | | lt_token: Default::default(), [INFO] [stdout] ... | [INFO] [stdout] 175 | | .collect() [INFO] [stdout] 176 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/form_data/field.rs:39:6 [INFO] [stdout] | [INFO] [stdout] 31 | pub(super) fn new(field: syn::Field) -> Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | let mut ident = field.ident.ok_or_else(|| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | Ok(Self { ident, ty: field.ty }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gotham_formdata_derive` (lib test) due to 8 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: trait `PathEndsWith` is never used [INFO] [stdout] --> src/util.rs:35:18 [INFO] [stdout] | [INFO] [stdout] 35 | pub(crate) trait PathEndsWith { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `WithSpan` is never used [INFO] [stdout] --> src/util.rs:48:18 [INFO] [stdout] | [INFO] [stdout] 48 | pub(crate) trait WithSpan { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:30:3 [INFO] [stdout] | [INFO] [stdout] 25 | fn expand_derive(input: TokenStream, expand: F) -> TokenStream [INFO] [stdout] | ------------------ --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | expand(parse_macro_input!(input)).unwrap_or_else(|err| err.to_compile_error()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:18:4 [INFO] [stdout] | [INFO] [stdout] 16 | fn collect_to_result(self) -> Result, Error> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | self.fold( [INFO] [stdout] 18 | , Error>>::Ok(Vec::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:19:22 [INFO] [stdout] | [INFO] [stdout] 19 | |res, code| match (code, res) { [INFO] [stdout] | --- ---- ^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/form_data/mod.rs:24:15 [INFO] [stdout] | [INFO] [stdout] 24 | predicates: Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/form_data/mod.rs:114:23 [INFO] [stdout] | [INFO] [stdout] 113 | fn where_predicate_t_send(t: Type) -> WherePredicate { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | WherePredicate::Type(PredicateType { [INFO] [stdout] | __________________________^ [INFO] [stdout] 115 | | lifetimes: None, [INFO] [stdout] 116 | | bounded_ty: t, [INFO] [stdout] 117 | | colon_token: Default::default(), [INFO] [stdout] ... | [INFO] [stdout] 124 | | .collect() [INFO] [stdout] 125 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/form_data/mod.rs:134:23 [INFO] [stdout] | [INFO] [stdout] 129 | fn where_predicate_value_parse_t(t: Type) -> WherePredicate { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | let lt = Lifetime { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | WherePredicate::Type(PredicateType { [INFO] [stdout] | __________________________^ [INFO] [stdout] 135 | | lifetimes: Some(BoundLifetimes { [INFO] [stdout] 136 | | for_token: Default::default(), [INFO] [stdout] 137 | | lt_token: Default::default(), [INFO] [stdout] ... | [INFO] [stdout] 175 | | .collect() [INFO] [stdout] 176 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/form_data/field.rs:39:6 [INFO] [stdout] | [INFO] [stdout] 31 | pub(super) fn new(field: syn::Field) -> Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | let mut ident = field.ident.ok_or_else(|| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | Ok(Self { ident, ty: field.ty }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gotham_formdata_derive` (lib) due to 8 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "ebadd29ebb4f11867c3817140d93c194de5dcc47df6507e0810a2438305adb9d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ebadd29ebb4f11867c3817140d93c194de5dcc47df6507e0810a2438305adb9d", kill_on_drop: false }` [INFO] [stdout] ebadd29ebb4f11867c3817140d93c194de5dcc47df6507e0810a2438305adb9d