[INFO] fetching crate gossip 0.0.3... [INFO] checking gossip-0.0.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate gossip 0.0.3 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate gossip 0.0.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gossip 0.0.3 [INFO] finished tweaking crates.io crate gossip 0.0.3 [INFO] tweaked toml for crates.io crate gossip 0.0.3 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 101 packages to latest compatible versions [INFO] [stderr] Adding arrayvec v0.5.2 (latest: v0.7.6) [INFO] [stderr] Adding blake3 v0.3.8 (latest: v1.5.4) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding constant_time_eq v0.1.5 (latest: v0.3.1) [INFO] [stderr] Adding crypto-mac v0.8.0 (latest: v0.11.1) [INFO] [stderr] Adding destructure_traitobject v0.2.0 (latest: v0.3.0) [INFO] [stderr] Adding digest v0.9.0 (latest: v0.10.7) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding getrandom v0.1.16 (latest: v0.2.15) [INFO] [stderr] Adding half v1.8.3 (latest: v2.4.1) [INFO] [stderr] Adding ordered-float v2.10.1 (latest: v4.2.2) [INFO] [stderr] Adding rand v0.7.3 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.2.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.5.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.2.0 (latest: v0.3.2) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8d126cf3f8081c9df2c2d429e85223af80c63b86ca6ae3c4c8c6d87f29740c54 [INFO] running `Command { std: "docker" "start" "-a" "8d126cf3f8081c9df2c2d429e85223af80c63b86ca6ae3c4c8c6d87f29740c54", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8d126cf3f8081c9df2c2d429e85223af80c63b86ca6ae3c4c8c6d87f29740c54", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8d126cf3f8081c9df2c2d429e85223af80c63b86ca6ae3c4c8c6d87f29740c54", kill_on_drop: false }` [INFO] [stdout] 8d126cf3f8081c9df2c2d429e85223af80c63b86ca6ae3c4c8c6d87f29740c54 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9ce9b94a0e0a41bd627eab91baf1d3dcf6e67406a4a0ab6eebecc41607ebbb98 [INFO] running `Command { std: "docker" "start" "-a" "9ce9b94a0e0a41bd627eab91baf1d3dcf6e67406a4a0ab6eebecc41607ebbb98", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking destructure_traitobject v0.2.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling blake3 v0.3.8 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking ordered-float v2.10.1 [INFO] [stderr] Checking thread-id v4.2.2 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking log-mdc v0.1.0 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking unsafe-any-ors v1.0.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking typemap-ors v1.0.0 [INFO] [stderr] Checking crypto-mac v0.8.0 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking serde-value v0.7.0 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking gossip v0.0.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: value assigned to `error` is never read [INFO] [stdout] --> src/gossip.rs:331:17 [INFO] [stdout] | [INFO] [stdout] 331 | error = true; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `error` [INFO] [stdout] --> src/gossip.rs:331:17 [INFO] [stdout] | [INFO] [stdout] 331 | error = true; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: did you mean to capture by reference instead? [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sampling.rs:136:9 [INFO] [stdout] | [INFO] [stdout] 132 | fn start_receiver(&self, receiver: Receiver) -> JoinHandle<()>{ [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | let view_arc = self.view.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 136 | / std::thread::Builder::new().name(format!("{} - gbps receiver", &address)).spawn(move|| { [INFO] [stdout] 137 | | log::info!("Started message handling thread"); [INFO] [stdout] 138 | | while let Ok(message) = receiver.recv() { [INFO] [stdout] 139 | | log::debug!("Received: {:?}", message); [INFO] [stdout] ... | [INFO] [stdout] 166 | | log::info!("Message handling thread exiting"); [INFO] [stdout] 167 | | }).unwrap() [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sampling.rs:176:9 [INFO] [stdout] | [INFO] [stdout] 174 | let view_arc = self.view.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | let shutdown_requested = Arc::clone(&self.shutdown); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | / std::thread::Builder::new().name(format!("{} - gbps sampling", address)).spawn(move || { [INFO] [stdout] 177 | | log::info!("Started peer sampling thread"); [INFO] [stdout] 178 | | loop { [INFO] [stdout] 179 | | // Compute time for sleep cycle [INFO] [stdout] ... | [INFO] [stdout] 225 | | log::info!("Peer sampling thread exiting"); [INFO] [stdout] 226 | | }).unwrap() [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::mem::replace` that must be used [INFO] [stdout] --> src/sampling.rs:293:13 [INFO] [stdout] | [INFO] [stdout] 293 | std::mem::replace(&mut self.peers, new_view_start); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 293 | let _ = std::mem::replace(&mut self.peers, new_view_start); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::mem::replace` that must be used [INFO] [stdout] --> src/sampling.rs:357:9 [INFO] [stdout] | [INFO] [stdout] 357 | std::mem::replace(&mut self.peers, new_view); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 357 | let _ = std::mem::replace(&mut self.peers, new_view); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::mem::replace` that must be used [INFO] [stdout] --> src/sampling.rs:379:13 [INFO] [stdout] | [INFO] [stdout] 379 | std::mem::replace(&mut self.peers, new_view); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 379 | let _ = std::mem::replace(&mut self.peers, new_view); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network.rs:21:11 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn send(address: &SocketAddr, message: Box) -> Result> [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | match message.as_bytes() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network.rs:48:8 [INFO] [stdout] | [INFO] [stdout] 44 | pub fn listen(address: &SocketAddr, shutdown: Arc, peer_sampling_sender: Sender, header_sender: Sender, content_sender: Sender) -... [INFO] [stdout] | -------------------------------------------- ------------------------------------------------- ------------------------------------ -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | [INFO] [stdout] 46 | let listener = std::net::TcpListener::bind(address)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | log::info!("Listener started at {}", address); [INFO] [stdout] 48 | Ok(std::thread::Builder::new().name(format!("{} - gossip listener", address)).spawn(move || { [INFO] [stdout] | ________^ [INFO] [stdout] 49 | | log::info!("Started listener thread"); [INFO] [stdout] 50 | | // TODO: handle hanging connections where peer connect but does not write [INFO] [stdout] 51 | | for incoming_stream in listener.incoming() { [INFO] [stdout] ... | [INFO] [stdout] 79 | | log::info!("Listener thread exiting"); [INFO] [stdout] 80 | | }).unwrap()) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gossip` (lib) due to 5 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "9ce9b94a0e0a41bd627eab91baf1d3dcf6e67406a4a0ab6eebecc41607ebbb98", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9ce9b94a0e0a41bd627eab91baf1d3dcf6e67406a4a0ab6eebecc41607ebbb98", kill_on_drop: false }` [INFO] [stdout] 9ce9b94a0e0a41bd627eab91baf1d3dcf6e67406a4a0ab6eebecc41607ebbb98