[INFO] fetching crate goscript-parser 0.1.0... [INFO] checking goscript-parser-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate goscript-parser 0.1.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate goscript-parser 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate goscript-parser 0.1.0 [INFO] finished tweaking crates.io crate goscript-parser 0.1.0 [INFO] tweaked toml for crates.io crate goscript-parser 0.1.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 2 packages to latest compatible versions [INFO] [stderr] Adding slotmap v0.4.3 (latest: v1.0.7) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9365da51113ddc33bbdaa291b809725d44f52a42c557ba5c69e622f2fad08127 [INFO] running `Command { std: "docker" "start" "-a" "9365da51113ddc33bbdaa291b809725d44f52a42c557ba5c69e622f2fad08127", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9365da51113ddc33bbdaa291b809725d44f52a42c557ba5c69e622f2fad08127", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9365da51113ddc33bbdaa291b809725d44f52a42c557ba5c69e622f2fad08127", kill_on_drop: false }` [INFO] [stdout] 9365da51113ddc33bbdaa291b809725d44f52a42c557ba5c69e622f2fad08127 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 002cba1a9b3c709880a1ecf4c4b44306fafbb12707b90d392657c00fef0b9ee6 [INFO] running `Command { std: "docker" "start" "-a" "002cba1a9b3c709880a1ecf4c4b44306fafbb12707b90d392657c00fef0b9ee6", kill_on_drop: false }` [INFO] [stderr] Checking slotmap v0.4.3 [INFO] [stderr] Checking goscript-parser v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:102:24 [INFO] [stdout] | [INFO] [stdout] 101 | pub fn new_selector(x: Expr, sel: IdentKey) -> Expr { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | Expr::Selector(Rc::new(SelectorExpr { expr: x, sel: sel })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:106:24 [INFO] [stdout] | [INFO] [stdout] 105 | pub fn new_ellipsis(pos: position::Pos, x: Option) -> Expr { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | Expr::Ellipsis(Rc::new(Ellipsis { pos: pos, elt: x })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:110:24 [INFO] [stdout] | [INFO] [stdout] 109 | pub fn new_basic_lit(pos: position::Pos, token: token::Token) -> Expr { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | Expr::BasicLit(Rc::new(BasicLit { [INFO] [stdout] | ________________________^ [INFO] [stdout] 111 | | pos: pos, [INFO] [stdout] 112 | | token: token, [INFO] [stdout] 113 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:117:21 [INFO] [stdout] | [INFO] [stdout] 116 | pub fn new_unary_expr(pos: position::Pos, op: token::Token, expr: Expr) -> Expr { [INFO] [stdout] | ---------------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | Expr::Unary(Rc::new(UnaryExpr { [INFO] [stdout] | _____________________^ [INFO] [stdout] 118 | | op_pos: pos, [INFO] [stdout] 119 | | op: op, [INFO] [stdout] 120 | | expr: expr, [INFO] [stdout] 121 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:272:21 [INFO] [stdout] | [INFO] [stdout] 271 | pub fn box_block(block: BlockStmt) -> Stmt { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 272 | Stmt::Block(Rc::new(block)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:575:21 [INFO] [stdout] | [INFO] [stdout] 558 | let len = match self.token { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 561 | let ell = Expr::new_ellipsis(self.pos, None); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 572 | let elt = self.parse_type(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 575 | Expr::Array(Rc::new(ArrayType{ [INFO] [stdout] | _____________________^ [INFO] [stdout] 576 | | l_brack: lpos, len: len, elt: elt})) [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:689:20 [INFO] [stdout] | [INFO] [stdout] 686 | let base = self.parse_type(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 689 | Expr::Star(Rc::new(StarExpr{star: star, expr: base})) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:1094:24 [INFO] [stdout] | [INFO] [stdout] 1090 | fn parse_selector(&mut self, x: Expr) -> Expr { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1094 | Expr::Selector(Rc::new(SelectorExpr{ [INFO] [stdout] | ________________________^ [INFO] [stdout] 1095 | | expr: x, sel: sel})) [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:1112:26 [INFO] [stdout] | [INFO] [stdout] 1098 | fn parse_type_assertion(&mut self, x: Expr) -> Expr { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1102 | let typ = if self.token == Token::TYPE { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1112 | Expr::TypeAssert(Rc::new(TypeAssertExpr{ [INFO] [stdout] | __________________________^ [INFO] [stdout] 1113 | | expr: x, l_paren: lparen, typ: typ, r_paren: rparen})) [INFO] [stdout] | |_________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:1200:20 [INFO] [stdout] | [INFO] [stdout] 1176 | fn parse_call_or_conversion(&mut self, func: Expr) -> Expr { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1181 | let mut list = vec![]; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1200 | Expr::Call(Rc::new(CallExpr{ [INFO] [stdout] | ____________________^ [INFO] [stdout] 1201 | | func: func, l_paren: lparen, args: list, ellipsis: ellipsis, r_paren: rparen})) [INFO] [stdout] | |__________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:1292:28 [INFO] [stdout] | [INFO] [stdout] 1280 | fn parse_literal_value(&mut self, typ: Option) -> Expr { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1285 | let elts = if self.token != Token::RBRACE { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1292 | Expr::CompositeLit(Rc::new(CompositeLit{ [INFO] [stdout] | ____________________________^ [INFO] [stdout] 1293 | | typ: typ, l_brace: lbrace, elts: elts, r_brace: rbrace, incomplete: false})) [INFO] [stdout] | |_______________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:1740:22 [INFO] [stdout] | [INFO] [stdout] 1734 | let x = match self.token { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1740 | Stmt::Return(Rc::new(ReturnStmt{ret: pos, results: x})) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:1758:22 [INFO] [stdout] | [INFO] [stdout] 1743 | fn parse_branch_stmt(&mut self, token: Token) -> Stmt { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1758 | Stmt::Branch(Rc::new(BranchStmt{ [INFO] [stdout] | ______________________^ [INFO] [stdout] 1759 | | token_pos: pos, token: token, label: label})) [INFO] [stdout] | |________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:1876:18 [INFO] [stdout] | [INFO] [stdout] 1853 | let (init, cond) = self.parse_if_header(); [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1854 | let body = self.parse_block_stmt(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1855 | let els = if self.token == Token::ELSE { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1860 | let block = self.parse_block_stmt(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1876 | Stmt::If(Rc::new(IfStmt{ [INFO] [stdout] | __________________^ [INFO] [stdout] 1877 | | if_pos: pos, init: init, cond: cond, body: Rc::new(body), els: els})) [INFO] [stdout] | |________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:2083:22 [INFO] [stdout] | [INFO] [stdout] 2074 | let mut list = vec![]; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2080 | let body = BlockStmt{l_brace: lbrace, list: list, r_brace: rbrace}; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2083 | Stmt::Select(Rc::new(SelectStmt{select: pos, body: Rc::new(body)})) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:2544:14 [INFO] [stdout] | [INFO] [stdout] 2516 | let mut decls = vec![]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2544 | Some(File{ [INFO] [stdout] | ______________^ [INFO] [stdout] 2545 | | package: pos, [INFO] [stdout] 2546 | | name: ident, [INFO] [stdout] 2547 | | decls: decls, [INFO] [stdout] ... | [INFO] [stdout] 2550 | | unresolved: self.unresolved.clone(), [INFO] [stdout] 2551 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/position.rs:197:30 [INFO] [stdout] | [INFO] [stdout] 197 | return Some(f.borrow()); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `position::File` does not implement `Borrow`, so calling `borrow` on `&position::File` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 197 - return Some(f.borrow()); [INFO] [stdout] 197 + return Some(f); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `position::File`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 42 + #[derive(Clone)] [INFO] [stdout] 43 | pub struct File { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:102:24 [INFO] [stdout] | [INFO] [stdout] 101 | pub fn new_selector(x: Expr, sel: IdentKey) -> Expr { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | Expr::Selector(Rc::new(SelectorExpr { expr: x, sel: sel })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:106:24 [INFO] [stdout] | [INFO] [stdout] 105 | pub fn new_ellipsis(pos: position::Pos, x: Option) -> Expr { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | Expr::Ellipsis(Rc::new(Ellipsis { pos: pos, elt: x })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:110:24 [INFO] [stdout] | [INFO] [stdout] 109 | pub fn new_basic_lit(pos: position::Pos, token: token::Token) -> Expr { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | Expr::BasicLit(Rc::new(BasicLit { [INFO] [stdout] | ________________________^ [INFO] [stdout] 111 | | pos: pos, [INFO] [stdout] 112 | | token: token, [INFO] [stdout] 113 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:117:21 [INFO] [stdout] | [INFO] [stdout] 116 | pub fn new_unary_expr(pos: position::Pos, op: token::Token, expr: Expr) -> Expr { [INFO] [stdout] | ---------------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | Expr::Unary(Rc::new(UnaryExpr { [INFO] [stdout] | _____________________^ [INFO] [stdout] 118 | | op_pos: pos, [INFO] [stdout] 119 | | op: op, [INFO] [stdout] 120 | | expr: expr, [INFO] [stdout] 121 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:272:21 [INFO] [stdout] | [INFO] [stdout] 271 | pub fn box_block(block: BlockStmt) -> Stmt { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 272 | Stmt::Block(Rc::new(block)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:575:21 [INFO] [stdout] | [INFO] [stdout] 558 | let len = match self.token { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 561 | let ell = Expr::new_ellipsis(self.pos, None); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 572 | let elt = self.parse_type(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 575 | Expr::Array(Rc::new(ArrayType{ [INFO] [stdout] | _____________________^ [INFO] [stdout] 576 | | l_brack: lpos, len: len, elt: elt})) [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:689:20 [INFO] [stdout] | [INFO] [stdout] 686 | let base = self.parse_type(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 689 | Expr::Star(Rc::new(StarExpr{star: star, expr: base})) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:1094:24 [INFO] [stdout] | [INFO] [stdout] 1090 | fn parse_selector(&mut self, x: Expr) -> Expr { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1094 | Expr::Selector(Rc::new(SelectorExpr{ [INFO] [stdout] | ________________________^ [INFO] [stdout] 1095 | | expr: x, sel: sel})) [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:1112:26 [INFO] [stdout] | [INFO] [stdout] 1098 | fn parse_type_assertion(&mut self, x: Expr) -> Expr { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1102 | let typ = if self.token == Token::TYPE { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1112 | Expr::TypeAssert(Rc::new(TypeAssertExpr{ [INFO] [stdout] | __________________________^ [INFO] [stdout] 1113 | | expr: x, l_paren: lparen, typ: typ, r_paren: rparen})) [INFO] [stdout] | |_________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:1200:20 [INFO] [stdout] | [INFO] [stdout] 1176 | fn parse_call_or_conversion(&mut self, func: Expr) -> Expr { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1181 | let mut list = vec![]; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1200 | Expr::Call(Rc::new(CallExpr{ [INFO] [stdout] | ____________________^ [INFO] [stdout] 1201 | | func: func, l_paren: lparen, args: list, ellipsis: ellipsis, r_paren: rparen})) [INFO] [stdout] | |__________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:1292:28 [INFO] [stdout] | [INFO] [stdout] 1280 | fn parse_literal_value(&mut self, typ: Option) -> Expr { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1285 | let elts = if self.token != Token::RBRACE { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1292 | Expr::CompositeLit(Rc::new(CompositeLit{ [INFO] [stdout] | ____________________________^ [INFO] [stdout] 1293 | | typ: typ, l_brace: lbrace, elts: elts, r_brace: rbrace, incomplete: false})) [INFO] [stdout] | |_______________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:1740:22 [INFO] [stdout] | [INFO] [stdout] 1734 | let x = match self.token { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1740 | Stmt::Return(Rc::new(ReturnStmt{ret: pos, results: x})) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:1758:22 [INFO] [stdout] | [INFO] [stdout] 1743 | fn parse_branch_stmt(&mut self, token: Token) -> Stmt { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1758 | Stmt::Branch(Rc::new(BranchStmt{ [INFO] [stdout] | ______________________^ [INFO] [stdout] 1759 | | token_pos: pos, token: token, label: label})) [INFO] [stdout] | |________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:1876:18 [INFO] [stdout] | [INFO] [stdout] 1853 | let (init, cond) = self.parse_if_header(); [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1854 | let body = self.parse_block_stmt(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1855 | let els = if self.token == Token::ELSE { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1860 | let block = self.parse_block_stmt(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1876 | Stmt::If(Rc::new(IfStmt{ [INFO] [stdout] | __________________^ [INFO] [stdout] 1877 | | if_pos: pos, init: init, cond: cond, body: Rc::new(body), els: els})) [INFO] [stdout] | |________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:2083:22 [INFO] [stdout] | [INFO] [stdout] 2074 | let mut list = vec![]; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2080 | let body = BlockStmt{l_brace: lbrace, list: list, r_brace: rbrace}; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2083 | Stmt::Select(Rc::new(SelectStmt{select: pos, body: Rc::new(body)})) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:2544:14 [INFO] [stdout] | [INFO] [stdout] 2516 | let mut decls = vec![]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2544 | Some(File{ [INFO] [stdout] | ______________^ [INFO] [stdout] 2545 | | package: pos, [INFO] [stdout] 2546 | | name: ident, [INFO] [stdout] 2547 | | decls: decls, [INFO] [stdout] ... | [INFO] [stdout] 2550 | | unresolved: self.unresolved.clone(), [INFO] [stdout] 2551 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/position.rs:197:30 [INFO] [stdout] | [INFO] [stdout] 197 | return Some(f.borrow()); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `position::File` does not implement `Borrow`, so calling `borrow` on `&position::File` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 197 - return Some(f.borrow()); [INFO] [stdout] 197 + return Some(f); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `position::File`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 42 + #[derive(Clone)] [INFO] [stdout] 43 | pub struct File { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `goscript-parser` (lib) due to 17 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 16 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `goscript-parser` (lib test) due to 17 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "002cba1a9b3c709880a1ecf4c4b44306fafbb12707b90d392657c00fef0b9ee6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "002cba1a9b3c709880a1ecf4c4b44306fafbb12707b90d392657c00fef0b9ee6", kill_on_drop: false }` [INFO] [stdout] 002cba1a9b3c709880a1ecf4c4b44306fafbb12707b90d392657c00fef0b9ee6