[INFO] fetching crate google-fonts-sources 0.3.0... [INFO] checking google-fonts-sources-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate google-fonts-sources 0.3.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate google-fonts-sources 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate google-fonts-sources 0.3.0 [INFO] finished tweaking crates.io crate google-fonts-sources 0.3.0 [INFO] tweaked toml for crates.io crate google-fonts-sources 0.3.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate google-fonts-sources 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d65954dc1d8b8ce627c8ec5c1aa0c5a073e90f980fcab1fc43d3552a05de06bf [INFO] running `Command { std: "docker" "start" "-a" "d65954dc1d8b8ce627c8ec5c1aa0c5a073e90f980fcab1fc43d3552a05de06bf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d65954dc1d8b8ce627c8ec5c1aa0c5a073e90f980fcab1fc43d3552a05de06bf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d65954dc1d8b8ce627c8ec5c1aa0c5a073e90f980fcab1fc43d3552a05de06bf", kill_on_drop: false }` [INFO] [stdout] d65954dc1d8b8ce627c8ec5c1aa0c5a073e90f980fcab1fc43d3552a05de06bf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2d9ae1eba91e0f6eb9990b1f5ee1930cc434cbb1338acb0a129315ac3f2ee5f4 [INFO] running `Command { std: "docker" "start" "-a" "2d9ae1eba91e0f6eb9990b1f5ee1930cc434cbb1338acb0a129315ac3f2ee5f4", kill_on_drop: false }` [INFO] [stderr] Compiling cc v1.0.101 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking rustls-pki-types v1.7.0 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking tinyvec v1.6.1 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Compiling rustls v0.22.4 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Compiling serde_json v1.0.118 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking indexmap v2.4.0 [INFO] [stderr] Checking webpki-roots v0.26.3 [INFO] [stderr] Compiling syn v2.0.68 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking formatx v0.2.2 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking clap_builder v4.5.7 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking kdam v0.5.2 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling clap_derive v4.5.5 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking clap v4.5.7 [INFO] [stderr] Checking rustls-webpki v0.102.4 [INFO] [stderr] Checking ureq v2.9.7 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking font-types v0.7.0 [INFO] [stderr] Checking google-fonts-sources v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:356:28 [INFO] [stdout] | [INFO] [stdout] 356 | .and_then(|config| get_git_rev_remote(repo_url).map(|rev| (config, rev))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:420:13 [INFO] [stdout] | [INFO] [stdout] 419 | .filter_map(|entry| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 420 | / entry [INFO] [stdout] 421 | | .ok() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:521:5 [INFO] [stdout] | [INFO] [stdout] 521 | / std::process::Command::new("git") [INFO] [stdout] 522 | | .current_dir(repo_dir) [INFO] [stdout] 523 | | .arg("checkout") [INFO] [stdout] 524 | | .arg(rev) [INFO] [stdout] 525 | | .status() [INFO] [stdout] 526 | | .map(|stat| stat.success()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:538:33 [INFO] [stdout] | [INFO] [stdout] 538 | contents.filter_map(|entry| entry.ok().map(|d| d.path()).filter(|p| p.is_dir())) [INFO] [stdout] | ----- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | serde_yaml::from_str(&contents).map_err(BadConfig::Yaml) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `google-fonts-sources` (lib test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:356:28 [INFO] [stdout] | [INFO] [stdout] 356 | .and_then(|config| get_git_rev_remote(repo_url).map(|rev| (config, rev))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:420:13 [INFO] [stdout] | [INFO] [stdout] 419 | .filter_map(|entry| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 420 | / entry [INFO] [stdout] 421 | | .ok() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:521:5 [INFO] [stdout] | [INFO] [stdout] 521 | / std::process::Command::new("git") [INFO] [stdout] 522 | | .current_dir(repo_dir) [INFO] [stdout] 523 | | .arg("checkout") [INFO] [stdout] 524 | | .arg(rev) [INFO] [stdout] 525 | | .status() [INFO] [stdout] 526 | | .map(|stat| stat.success()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:538:33 [INFO] [stdout] | [INFO] [stdout] 538 | contents.filter_map(|entry| entry.ok().map(|d| d.path()).filter(|p| p.is_dir())) [INFO] [stdout] | ----- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | serde_yaml::from_str(&contents).map_err(BadConfig::Yaml) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `google-fonts-sources` (lib) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "2d9ae1eba91e0f6eb9990b1f5ee1930cc434cbb1338acb0a129315ac3f2ee5f4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2d9ae1eba91e0f6eb9990b1f5ee1930cc434cbb1338acb0a129315ac3f2ee5f4", kill_on_drop: false }` [INFO] [stdout] 2d9ae1eba91e0f6eb9990b1f5ee1930cc434cbb1338acb0a129315ac3f2ee5f4