[INFO] fetching crate goods 0.12.1... [INFO] checking goods-0.12.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate goods 0.12.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate goods 0.12.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate goods 0.12.1 [INFO] finished tweaking crates.io crate goods 0.12.1 [INFO] tweaked toml for crates.io crate goods 0.12.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate goods 0.12.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7397139df80625931341b16b00a7d56e468c6e1b951c0ecb45d77da82a2bff61 [INFO] running `Command { std: "docker" "start" "-a" "7397139df80625931341b16b00a7d56e468c6e1b951c0ecb45d77da82a2bff61", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7397139df80625931341b16b00a7d56e468c6e1b951c0ecb45d77da82a2bff61", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7397139df80625931341b16b00a7d56e468c6e1b951c0ecb45d77da82a2bff61", kill_on_drop: false }` [INFO] [stdout] 7397139df80625931341b16b00a7d56e468c6e1b951c0ecb45d77da82a2bff61 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2c13dd979b559a582f70b8d85ab9334d3bfd5773e597122756917693321c99ba [INFO] running `Command { std: "docker" "start" "-a" "2c13dd979b559a582f70b8d85ab9334d3bfd5773e597122756917693321c99ba", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.29 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.76 [INFO] [stderr] Compiling libc v0.2.101 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling futures-core v0.3.17 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling serde_derive v1.0.130 [INFO] [stderr] Compiling proc-macro-nested v0.1.7 [INFO] [stderr] Checking pin-project-lite v0.2.7 [INFO] [stderr] Compiling futures-channel v0.3.17 [INFO] [stderr] Compiling futures-task v0.3.17 [INFO] [stderr] Checking smallvec v1.7.0 [INFO] [stderr] Compiling serde v1.0.130 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling parking_lot_core v0.8.5 [INFO] [stderr] Checking futures-sink v0.3.17 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Checking lock_api v0.4.6 [INFO] [stderr] Checking instant v0.1.10 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Checking slab v0.4.4 [INFO] [stderr] Compiling parking_lot_core v0.9.1 [INFO] [stderr] Checking futures-io v0.3.17 [INFO] [stderr] Checking once_cell v1.8.0 [INFO] [stderr] Compiling serde_json v1.0.67 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking tracing-core v0.1.19 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Compiling futures-macro v0.3.17 [INFO] [stderr] Compiling futures-util v0.3.17 [INFO] [stderr] Compiling tokio v1.11.0 [INFO] [stderr] Compiling ahash v0.7.4 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking parking_lot v0.12.0 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking hashbrown v0.12.0 [INFO] [stderr] Compiling thiserror-impl v1.0.29 [INFO] [stderr] Compiling tracing-attributes v0.1.15 [INFO] [stderr] Compiling goods-proc v0.2.0 [INFO] [stderr] Checking thiserror v1.0.29 [INFO] [stderr] Checking tracing v0.1.26 [INFO] [stderr] Checking futures-executor v0.3.17 [INFO] [stderr] Checking futures v0.3.17 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking goods v0.12.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/loader.rs:672:51 [INFO] [stdout] | [INFO] [stdout] 672 | let path_shard = &self.path_cache[(key_hash as usize % shards_len)]; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 672 - let path_shard = &self.path_cache[(key_hash as usize % shards_len)]; [INFO] [stdout] 672 + let path_shard = &self.path_cache[key_hash as usize % shards_len]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/loader.rs:717:57 [INFO] [stdout] | [INFO] [stdout] 717 | ... let shard = &self.cache[(key_hash as usize % shards_len)]; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 717 - let shard = &self.cache[(key_hash as usize % shards_len)]; [INFO] [stdout] 717 + let shard = &self.cache[key_hash as usize % shards_len]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/loader.rs:778:41 [INFO] [stdout] | [INFO] [stdout] 778 | let shard = &self.cache[(key_hash as usize % shards_len)]; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 778 - let shard = &self.cache[(key_hash as usize % shards_len)]; [INFO] [stdout] 778 + let shard = &self.cache[key_hash as usize % shards_len]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/loader.rs:672:51 [INFO] [stdout] | [INFO] [stdout] 672 | let path_shard = &self.path_cache[(key_hash as usize % shards_len)]; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 672 - let path_shard = &self.path_cache[(key_hash as usize % shards_len)]; [INFO] [stdout] 672 + let path_shard = &self.path_cache[key_hash as usize % shards_len]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/loader.rs:717:57 [INFO] [stdout] | [INFO] [stdout] 717 | ... let shard = &self.cache[(key_hash as usize % shards_len)]; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 717 - let shard = &self.cache[(key_hash as usize % shards_len)]; [INFO] [stdout] 717 + let shard = &self.cache[key_hash as usize % shards_len]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/loader.rs:778:41 [INFO] [stdout] | [INFO] [stdout] 778 | let shard = &self.cache[(key_hash as usize % shards_len)]; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 778 - let shard = &self.cache[(key_hash as usize % shards_len)]; [INFO] [stdout] 778 + let shard = &self.cache[key_hash as usize % shards_len]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `update` is never used [INFO] [stdout] --> src/loader.rs:114:8 [INFO] [stdout] | [INFO] [stdout] 111 | trait AnySource: Send + Sync + 'static { [INFO] [stdout] | --------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 114 | fn update(&self, id: AssetId, version: u64) -> BoxFuture, Error>>; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/asset.rs:80:15 [INFO] [stdout] | [INFO] [stdout] 79 | fn decode(bytes: Box<[u8]>, _: &Loader) -> Ready> { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | ready(::decode(bytes)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/field.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 74 | fn build(mut result: AssetResult, builder: &mut B) -> Result { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | result.build(builder).map(A::clone) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/field.rs:158:9 [INFO] [stdout] | [INFO] [stdout] 157 | fn decode(info: Vec, loader: &Loader) -> Self::Fut { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | / info.into_iter() [INFO] [stdout] 159 | | .map(|info| A::decode(info, loader)) [INFO] [stdout] | |________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/field.rs:169:9 [INFO] [stdout] | [INFO] [stdout] 168 | fn build(decoded: Vec, builder: &mut B) -> Result, A::BuildError> { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | / decoded [INFO] [stdout] 170 | | .into_iter() [INFO] [stdout] 171 | | .map(|decoded| A::build(decoded, builder)) [INFO] [stdout] | |______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loader.rs:89:15 [INFO] [stdout] | [INFO] [stdout] 85 | fn new(error: E) -> Self [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | Error(Arc::new(error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loader.rs:128:18 [INFO] [stdout] | [INFO] [stdout] 127 | let fut = Source::load(self, id); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | Box::pin(fut.map_err(Error::new)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loader.rs:133:18 [INFO] [stdout] | [INFO] [stdout] 132 | let fut = Source::update(self, id, version); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | Box::pin(fut.map_err(Error::new)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loader.rs:222:20 [INFO] [stdout] | [INFO] [stdout] 207 | pub fn build(self) -> Loader { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 208 | let random_state = RandomState::new(); [INFO] [stdout] 209 | let sources: Arc<[_]> = self.sources.into(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 210 | [INFO] [stdout] 211 | let shards: Vec<_> = (0..self.num_shards) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 215 | let path_shards: Vec<_> = (0..self.num_shards) [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 222 | cache: shards.into(), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loader.rs:223:25 [INFO] [stdout] | [INFO] [stdout] 207 | pub fn build(self) -> Loader { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 208 | let random_state = RandomState::new(); [INFO] [stdout] 209 | let sources: Arc<[_]> = self.sources.into(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 210 | [INFO] [stdout] 211 | let shards: Vec<_> = (0..self.num_shards) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 215 | let path_shards: Vec<_> = (0..self.num_shards) [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 223 | path_cache: path_shards.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loader.rs:212:31 [INFO] [stdout] | [INFO] [stdout] 212 | .map(|_| Arc::new(Mutex::new(HashMap::new()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loader.rs:216:31 [INFO] [stdout] | [INFO] [stdout] 216 | .map(|_| Arc::new(Mutex::new(HashMap::new()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loader.rs:625:35 [INFO] [stdout] | [INFO] [stdout] 625 | match me.get_impl(|| Some(ctx.waker().clone())) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `update` is never used [INFO] [stdout] --> src/loader.rs:114:8 [INFO] [stdout] | [INFO] [stdout] 111 | trait AnySource: Send + Sync + 'static { [INFO] [stdout] | --------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 114 | fn update(&self, id: AssetId, version: u64) -> BoxFuture, Error>>; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/asset.rs:80:15 [INFO] [stdout] | [INFO] [stdout] 79 | fn decode(bytes: Box<[u8]>, _: &Loader) -> Ready> { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | ready(::decode(bytes)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/field.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 74 | fn build(mut result: AssetResult, builder: &mut B) -> Result { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | result.build(builder).map(A::clone) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/field.rs:158:9 [INFO] [stdout] | [INFO] [stdout] 157 | fn decode(info: Vec, loader: &Loader) -> Self::Fut { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | / info.into_iter() [INFO] [stdout] 159 | | .map(|info| A::decode(info, loader)) [INFO] [stdout] | |________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/field.rs:169:9 [INFO] [stdout] | [INFO] [stdout] 168 | fn build(decoded: Vec, builder: &mut B) -> Result, A::BuildError> { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | / decoded [INFO] [stdout] 170 | | .into_iter() [INFO] [stdout] 171 | | .map(|decoded| A::build(decoded, builder)) [INFO] [stdout] | |______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loader.rs:89:15 [INFO] [stdout] | [INFO] [stdout] 85 | fn new(error: E) -> Self [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | Error(Arc::new(error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loader.rs:128:18 [INFO] [stdout] | [INFO] [stdout] 127 | let fut = Source::load(self, id); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | Box::pin(fut.map_err(Error::new)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loader.rs:133:18 [INFO] [stdout] | [INFO] [stdout] 132 | let fut = Source::update(self, id, version); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | Box::pin(fut.map_err(Error::new)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loader.rs:222:20 [INFO] [stdout] | [INFO] [stdout] 207 | pub fn build(self) -> Loader { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 208 | let random_state = RandomState::new(); [INFO] [stdout] 209 | let sources: Arc<[_]> = self.sources.into(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 210 | [INFO] [stdout] 211 | let shards: Vec<_> = (0..self.num_shards) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 215 | let path_shards: Vec<_> = (0..self.num_shards) [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 222 | cache: shards.into(), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loader.rs:223:25 [INFO] [stdout] | [INFO] [stdout] 207 | pub fn build(self) -> Loader { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 208 | let random_state = RandomState::new(); [INFO] [stdout] 209 | let sources: Arc<[_]> = self.sources.into(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 210 | [INFO] [stdout] 211 | let shards: Vec<_> = (0..self.num_shards) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 215 | let path_shards: Vec<_> = (0..self.num_shards) [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 223 | path_cache: path_shards.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loader.rs:212:31 [INFO] [stdout] | [INFO] [stdout] 212 | .map(|_| Arc::new(Mutex::new(HashMap::new()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loader.rs:216:31 [INFO] [stdout] | [INFO] [stdout] 216 | .map(|_| Arc::new(Mutex::new(HashMap::new()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loader.rs:625:35 [INFO] [stdout] | [INFO] [stdout] 625 | match me.get_impl(|| Some(ctx.waker().clone())) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `goods` (lib) due to 13 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `goods` (lib test) due to 13 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "2c13dd979b559a582f70b8d85ab9334d3bfd5773e597122756917693321c99ba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2c13dd979b559a582f70b8d85ab9334d3bfd5773e597122756917693321c99ba", kill_on_drop: false }` [INFO] [stdout] 2c13dd979b559a582f70b8d85ab9334d3bfd5773e597122756917693321c99ba