[INFO] fetching crate golrs 0.2.0... [INFO] checking golrs-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate golrs 0.2.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate golrs 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate golrs 0.2.0 [INFO] finished tweaking crates.io crate golrs 0.2.0 [INFO] tweaked toml for crates.io crate golrs 0.2.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate golrs 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6d13798b24e1c899c4ca1dec431cbbcd647a602645fa58be5b0f67971773cad4 [INFO] running `Command { std: "docker" "start" "-a" "6d13798b24e1c899c4ca1dec431cbbcd647a602645fa58be5b0f67971773cad4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6d13798b24e1c899c4ca1dec431cbbcd647a602645fa58be5b0f67971773cad4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6d13798b24e1c899c4ca1dec431cbbcd647a602645fa58be5b0f67971773cad4", kill_on_drop: false }` [INFO] [stdout] 6d13798b24e1c899c4ca1dec431cbbcd647a602645fa58be5b0f67971773cad4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f80d7b088809921968bc2cc657472c210a90ef0e4b3cb697eb9dab4acd9547c3 [INFO] running `Command { std: "docker" "start" "-a" "f80d7b088809921968bc2cc657472c210a90ef0e4b3cb697eb9dab4acd9547c3", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.132 [INFO] [stderr] Checking numtoa v0.1.0 [INFO] [stderr] Checking metrohash v1.0.6 [INFO] [stderr] Checking termion v1.5.6 [INFO] [stderr] Checking golrs v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `receiver` [INFO] [stdout] --> src/view.rs:112:17 [INFO] [stdout] | [INFO] [stdout] 112 | fn view_loop(receiver: mpsc::Receiver>, handle: SimHandle) [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_receiver` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `sender` is never read [INFO] [stdout] --> src/view.rs:21:2 [INFO] [stdout] | [INFO] [stdout] 16 | pub struct View [INFO] [stdout] | ---- field in this struct [INFO] [stdout] ... [INFO] [stdout] 21 | sender: mpsc::Sender>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ViewRemote` is never constructed [INFO] [stdout] --> src/view.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 41 | pub struct ViewRemote [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Refresh` and `UpdateWorld` are never constructed [INFO] [stdout] --> src/view.rs:52:2 [INFO] [stdout] | [INFO] [stdout] 48 | pub enum ViewCmd [INFO] [stdout] | ------- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 52 | Refresh, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 53 | UpdateWorld(W), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `refresh`, and `set_world` are never used [INFO] [stdout] --> src/view.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 56 | / impl ViewRemote [INFO] [stdout] 57 | | where [INFO] [stdout] 58 | | W: World, [INFO] [stdout] | |_____________- associated items in this implementation [INFO] [stdout] 59 | { [INFO] [stdout] 60 | fn new(sender: mpsc::Sender>) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 63 | pub fn refresh(&self) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 67 | pub fn set_world(&self, world: W) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sim.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 85 | let (sender, receiver) = mpsc::channel(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | self.sender.send(SimCmd::Snapshot(sender)).unwrap(); [INFO] [stdout] 87 | receiver.recv().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `golrs` (bin "golrs" test) due to 2 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `receiver` [INFO] [stdout] --> src/view.rs:112:17 [INFO] [stdout] | [INFO] [stdout] 112 | fn view_loop(receiver: mpsc::Receiver>, handle: SimHandle) [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_receiver` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `sender` is never read [INFO] [stdout] --> src/view.rs:21:2 [INFO] [stdout] | [INFO] [stdout] 16 | pub struct View [INFO] [stdout] | ---- field in this struct [INFO] [stdout] ... [INFO] [stdout] 21 | sender: mpsc::Sender>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ViewRemote` is never constructed [INFO] [stdout] --> src/view.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 41 | pub struct ViewRemote [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Refresh` and `UpdateWorld` are never constructed [INFO] [stdout] --> src/view.rs:52:2 [INFO] [stdout] | [INFO] [stdout] 48 | pub enum ViewCmd [INFO] [stdout] | ------- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 52 | Refresh, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 53 | UpdateWorld(W), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `refresh`, and `set_world` are never used [INFO] [stdout] --> src/view.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 56 | / impl ViewRemote [INFO] [stdout] 57 | | where [INFO] [stdout] 58 | | W: World, [INFO] [stdout] | |_____________- associated items in this implementation [INFO] [stdout] 59 | { [INFO] [stdout] 60 | fn new(sender: mpsc::Sender>) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 63 | pub fn refresh(&self) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 67 | pub fn set_world(&self, world: W) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sim.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 85 | let (sender, receiver) = mpsc::channel(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | self.sender.send(SimCmd::Snapshot(sender)).unwrap(); [INFO] [stdout] 87 | receiver.recv().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `golrs` (bin "golrs") due to 2 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "f80d7b088809921968bc2cc657472c210a90ef0e4b3cb697eb9dab4acd9547c3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f80d7b088809921968bc2cc657472c210a90ef0e4b3cb697eb9dab4acd9547c3", kill_on_drop: false }` [INFO] [stdout] f80d7b088809921968bc2cc657472c210a90ef0e4b3cb697eb9dab4acd9547c3