[INFO] fetching crate goldfish 0.1.0... [INFO] checking goldfish-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate goldfish 0.1.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate goldfish 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate goldfish 0.1.0 [INFO] finished tweaking crates.io crate goldfish 0.1.0 [INFO] tweaked toml for crates.io crate goldfish 0.1.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate goldfish 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] db96e3c04bf4394dae48a957ac35c37602b25d51f415c0b1e92c9fb682cd9acb [INFO] running `Command { std: "docker" "start" "-a" "db96e3c04bf4394dae48a957ac35c37602b25d51f415c0b1e92c9fb682cd9acb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "db96e3c04bf4394dae48a957ac35c37602b25d51f415c0b1e92c9fb682cd9acb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "db96e3c04bf4394dae48a957ac35c37602b25d51f415c0b1e92c9fb682cd9acb", kill_on_drop: false }` [INFO] [stdout] db96e3c04bf4394dae48a957ac35c37602b25d51f415c0b1e92c9fb682cd9acb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a336f0a15b30c89664f4b7a02d5629508f8d81240f060e2633231a25ba115e5b [INFO] running `Command { std: "docker" "start" "-a" "a336f0a15b30c89664f4b7a02d5629508f8d81240f060e2633231a25ba115e5b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.10 [INFO] [stderr] Compiling version_check v0.9.1 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.18 [INFO] [stderr] Compiling libc v0.2.69 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Compiling unicode-segmentation v1.6.0 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling anyhow v1.0.28 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.2 [INFO] [stderr] Compiling proc-macro-error v1.0.2 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Compiling indexmap v1.3.2 [INFO] [stderr] Compiling quote v1.0.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking dirs-sys v0.3.4 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking dirs v2.0.2 [INFO] [stderr] Compiling syn-mid v0.5.0 [INFO] [stderr] Compiling structopt-derive v0.4.7 [INFO] [stderr] Checking structopt v0.3.14 [INFO] [stderr] Checking goldfish v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | / /// Validate and transform `entry` as `type` [INFO] [stdout] 57 | | #[structopt(short, long)] [INFO] [stdout] 58 | | r#type: Option, [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | / (|| -> io::Result<()> { [INFO] [stdout] 19 | | $($statement)* [INFO] [stdout] 20 | | Ok(()) [INFO] [stdout] 21 | | })().with_context(|| $context) [INFO] [stdout] | |____________^ [INFO] [stdout] ... [INFO] [stdout] 51 | pub fn append>(&mut self, entry: E) -> anyhow::Result<()> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | / try_with_context! { [INFO] [stdout] 53 | | CONTEXT: anyhow!("Could not append to log file: `{}`", self.path.display()); [INFO] [stdout] 54 | | let entry = entry.as_ref(); [INFO] [stdout] 55 | | self.file.write_all(entry)?; [INFO] [stdout] 56 | | self.file.write_u16::(entry.len() as u16)?; [INFO] [stdout] 57 | | } [INFO] [stdout] | |_________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try_with_context` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn delete(self) -> anyhow::Result<()> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | fs::remove_file(&self.path) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `goldfish` (bin "goldfish" test) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | / /// Validate and transform `entry` as `type` [INFO] [stdout] 57 | | #[structopt(short, long)] [INFO] [stdout] 58 | | r#type: Option, [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | / (|| -> io::Result<()> { [INFO] [stdout] 19 | | $($statement)* [INFO] [stdout] 20 | | Ok(()) [INFO] [stdout] 21 | | })().with_context(|| $context) [INFO] [stdout] | |____________^ [INFO] [stdout] ... [INFO] [stdout] 51 | pub fn append>(&mut self, entry: E) -> anyhow::Result<()> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | / try_with_context! { [INFO] [stdout] 53 | | CONTEXT: anyhow!("Could not append to log file: `{}`", self.path.display()); [INFO] [stdout] 54 | | let entry = entry.as_ref(); [INFO] [stdout] 55 | | self.file.write_all(entry)?; [INFO] [stdout] 56 | | self.file.write_u16::(entry.len() as u16)?; [INFO] [stdout] 57 | | } [INFO] [stdout] | |_________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try_with_context` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn delete(self) -> anyhow::Result<()> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | fs::remove_file(&self.path) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `goldfish` (bin "goldfish") due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "a336f0a15b30c89664f4b7a02d5629508f8d81240f060e2633231a25ba115e5b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a336f0a15b30c89664f4b7a02d5629508f8d81240f060e2633231a25ba115e5b", kill_on_drop: false }` [INFO] [stdout] a336f0a15b30c89664f4b7a02d5629508f8d81240f060e2633231a25ba115e5b