[INFO] fetching crate gol 0.1.14... [INFO] checking gol-0.1.14 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate gol 0.1.14 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate gol 0.1.14 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gol 0.1.14 [INFO] finished tweaking crates.io crate gol 0.1.14 [INFO] tweaked toml for crates.io crate gol 0.1.14 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate gol 0.1.14 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ba3f5cbcc47a317fbf5926380560b87b76a13335ca7f7f4b23060b960791671c [INFO] running `Command { std: "docker" "start" "-a" "ba3f5cbcc47a317fbf5926380560b87b76a13335ca7f7f4b23060b960791671c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ba3f5cbcc47a317fbf5926380560b87b76a13335ca7f7f4b23060b960791671c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ba3f5cbcc47a317fbf5926380560b87b76a13335ca7f7f4b23060b960791671c", kill_on_drop: false }` [INFO] [stdout] ba3f5cbcc47a317fbf5926380560b87b76a13335ca7f7f4b23060b960791671c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c4fb7d86d538c782b1e86b6e6a9d83d8754dbff1efedb55117e8711eeb5cf28c [INFO] running `Command { std: "docker" "start" "-a" "c4fb7d86d538c782b1e86b6e6a9d83d8754dbff1efedb55117e8711eeb5cf28c", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.150 [INFO] [stderr] Compiling xml-rs v0.8.19 [INFO] [stderr] Compiling khronos_api v3.1.0 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling log v0.4.20 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking libloading v0.6.7 [INFO] [stderr] Compiling nix v0.14.1 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking dlib v0.4.2 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking wayland-sys v0.21.13 [INFO] [stderr] Checking stb_truetype v0.3.1 [INFO] [stderr] Compiling x11-dl v2.21.0 [INFO] [stderr] Compiling parking_lot_core v0.6.3 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Compiling wayland-scanner v0.21.13 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking downcast-rs v1.2.0 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking smallvec v0.6.14 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Checking cty v0.2.2 [INFO] [stderr] Checking xdg v2.5.2 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Checking ordered-float v1.1.1 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking line_drawing v0.7.0 [INFO] [stderr] Compiling glutin_glx_sys v0.1.8 [INFO] [stderr] Compiling glutin_egl_sys v0.1.6 [INFO] [stderr] Checking rusttype v0.8.3 [INFO] [stderr] Compiling gfx_gl v0.6.1 [INFO] [stderr] Checking rusttype v0.7.9 [INFO] [stderr] Checking andrew v0.2.1 [INFO] [stderr] Checking raw-window-handle v0.4.3 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Checking draw_state v0.8.0 [INFO] [stderr] Checking raw-window-handle v0.3.4 [INFO] [stderr] Checking gfx_core v0.9.2 [INFO] [stderr] Compiling wayland-client v0.21.13 [INFO] [stderr] Compiling wayland-protocols v0.21.13 [INFO] [stderr] Compiling libloading v0.5.2 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking gfx v0.18.3 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Checking wayland-commons v0.21.13 [INFO] [stderr] Checking gfx_device_gl v0.16.2 [INFO] [stderr] Checking smithay-client-toolkit v0.4.6 [INFO] [stderr] Checking winit v0.19.5 [INFO] [stderr] Checking glutin v0.20.1 [INFO] [stderr] Checking gfx_window_glutin v0.30.0 [INFO] [stderr] Checking gol v0.1.14 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rendering/mod.rs:164:12 [INFO] [stdout] | [INFO] [stdout] 127 | let events_loop = glutin::EventsLoop::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | let window_size = LogicalSize::new(window_width.into(), window_height.into()); [INFO] [stdout] 129 | let builder = glutin::WindowBuilder::new() [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | let (window, device, mut factory, main_color, _) = [INFO] [stdout] | ------ ------ ------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | gfx_window_glutin::init::(builder, context, &events_loop)?; [INFO] [stdout] 135 | let encoder = factory.create_command_buffer().into(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | let upload = factory.create_upload_buffer(area as usize)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | let insts = { [INFO] [stdout] 148 | let mut writer = factory.write_mapping(&upload)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | let instances = factory.create_buffer( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | let (quad_vertices, mut slice) = [INFO] [stdout] | ------------- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 164 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 165 | | grid: Arc::new(Mutex::new(grid)), [INFO] [stdout] 166 | | updates_per_second, [INFO] [stdout] 167 | | window, [INFO] [stdout] ... | [INFO] [stdout] 191 | | uploading: true, [INFO] [stdout] 192 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rendering/mod.rs:164:12 [INFO] [stdout] | [INFO] [stdout] 127 | let events_loop = glutin::EventsLoop::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | let window_size = LogicalSize::new(window_width.into(), window_height.into()); [INFO] [stdout] 129 | let builder = glutin::WindowBuilder::new() [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | let (window, device, mut factory, main_color, _) = [INFO] [stdout] | ------ ------ ------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | gfx_window_glutin::init::(builder, context, &events_loop)?; [INFO] [stdout] 135 | let encoder = factory.create_command_buffer().into(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | let upload = factory.create_upload_buffer(area as usize)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | let insts = { [INFO] [stdout] 148 | let mut writer = factory.write_mapping(&upload)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | let instances = factory.create_buffer( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | let (quad_vertices, mut slice) = [INFO] [stdout] | ------------- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 164 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 165 | | grid: Arc::new(Mutex::new(grid)), [INFO] [stdout] 166 | | updates_per_second, [INFO] [stdout] 167 | | window, [INFO] [stdout] ... | [INFO] [stdout] 191 | | uploading: true, [INFO] [stdout] 192 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gol` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `gol` (lib test) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "c4fb7d86d538c782b1e86b6e6a9d83d8754dbff1efedb55117e8711eeb5cf28c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c4fb7d86d538c782b1e86b6e6a9d83d8754dbff1efedb55117e8711eeb5cf28c", kill_on_drop: false }` [INFO] [stdout] c4fb7d86d538c782b1e86b6e6a9d83d8754dbff1efedb55117e8711eeb5cf28c