[INFO] fetching crate go-parser 0.1.5... [INFO] checking go-parser-0.1.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate go-parser 0.1.5 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate go-parser 0.1.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate go-parser 0.1.5 [INFO] finished tweaking crates.io crate go-parser 0.1.5 [INFO] tweaked toml for crates.io crate go-parser 0.1.5 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 21 packages to latest compatible versions [INFO] [stderr] Adding borsh v0.10.3 (latest: v1.5.1) [INFO] [stderr] Adding borsh-derive v0.10.3 (latest: v1.5.1) [INFO] [stderr] Adding hashbrown v0.13.2 (latest: v0.14.5) [INFO] [stderr] Adding proc-macro-crate v0.1.5 (latest: v3.2.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding toml v0.5.11 (latest: v0.8.19) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d996c33679d2e24045e9969aaaa8c6a58526129cb8173b9ad4ae2a67e7cb1543 [INFO] running `Command { std: "docker" "start" "-a" "d996c33679d2e24045e9969aaaa8c6a58526129cb8173b9ad4ae2a67e7cb1543", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d996c33679d2e24045e9969aaaa8c6a58526129cb8173b9ad4ae2a67e7cb1543", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d996c33679d2e24045e9969aaaa8c6a58526129cb8173b9ad4ae2a67e7cb1543", kill_on_drop: false }` [INFO] [stdout] d996c33679d2e24045e9969aaaa8c6a58526129cb8173b9ad4ae2a67e7cb1543 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c9f186ff253328e6125f8f95f3d2705c7238f50915e3ce6af0999ad541aeed41 [INFO] running `Command { std: "docker" "start" "-a" "c9f186ff253328e6125f8f95f3d2705c7238f50915e3ce6af0999ad541aeed41", kill_on_drop: false }` [INFO] [stderr] Checking go-parser v0.1.5 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:642:21 [INFO] [stdout] | [INFO] [stdout] 627 | let len = match self.token { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 630 | let ell = Expr::new_ellipsis(self.pos, None); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 639 | let elt = self.parse_type(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 642 | Expr::Array(Rc::new(ArrayType { [INFO] [stdout] | _____________________^ [INFO] [stdout] 643 | | l_brack: lpos, [INFO] [stdout] 644 | | len: len, [INFO] [stdout] 645 | | elt: elt, [INFO] [stdout] 646 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:768:20 [INFO] [stdout] | [INFO] [stdout] 765 | let base = self.parse_type(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 768 | Expr::Star(Rc::new(StarExpr { [INFO] [stdout] | ____________________^ [INFO] [stdout] 769 | | star: star, [INFO] [stdout] 770 | | expr: base, [INFO] [stdout] 771 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:1210:24 [INFO] [stdout] | [INFO] [stdout] 1206 | fn parse_selector(&mut self, x: Expr) -> Expr { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1210 | Expr::Selector(Rc::new(SelectorExpr { expr: x, sel: sel })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:1227:26 [INFO] [stdout] | [INFO] [stdout] 1213 | fn parse_type_assertion(&mut self, x: Expr) -> Expr { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1217 | let typ = if self.token == Token::TYPE { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1227 | Expr::TypeAssert(Rc::new(TypeAssertExpr { [INFO] [stdout] | __________________________^ [INFO] [stdout] 1228 | | expr: x, [INFO] [stdout] 1229 | | l_paren: lparen, [INFO] [stdout] 1230 | | typ: typ, [INFO] [stdout] 1231 | | r_paren: rparen, [INFO] [stdout] 1232 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:1323:20 [INFO] [stdout] | [INFO] [stdout] 1300 | fn parse_call_or_conversion(&mut self, func: Expr) -> Expr { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1305 | let mut list = vec![]; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1323 | Expr::Call(Rc::new(CallExpr { [INFO] [stdout] | ____________________^ [INFO] [stdout] 1324 | | func: func, [INFO] [stdout] 1325 | | l_paren: lparen, [INFO] [stdout] 1326 | | args: list, [INFO] [stdout] 1327 | | ellipsis: ellipsis, [INFO] [stdout] 1328 | | r_paren: rparen, [INFO] [stdout] 1329 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:1425:28 [INFO] [stdout] | [INFO] [stdout] 1411 | fn parse_literal_value(&mut self, typ: Option) -> Expr { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1416 | let elts = if self.token != Token::RBRACE { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1425 | Expr::CompositeLit(Rc::new(CompositeLit { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 1426 | | typ: typ, [INFO] [stdout] 1427 | | l_brace: lbrace, [INFO] [stdout] 1428 | | elts: elts, [INFO] [stdout] 1429 | | r_brace: rbrace, [INFO] [stdout] 1430 | | incomplete: false, [INFO] [stdout] 1431 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:1926:22 [INFO] [stdout] | [INFO] [stdout] 1920 | let x = match self.token { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1926 | Stmt::Return(Rc::new(ReturnStmt { [INFO] [stdout] | ______________________^ [INFO] [stdout] 1927 | | ret: pos, [INFO] [stdout] 1928 | | results: x, [INFO] [stdout] 1929 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:1947:22 [INFO] [stdout] | [INFO] [stdout] 1932 | fn parse_branch_stmt(&mut self, token: Token) -> Stmt { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1947 | Stmt::Branch(Rc::new(BranchStmt { [INFO] [stdout] | ______________________^ [INFO] [stdout] 1948 | | token_pos: pos, [INFO] [stdout] 1949 | | token: token, [INFO] [stdout] 1950 | | label: label, [INFO] [stdout] 1951 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:2061:18 [INFO] [stdout] | [INFO] [stdout] 2038 | let (init, cond) = self.parse_if_header(); [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2039 | let body = self.parse_block_stmt(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2040 | let els = if self.token == Token::ELSE { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2045 | let block = self.parse_block_stmt(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2061 | Stmt::If(Rc::new(IfStmt { [INFO] [stdout] | __________________^ [INFO] [stdout] 2062 | | if_pos: pos, [INFO] [stdout] 2063 | | init: init, [INFO] [stdout] 2064 | | cond: cond, [INFO] [stdout] 2065 | | body: Rc::new(body), [INFO] [stdout] 2066 | | els: els, [INFO] [stdout] 2067 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:2301:22 [INFO] [stdout] | [INFO] [stdout] 2288 | let mut list = vec![]; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2294 | let body = BlockStmt { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2301 | Stmt::Select(Rc::new(SelectStmt { [INFO] [stdout] | ______________________^ [INFO] [stdout] 2302 | | select: pos, [INFO] [stdout] 2303 | | body: Rc::new(body), [INFO] [stdout] 2304 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:2802:14 [INFO] [stdout] | [INFO] [stdout] 2770 | let mut decls = vec![]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2802 | Some(File { [INFO] [stdout] | ______________^ [INFO] [stdout] 2803 | | package: pos, [INFO] [stdout] 2804 | | name: ident, [INFO] [stdout] 2805 | | decls: decls, [INFO] [stdout] ... | [INFO] [stdout] 2808 | | unresolved: self.unresolved.clone(), [INFO] [stdout] 2809 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:642:21 [INFO] [stdout] | [INFO] [stdout] 627 | let len = match self.token { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 630 | let ell = Expr::new_ellipsis(self.pos, None); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 639 | let elt = self.parse_type(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 642 | Expr::Array(Rc::new(ArrayType { [INFO] [stdout] | _____________________^ [INFO] [stdout] 643 | | l_brack: lpos, [INFO] [stdout] 644 | | len: len, [INFO] [stdout] 645 | | elt: elt, [INFO] [stdout] 646 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:768:20 [INFO] [stdout] | [INFO] [stdout] 765 | let base = self.parse_type(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 768 | Expr::Star(Rc::new(StarExpr { [INFO] [stdout] | ____________________^ [INFO] [stdout] 769 | | star: star, [INFO] [stdout] 770 | | expr: base, [INFO] [stdout] 771 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:1210:24 [INFO] [stdout] | [INFO] [stdout] 1206 | fn parse_selector(&mut self, x: Expr) -> Expr { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1210 | Expr::Selector(Rc::new(SelectorExpr { expr: x, sel: sel })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:1227:26 [INFO] [stdout] | [INFO] [stdout] 1213 | fn parse_type_assertion(&mut self, x: Expr) -> Expr { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1217 | let typ = if self.token == Token::TYPE { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1227 | Expr::TypeAssert(Rc::new(TypeAssertExpr { [INFO] [stdout] | __________________________^ [INFO] [stdout] 1228 | | expr: x, [INFO] [stdout] 1229 | | l_paren: lparen, [INFO] [stdout] 1230 | | typ: typ, [INFO] [stdout] 1231 | | r_paren: rparen, [INFO] [stdout] 1232 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:1323:20 [INFO] [stdout] | [INFO] [stdout] 1300 | fn parse_call_or_conversion(&mut self, func: Expr) -> Expr { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1305 | let mut list = vec![]; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1323 | Expr::Call(Rc::new(CallExpr { [INFO] [stdout] | ____________________^ [INFO] [stdout] 1324 | | func: func, [INFO] [stdout] 1325 | | l_paren: lparen, [INFO] [stdout] 1326 | | args: list, [INFO] [stdout] 1327 | | ellipsis: ellipsis, [INFO] [stdout] 1328 | | r_paren: rparen, [INFO] [stdout] 1329 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:1425:28 [INFO] [stdout] | [INFO] [stdout] 1411 | fn parse_literal_value(&mut self, typ: Option) -> Expr { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1416 | let elts = if self.token != Token::RBRACE { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1425 | Expr::CompositeLit(Rc::new(CompositeLit { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 1426 | | typ: typ, [INFO] [stdout] 1427 | | l_brace: lbrace, [INFO] [stdout] 1428 | | elts: elts, [INFO] [stdout] 1429 | | r_brace: rbrace, [INFO] [stdout] 1430 | | incomplete: false, [INFO] [stdout] 1431 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:1926:22 [INFO] [stdout] | [INFO] [stdout] 1920 | let x = match self.token { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1926 | Stmt::Return(Rc::new(ReturnStmt { [INFO] [stdout] | ______________________^ [INFO] [stdout] 1927 | | ret: pos, [INFO] [stdout] 1928 | | results: x, [INFO] [stdout] 1929 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:1947:22 [INFO] [stdout] | [INFO] [stdout] 1932 | fn parse_branch_stmt(&mut self, token: Token) -> Stmt { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1947 | Stmt::Branch(Rc::new(BranchStmt { [INFO] [stdout] | ______________________^ [INFO] [stdout] 1948 | | token_pos: pos, [INFO] [stdout] 1949 | | token: token, [INFO] [stdout] 1950 | | label: label, [INFO] [stdout] 1951 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:2061:18 [INFO] [stdout] | [INFO] [stdout] 2038 | let (init, cond) = self.parse_if_header(); [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2039 | let body = self.parse_block_stmt(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2040 | let els = if self.token == Token::ELSE { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2045 | let block = self.parse_block_stmt(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2061 | Stmt::If(Rc::new(IfStmt { [INFO] [stdout] | __________________^ [INFO] [stdout] 2062 | | if_pos: pos, [INFO] [stdout] 2063 | | init: init, [INFO] [stdout] 2064 | | cond: cond, [INFO] [stdout] 2065 | | body: Rc::new(body), [INFO] [stdout] 2066 | | els: els, [INFO] [stdout] 2067 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:2301:22 [INFO] [stdout] | [INFO] [stdout] 2288 | let mut list = vec![]; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2294 | let body = BlockStmt { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2301 | Stmt::Select(Rc::new(SelectStmt { [INFO] [stdout] | ______________________^ [INFO] [stdout] 2302 | | select: pos, [INFO] [stdout] 2303 | | body: Rc::new(body), [INFO] [stdout] 2304 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:2802:14 [INFO] [stdout] | [INFO] [stdout] 2770 | let mut decls = vec![]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2802 | Some(File { [INFO] [stdout] | ______________^ [INFO] [stdout] 2803 | | package: pos, [INFO] [stdout] 2804 | | name: ident, [INFO] [stdout] 2805 | | decls: decls, [INFO] [stdout] ... | [INFO] [stdout] 2808 | | unresolved: self.unresolved.clone(), [INFO] [stdout] 2809 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/position.rs:252:30 [INFO] [stdout] | [INFO] [stdout] 252 | return Some(f.borrow()); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `position::File` does not implement `Borrow`, so calling `borrow` on `&position::File` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 252 - return Some(f.borrow()); [INFO] [stdout] 252 + return Some(f); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `position::File`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 67 + #[derive(Clone)] [INFO] [stdout] 68 | pub struct File { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:112:24 [INFO] [stdout] | [INFO] [stdout] 111 | pub fn new_selector(x: Expr, sel: IdentKey) -> Expr { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | Expr::Selector(Rc::new(SelectorExpr { expr: x, sel: sel })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:116:24 [INFO] [stdout] | [INFO] [stdout] 115 | pub fn new_ellipsis(pos: position::Pos, x: Option) -> Expr { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | Expr::Ellipsis(Rc::new(Ellipsis { pos: pos, elt: x })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:120:24 [INFO] [stdout] | [INFO] [stdout] 119 | pub fn new_basic_lit(pos: position::Pos, token: token::Token) -> Expr { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | Expr::BasicLit(Rc::new(BasicLit { [INFO] [stdout] | ________________________^ [INFO] [stdout] 121 | | pos: pos, [INFO] [stdout] 122 | | token: token, [INFO] [stdout] 123 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:127:21 [INFO] [stdout] | [INFO] [stdout] 126 | pub fn new_unary_expr(pos: position::Pos, op: token::Token, expr: Expr) -> Expr { [INFO] [stdout] | ---------------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | Expr::Unary(Rc::new(UnaryExpr { [INFO] [stdout] | _____________________^ [INFO] [stdout] 128 | | op_pos: pos, [INFO] [stdout] 129 | | op: op, [INFO] [stdout] 130 | | expr: expr, [INFO] [stdout] 131 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:282:21 [INFO] [stdout] | [INFO] [stdout] 281 | pub fn box_block(block: BlockStmt) -> Stmt { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 282 | Stmt::Block(Rc::new(block)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/position.rs:252:30 [INFO] [stdout] | [INFO] [stdout] 252 | return Some(f.borrow()); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `position::File` does not implement `Borrow`, so calling `borrow` on `&position::File` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 252 - return Some(f.borrow()); [INFO] [stdout] 252 + return Some(f); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `position::File`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 67 + #[derive(Clone)] [INFO] [stdout] 68 | pub struct File { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:112:24 [INFO] [stdout] | [INFO] [stdout] 111 | pub fn new_selector(x: Expr, sel: IdentKey) -> Expr { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | Expr::Selector(Rc::new(SelectorExpr { expr: x, sel: sel })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:116:24 [INFO] [stdout] | [INFO] [stdout] 115 | pub fn new_ellipsis(pos: position::Pos, x: Option) -> Expr { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | Expr::Ellipsis(Rc::new(Ellipsis { pos: pos, elt: x })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:120:24 [INFO] [stdout] | [INFO] [stdout] 119 | pub fn new_basic_lit(pos: position::Pos, token: token::Token) -> Expr { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | Expr::BasicLit(Rc::new(BasicLit { [INFO] [stdout] | ________________________^ [INFO] [stdout] 121 | | pos: pos, [INFO] [stdout] 122 | | token: token, [INFO] [stdout] 123 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:127:21 [INFO] [stdout] | [INFO] [stdout] 126 | pub fn new_unary_expr(pos: position::Pos, op: token::Token, expr: Expr) -> Expr { [INFO] [stdout] | ---------------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | Expr::Unary(Rc::new(UnaryExpr { [INFO] [stdout] | _____________________^ [INFO] [stdout] 128 | | op_pos: pos, [INFO] [stdout] 129 | | op: op, [INFO] [stdout] 130 | | expr: expr, [INFO] [stdout] 131 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:282:21 [INFO] [stdout] | [INFO] [stdout] 281 | pub fn box_block(block: BlockStmt) -> Stmt { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 282 | Stmt::Block(Rc::new(block)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `go-parser` (lib) due to 17 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `go-parser` (lib test) due to 17 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "c9f186ff253328e6125f8f95f3d2705c7238f50915e3ce6af0999ad541aeed41", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c9f186ff253328e6125f8f95f3d2705c7238f50915e3ce6af0999ad541aeed41", kill_on_drop: false }` [INFO] [stdout] c9f186ff253328e6125f8f95f3d2705c7238f50915e3ce6af0999ad541aeed41