[INFO] fetching crate gmt_dos-actors-clients_interface 1.3.1... [INFO] checking gmt_dos-actors-clients_interface-1.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate gmt_dos-actors-clients_interface 1.3.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate gmt_dos-actors-clients_interface 1.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gmt_dos-actors-clients_interface 1.3.1 [INFO] finished tweaking crates.io crate gmt_dos-actors-clients_interface 1.3.1 [INFO] tweaked toml for crates.io crate gmt_dos-actors-clients_interface 1.3.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 15 packages to latest compatible versions [INFO] [stderr] Adding virtue v0.0.13 (latest: v0.0.17) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d59bea9696317bc8ddd04c0f6c97fa7f581954ed275d7e26c9bc2c125acd5b3c [INFO] running `Command { std: "docker" "start" "-a" "d59bea9696317bc8ddd04c0f6c97fa7f581954ed275d7e26c9bc2c125acd5b3c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d59bea9696317bc8ddd04c0f6c97fa7f581954ed275d7e26c9bc2c125acd5b3c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d59bea9696317bc8ddd04c0f6c97fa7f581954ed275d7e26c9bc2c125acd5b3c", kill_on_drop: false }` [INFO] [stdout] d59bea9696317bc8ddd04c0f6c97fa7f581954ed275d7e26c9bc2c125acd5b3c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7847a64ff12a36176e3f553e5eae8c4a7cd7f5cd86cb38dce9ea26a737beff4d [INFO] running `Command { std: "docker" "start" "-a" "7847a64ff12a36176e3f553e5eae8c4a7cd7f5cd86cb38dce9ea26a737beff4d", kill_on_drop: false }` [INFO] [stderr] Checking paris v1.5.15 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling dos-uid-derive v5.0.0 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking gmt_dos-actors-clients_interface v1.3.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Data` [INFO] [stdout] --> src/select.rs:69:17 [INFO] [stdout] | [INFO] [stdout] 69 | use crate::{Data, UniqueIdentifier, Update, Write}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:47:14 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn new(data: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | Data(Arc::new(data), PhantomData) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:90:14 [INFO] [stdout] | [INFO] [stdout] 89 | fn from(u: Vec) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | Data(Arc::new(u), PhantomData) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/units.rs:43:33 [INFO] [stdout] | [INFO] [stdout] 43 | .map(|data| <$t as UnitsConversion>::conversion(data).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 59 | / converter!( [INFO] [stdout] 60 | | // ( Units : Type , Conversion factor ) [INFO] [stdout] 61 | | ("nanometers" : NM , 1e9), [INFO] [stdout] 62 | | ("micrometers" : MuM , 1e6), [INFO] [stdout] 63 | | ("arcseconds" : Arcsec, (180. * 3600.) / PI), [INFO] [stdout] 64 | | ("milli-arcseconds": Mas , (180. * 3600e3) / PI) [INFO] [stdout] 65 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `converter` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/select.rs:63:14 [INFO] [stdout] | [INFO] [stdout] 58 | let Some(data) = >::write(self) else { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Some(value.into()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gmt_dos-actors-clients_interface` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `data` is never read [INFO] [stdout] --> src/units.rs:119:13 [INFO] [stdout] | [INFO] [stdout] 118 | pub struct Client { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 119 | pub data: Vec, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `data` is never read [INFO] [stdout] --> src/units.rs:130:13 [INFO] [stdout] | [INFO] [stdout] 129 | pub struct ClientAngle { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 130 | pub data: Vec, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:47:14 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn new(data: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | Data(Arc::new(data), PhantomData) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:90:14 [INFO] [stdout] | [INFO] [stdout] 89 | fn from(u: Vec) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | Data(Arc::new(u), PhantomData) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/units.rs:43:33 [INFO] [stdout] | [INFO] [stdout] 43 | .map(|data| <$t as UnitsConversion>::conversion(data).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 59 | / converter!( [INFO] [stdout] 60 | | // ( Units : Type , Conversion factor ) [INFO] [stdout] 61 | | ("nanometers" : NM , 1e9), [INFO] [stdout] 62 | | ("micrometers" : MuM , 1e6), [INFO] [stdout] 63 | | ("arcseconds" : Arcsec, (180. * 3600.) / PI), [INFO] [stdout] 64 | | ("milli-arcseconds": Mas , (180. * 3600e3) / PI) [INFO] [stdout] 65 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `converter` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/select.rs:63:14 [INFO] [stdout] | [INFO] [stdout] 58 | let Some(data) = >::write(self) else { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Some(value.into()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gmt_dos-actors-clients_interface` (lib test) due to 5 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7847a64ff12a36176e3f553e5eae8c4a7cd7f5cd86cb38dce9ea26a737beff4d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7847a64ff12a36176e3f553e5eae8c4a7cd7f5cd86cb38dce9ea26a737beff4d", kill_on_drop: false }` [INFO] [stdout] 7847a64ff12a36176e3f553e5eae8c4a7cd7f5cd86cb38dce9ea26a737beff4d