[INFO] fetching crate glyphs2fontir 0.0.1... [INFO] checking glyphs2fontir-0.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate glyphs2fontir 0.0.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate glyphs2fontir 0.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate glyphs2fontir 0.0.1 [INFO] finished tweaking crates.io crate glyphs2fontir 0.0.1 [INFO] tweaked toml for crates.io crate glyphs2fontir 0.0.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 120 packages to latest compatible versions [INFO] [stderr] Adding env_logger v0.10.2 (latest: v0.11.5) [INFO] [stderr] Adding font-types v0.4.3 (latest: v0.7.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding quick-xml v0.31.0 (latest: v0.36.1) [INFO] [stderr] Adding read-fonts v0.17.0 (latest: v0.21.0) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding write-fonts v0.25.0 (latest: v0.29.0) [INFO] [stderr] Adding yansi v0.5.1 (latest: v1.0.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] db000360aba20c70958ce607b8a6eb92931f458005af9dbdee14c8c4bdb6638b [INFO] running `Command { std: "docker" "start" "-a" "db000360aba20c70958ce607b8a6eb92931f458005af9dbdee14c8c4bdb6638b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "db000360aba20c70958ce607b8a6eb92931f458005af9dbdee14c8c4bdb6638b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "db000360aba20c70958ce607b8a6eb92931f458005af9dbdee14c8c4bdb6638b", kill_on_drop: false }` [INFO] [stdout] db000360aba20c70958ce607b8a6eb92931f458005af9dbdee14c8c4bdb6638b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bdc10462c5d0294e63f0027fc0e9b2b8194cc9b1e452d8a9245b99ac90f60671 [INFO] running `Command { std: "docker" "start" "-a" "bdc10462c5d0294e63f0027fc0e9b2b8194cc9b1e452d8a9245b99ac90f60671", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking writeable v0.5.5 [INFO] [stderr] Checking litemap v0.7.3 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling fontdrasil v0.0.1 [INFO] [stderr] Checking dot2 v1.0.0 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking icu_locid_transform_data v1.5.0 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking arrayref v0.3.8 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking constant_time_eq v0.3.1 [INFO] [stderr] Checking icu_properties_data v1.5.0 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking quick-xml v0.31.0 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking filetime v0.2.25 [INFO] [stderr] Compiling blake3 v1.5.4 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling ascii_plist_derive v0.0.1 [INFO] [stderr] Compiling zerofrom-derive v0.1.4 [INFO] [stderr] Compiling yoke-derive v0.7.4 [INFO] [stderr] Checking zerofrom v0.1.4 [INFO] [stderr] Checking yoke v0.7.4 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking font-types v0.4.3 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking ordered-float v4.2.2 [INFO] [stderr] Checking smol_str v0.2.2 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking kurbo v0.11.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking read-fonts v0.17.0 [INFO] [stderr] Compiling glyphs-reader v0.0.1 [INFO] [stderr] Checking write-fonts v0.25.0 [INFO] [stderr] Checking fontir v0.0.1 [INFO] [stderr] Checking glyphs2fontir v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `axis_indices` is never read [INFO] [stdout] --> src/toir.rs:269:9 [INFO] [stdout] | [INFO] [stdout] 259 | pub struct FontInfo { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 269 | pub axis_indices: HashMap, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FontInfo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source.rs:161:12 [INFO] [stdout] | [INFO] [stdout] 158 | glyph_name: GlyphName, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | font_info: Arc, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | ) -> Result { [INFO] [stdout] 161 | Ok(GlyphIrWork { [INFO] [stdout] | ____________^ [INFO] [stdout] 162 | | glyph_name, [INFO] [stdout] 163 | | font_info, [INFO] [stdout] 164 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source.rs:188:12 [INFO] [stdout] | [INFO] [stdout] 171 | let font_info = FontInfo::try_from(Font::load(&self.glyphs_file).map_err(|e| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | let glyphs = glyph_states(font)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | Ok(Input { [INFO] [stdout] | ____________^ [INFO] [stdout] 189 | | static_metadata, [INFO] [stdout] 190 | | global_metrics, [INFO] [stdout] 191 | | glyphs, [INFO] [stdout] 192 | | features, [INFO] [stdout] 193 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source.rs:201:12 [INFO] [stdout] | [INFO] [stdout] 198 | let font_info = self.cache.as_ref().unwrap().font_info.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | let glyph_names = Arc::new(input.glyphs.keys().cloned().collect()); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 200 | [INFO] [stdout] 201 | Ok(Box::new(StaticMetadataWork { [INFO] [stdout] | ____________^ [INFO] [stdout] 202 | | font_info, [INFO] [stdout] 203 | | glyph_names, [INFO] [stdout] 204 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source.rs:210:12 [INFO] [stdout] | [INFO] [stdout] 209 | let font_info = self.cache.as_ref().unwrap().font_info.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 210 | Ok(Box::new(GlobalMetricWork { font_info })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source.rs:439:50 [INFO] [stdout] | [INFO] [stdout] 439 | category_for_glyph(glyph).map(|cat| (GlyphName::new(name), cat)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source.rs:652:38 [INFO] [stdout] | [INFO] [stdout] 652 | .map(|name| KernGroup::Side1(name.into())) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source.rs:655:46 [INFO] [stdout] | [INFO] [stdout] 655 | .map(|name| KernGroup::Side2(name.into())) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source.rs:730:42 [INFO] [stdout] | [INFO] [stdout] 730 | .map(|group| (group, GlyphName::from(glyph_name.as_str()))) [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source.rs:806:22 [INFO] [stdout] | [INFO] [stdout] 801 | let side1 = kern_participant(glyph_order, groups, SIDE1_PREFIX, side1); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 802 | let side2 = kern_participant(glyph_order, groups, SIDE2_PREFIX, side2); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 803 | let (Some(side1), Some(side2)) = (side1, side2) else { [INFO] [stdout] | ----- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 806 | Some(((side1, side2), pos_adjust)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source.rs:870:54 [INFO] [stdout] | [INFO] [stdout] 870 | .ok_or_else(|| WorkError::NoGlyphForName(self.glyph_name.clone()))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/toir.rs:39:8 [INFO] [stdout] | [INFO] [stdout] 23 | glyph_name: GlyphName, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | let mut components = Vec::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | Ok((contours, components)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/toir.rs:50:15 [INFO] [stdout] | [INFO] [stdout] 42 | fn to_ir_component(glyph_name: GlyphName, component: &Component) -> ir::Component { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | base: component.name.as_str().into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/toir.rs:324:12 [INFO] [stdout] | [INFO] [stdout] 275 | fn try_from(font: Font) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 308 | let variable_axes: HashSet<_> = axes [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 324 | Ok(FontInfo { [INFO] [stdout] | ____________^ [INFO] [stdout] 325 | | font, [INFO] [stdout] 326 | | master_indices, [INFO] [stdout] 327 | | master_positions, [INFO] [stdout] ... | [INFO] [stdout] 330 | | axis_indices, [INFO] [stdout] 331 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `glyphs2fontir` (lib) due to 14 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `axis_indices` is never read [INFO] [stdout] --> src/toir.rs:269:9 [INFO] [stdout] | [INFO] [stdout] 259 | pub struct FontInfo { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 269 | pub axis_indices: HashMap, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FontInfo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source.rs:161:12 [INFO] [stdout] | [INFO] [stdout] 158 | glyph_name: GlyphName, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | font_info: Arc, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | ) -> Result { [INFO] [stdout] 161 | Ok(GlyphIrWork { [INFO] [stdout] | ____________^ [INFO] [stdout] 162 | | glyph_name, [INFO] [stdout] 163 | | font_info, [INFO] [stdout] 164 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source.rs:188:12 [INFO] [stdout] | [INFO] [stdout] 171 | let font_info = FontInfo::try_from(Font::load(&self.glyphs_file).map_err(|e| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | let glyphs = glyph_states(font)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | Ok(Input { [INFO] [stdout] | ____________^ [INFO] [stdout] 189 | | static_metadata, [INFO] [stdout] 190 | | global_metrics, [INFO] [stdout] 191 | | glyphs, [INFO] [stdout] 192 | | features, [INFO] [stdout] 193 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source.rs:201:12 [INFO] [stdout] | [INFO] [stdout] 198 | let font_info = self.cache.as_ref().unwrap().font_info.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | let glyph_names = Arc::new(input.glyphs.keys().cloned().collect()); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 200 | [INFO] [stdout] 201 | Ok(Box::new(StaticMetadataWork { [INFO] [stdout] | ____________^ [INFO] [stdout] 202 | | font_info, [INFO] [stdout] 203 | | glyph_names, [INFO] [stdout] 204 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source.rs:210:12 [INFO] [stdout] | [INFO] [stdout] 209 | let font_info = self.cache.as_ref().unwrap().font_info.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 210 | Ok(Box::new(GlobalMetricWork { font_info })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source.rs:439:50 [INFO] [stdout] | [INFO] [stdout] 439 | category_for_glyph(glyph).map(|cat| (GlyphName::new(name), cat)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source.rs:652:38 [INFO] [stdout] | [INFO] [stdout] 652 | .map(|name| KernGroup::Side1(name.into())) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source.rs:655:46 [INFO] [stdout] | [INFO] [stdout] 655 | .map(|name| KernGroup::Side2(name.into())) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source.rs:730:42 [INFO] [stdout] | [INFO] [stdout] 730 | .map(|group| (group, GlyphName::from(glyph_name.as_str()))) [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source.rs:806:22 [INFO] [stdout] | [INFO] [stdout] 801 | let side1 = kern_participant(glyph_order, groups, SIDE1_PREFIX, side1); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 802 | let side2 = kern_participant(glyph_order, groups, SIDE2_PREFIX, side2); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 803 | let (Some(side1), Some(side2)) = (side1, side2) else { [INFO] [stdout] | ----- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 806 | Some(((side1, side2), pos_adjust)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source.rs:870:54 [INFO] [stdout] | [INFO] [stdout] 870 | .ok_or_else(|| WorkError::NoGlyphForName(self.glyph_name.clone()))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source.rs:1018:9 [INFO] [stdout] | [INFO] [stdout] 1017 | let font = Font::load(&glyphs_file).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1018 | glyph_states(&font).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source.rs:1068:13 [INFO] [stdout] | [INFO] [stdout] 1062 | let mut source = GlyphsIrSource::new(glyphs_file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1063 | let input = source.inputs().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1068 | / Context::new_root( [INFO] [stdout] 1069 | | flags, [INFO] [stdout] 1070 | | Paths::new(Path::new("/nothing/should/write/here")), [INFO] [stdout] 1071 | | input, [INFO] [stdout] 1072 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source.rs:1605:28 [INFO] [stdout] | [INFO] [stdout] 1605 | .filter(|pos| !pos.axis_tags().all(|tag| *tag == Tag::new(b"wght"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/toir.rs:39:8 [INFO] [stdout] | [INFO] [stdout] 23 | glyph_name: GlyphName, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | let mut components = Vec::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | Ok((contours, components)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/toir.rs:50:15 [INFO] [stdout] | [INFO] [stdout] 42 | fn to_ir_component(glyph_name: GlyphName, component: &Component) -> ir::Component { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | base: component.name.as_str().into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/toir.rs:324:12 [INFO] [stdout] | [INFO] [stdout] 275 | fn try_from(font: Font) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 308 | let variable_axes: HashSet<_> = axes [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 324 | Ok(FontInfo { [INFO] [stdout] | ____________^ [INFO] [stdout] 325 | | font, [INFO] [stdout] 326 | | master_indices, [INFO] [stdout] 327 | | master_positions, [INFO] [stdout] ... | [INFO] [stdout] 330 | | axis_indices, [INFO] [stdout] 331 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `glyphs2fontir` (lib test) due to 17 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "bdc10462c5d0294e63f0027fc0e9b2b8194cc9b1e452d8a9245b99ac90f60671", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bdc10462c5d0294e63f0027fc0e9b2b8194cc9b1e452d8a9245b99ac90f60671", kill_on_drop: false }` [INFO] [stdout] bdc10462c5d0294e63f0027fc0e9b2b8194cc9b1e452d8a9245b99ac90f60671