[INFO] fetching crate gluac-rs 0.1.3... [INFO] checking gluac-rs-0.1.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate gluac-rs 0.1.3 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate gluac-rs 0.1.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gluac-rs 0.1.3 [INFO] finished tweaking crates.io crate gluac-rs 0.1.3 [INFO] tweaked toml for crates.io crate gluac-rs 0.1.3 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate gluac-rs 0.1.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 19218203a4abe511a26adf93a72c52019325bf4a1ab5187a03ffbf990b510de0 [INFO] running `Command { std: "docker" "start" "-a" "19218203a4abe511a26adf93a72c52019325bf4a1ab5187a03ffbf990b510de0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "19218203a4abe511a26adf93a72c52019325bf4a1ab5187a03ffbf990b510de0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "19218203a4abe511a26adf93a72c52019325bf4a1ab5187a03ffbf990b510de0", kill_on_drop: false }` [INFO] [stdout] 19218203a4abe511a26adf93a72c52019325bf4a1ab5187a03ffbf990b510de0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c65960d17c013439571193c46082790c4059a9569b105e6c3fbe717659ace7b2 [INFO] running `Command { std: "docker" "start" "-a" "c65960d17c013439571193c46082790c4059a9569b105e6c3fbe717659ace7b2", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.95 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking libloading v0.7.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking gluac-rs v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `tests::*` [INFO] [stdout] --> src/tests/mod.rs:3:9 [INFO] [stdout] | [INFO] [stdout] 3 | pub use tests::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lua.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 134 | let result_srv = Library::new("lua_shared_srv.so"); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | match Library::new("lua_shared.so") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gluac-rs` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lua.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 134 | let result_srv = Library::new("lua_shared_srv.so"); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | match Library::new("lua_shared.so") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/api.rs:67:5 [INFO] [stdout] | [INFO] [stdout] 65 | / std::ffi::CString::new($str) [INFO] [stdout] 66 | | .expect("Tried to create a Lua string from a string that contained a NUL byte (\\0)!") [INFO] [stdout] | |__________________________________________________________________________________________________- this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] 67 | .as_ptr() [INFO] [stdout] | ^^^^^^ this pointer will be invalid [INFO] [stdout] | [INFO] [stdout] ::: src/tests/tests.rs:56:4 [INFO] [stdout] | [INFO] [stdout] 56 | / lua_string!(std::path::PathBuf::from(env!("CARGO_MANIFEST_DIR")) [INFO] [stdout] 57 | | .join("src/tests/hello_world.lua") [INFO] [stdout] 58 | | .to_string_lossy() [INFO] [stdout] 59 | | .to_string()), [INFO] [stdout] | |_____________________________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] = note: `#[warn(temporary_cstring_as_ptr)]` on by default [INFO] [stdout] = note: this warning originates in the macro `lua_string` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gluac-rs` (lib test) due to 2 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "c65960d17c013439571193c46082790c4059a9569b105e6c3fbe717659ace7b2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c65960d17c013439571193c46082790c4059a9569b105e6c3fbe717659ace7b2", kill_on_drop: false }` [INFO] [stdout] c65960d17c013439571193c46082790c4059a9569b105e6c3fbe717659ace7b2