[INFO] fetching crate glrs 0.1.0... [INFO] checking glrs-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate glrs 0.1.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate glrs 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate glrs 0.1.0 [INFO] finished tweaking crates.io crate glrs 0.1.0 [INFO] tweaked toml for crates.io crate glrs 0.1.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate glrs 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0932948e1428f5ebd1d2ceccf97be6e02dcf7caf9fa5f089e9039befc38d2b6e [INFO] running `Command { std: "docker" "start" "-a" "0932948e1428f5ebd1d2ceccf97be6e02dcf7caf9fa5f089e9039befc38d2b6e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0932948e1428f5ebd1d2ceccf97be6e02dcf7caf9fa5f089e9039befc38d2b6e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0932948e1428f5ebd1d2ceccf97be6e02dcf7caf9fa5f089e9039befc38d2b6e", kill_on_drop: false }` [INFO] [stdout] 0932948e1428f5ebd1d2ceccf97be6e02dcf7caf9fa5f089e9039befc38d2b6e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1ba23a2932dbcbba38ed2ef3a1787f8cf8b871c4a6c734f659cc38893b66e0fa [INFO] running `Command { std: "docker" "start" "-a" "1ba23a2932dbcbba38ed2ef3a1787f8cf8b871c4a6c734f659cc38893b66e0fa", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.76 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking glam v0.25.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking quote v1.0.35 [INFO] [stderr] Checking syn v2.0.48 [INFO] [stderr] Checking glsl v7.0.0 [INFO] [stderr] Checking syn-path v2.0.0 [INFO] [stderr] Checking glrs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/convert.rs:101:5 [INFO] [stdout] | [INFO] [stdout] 100 | fn convert_glsl_struct_fields(fields: Vec) -> Vec { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | / fields [INFO] [stdout] 102 | | .into_iter() [INFO] [stdout] 103 | | .flat_map(|field| { [INFO] [stdout] 104 | | let ty = syn::Type::Path(syn::TypePath { [INFO] [stdout] ... | [INFO] [stdout] 131 | | .collect::>() [INFO] [stdout] 132 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/convert.rs:101:5 [INFO] [stdout] | [INFO] [stdout] 100 | fn convert_glsl_struct_fields(fields: Vec) -> Vec { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | / fields [INFO] [stdout] 102 | | .into_iter() [INFO] [stdout] 103 | | .flat_map(|field| { [INFO] [stdout] 104 | | let ty = syn::Type::Path(syn::TypePath { [INFO] [stdout] ... | [INFO] [stdout] 131 | | .collect::>() [INFO] [stdout] 132 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/convert.rs:114:13 [INFO] [stdout] | [INFO] [stdout] 103 | .flat_map(|field| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | let ty = syn::Type::Path(syn::TypePath { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | let arr_dims = field [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | / field [INFO] [stdout] 115 | | .identifiers [INFO] [stdout] 116 | | .into_iter() [INFO] [stdout] 117 | | .map(|ArrayedIdentifier { ident, array_spec }| { [INFO] [stdout] ... | [INFO] [stdout] 129 | | } [INFO] [stdout] 130 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/convert.rs:112:66 [INFO] [stdout] | [INFO] [stdout] 112 | .map(|arr_spec| map_glsl_type_arr(&ty, arr_spec, None)); [INFO] [stdout] | -------- ^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/convert.rs:123:78 [INFO] [stdout] | [INFO] [stdout] 123 | ... .map(|arr_spec| map_glsl_type_arr(&ty, arr_spec, arr_dims.clone())) [INFO] [stdout] | -------- ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/convert.rs:114:13 [INFO] [stdout] | [INFO] [stdout] 103 | .flat_map(|field| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | let ty = syn::Type::Path(syn::TypePath { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | let arr_dims = field [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | / field [INFO] [stdout] 115 | | .identifiers [INFO] [stdout] 116 | | .into_iter() [INFO] [stdout] 117 | | .map(|ArrayedIdentifier { ident, array_spec }| { [INFO] [stdout] ... | [INFO] [stdout] 129 | | } [INFO] [stdout] 130 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/convert.rs:112:66 [INFO] [stdout] | [INFO] [stdout] 112 | .map(|arr_spec| map_glsl_type_arr(&ty, arr_spec, None)); [INFO] [stdout] | -------- ^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/convert.rs:123:78 [INFO] [stdout] | [INFO] [stdout] 123 | ... .map(|arr_spec| map_glsl_type_arr(&ty, arr_spec, arr_dims.clone())) [INFO] [stdout] | -------- ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/convert.rs:124:48 [INFO] [stdout] | [INFO] [stdout] 124 | ... .unwrap_or_else(|| arr_dims.clone().unwrap_or_else(|| quote! { #ty })), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/convert.rs:166:5 [INFO] [stdout] | [INFO] [stdout] 138 | array_specifier: ArraySpecifier, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | inner: Option, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | ) -> proc_macro2::TokenStream { [INFO] [stdout] 141 | let mut res = inner; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | res.expect("Invalid array dimensions mapping").into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/convert.rs:124:48 [INFO] [stdout] | [INFO] [stdout] 124 | ... .unwrap_or_else(|| arr_dims.clone().unwrap_or_else(|| quote! { #ty })), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/convert.rs:166:5 [INFO] [stdout] | [INFO] [stdout] 138 | array_specifier: ArraySpecifier, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | inner: Option, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | ) -> proc_macro2::TokenStream { [INFO] [stdout] 141 | let mut res = inner; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | res.expect("Invalid array dimensions mapping").into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `glrs` (lib test) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `glrs` (lib) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "1ba23a2932dbcbba38ed2ef3a1787f8cf8b871c4a6c734f659cc38893b66e0fa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1ba23a2932dbcbba38ed2ef3a1787f8cf8b871c4a6c734f659cc38893b66e0fa", kill_on_drop: false }` [INFO] [stdout] 1ba23a2932dbcbba38ed2ef3a1787f8cf8b871c4a6c734f659cc38893b66e0fa