[INFO] fetching crate glrepo 0.4.1... [INFO] checking glrepo-0.4.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate glrepo 0.4.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate glrepo 0.4.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate glrepo 0.4.1 [INFO] finished tweaking crates.io crate glrepo 0.4.1 [INFO] tweaked toml for crates.io crate glrepo 0.4.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate glrepo 0.4.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d71d8876931aeed03580bbd279f7001893d724a2b9f57cb68498afd7e669192e [INFO] running `Command { std: "docker" "start" "-a" "d71d8876931aeed03580bbd279f7001893d724a2b9f57cb68498afd7e669192e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d71d8876931aeed03580bbd279f7001893d724a2b9f57cb68498afd7e669192e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d71d8876931aeed03580bbd279f7001893d724a2b9f57cb68498afd7e669192e", kill_on_drop: false }` [INFO] [stdout] d71d8876931aeed03580bbd279f7001893d724a2b9f57cb68498afd7e669192e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f96fcc3c1d936fe5fa9570236b9a34d06e5cc186caf350ebf1b38870bca60454 [INFO] running `Command { std: "docker" "start" "-a" "f96fcc3c1d936fe5fa9570236b9a34d06e5cc186caf350ebf1b38870bca60454", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.115 [INFO] [stderr] Compiling pkg-config v0.3.24 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.86 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking unicode-bidi v0.3.7 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking tinyvec v1.5.1 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Checking linked-hash-map v0.5.4 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Compiling time-macros v0.2.3 [INFO] [stderr] Checking num_threads v0.1.3 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking textwrap v0.14.2 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Compiling indexmap v1.8.0 [INFO] [stderr] Compiling quote v1.0.15 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Compiling jobserver v0.1.24 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking colored v2.0.0 [INFO] [stderr] Compiling cc v1.0.72 [INFO] [stderr] Checking time v0.3.7 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Compiling libz-sys v1.1.3 [INFO] [stderr] Compiling openssl-sys v0.9.72 [INFO] [stderr] Compiling libssh2-sys v0.2.23 [INFO] [stderr] Compiling libgit2-sys v0.12.26+1.3.0 [INFO] [stderr] Checking simple_logger v2.1.0 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Compiling clap_derive v3.0.12 [INFO] [stderr] Checking clap v3.0.13 [INFO] [stderr] Checking git2 v0.13.25 [INFO] [stderr] Checking serde_yaml v0.8.23 [INFO] [stderr] Checking glrepo v0.4.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/manifest.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct GlProject { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 8 | #[serde(skip)] [INFO] [stdout] 9 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `GlProject` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/manifest.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct GlProject { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 8 | #[serde(skip)] [INFO] [stdout] 9 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `GlProject` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 42 | let mut fopt = fetch_options(name); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | let refs: Vec<&str> = vec![]; [INFO] [stdout] 44 | / repo.find_remote("origin") [INFO] [stdout] 45 | | .and_then(|mut remote| remote.fetch(&refs, Some(&mut fopt), None)) [INFO] [stdout] 46 | | .and_then(|_| { [INFO] [stdout] 47 | | repo.resolve_reference_from_short_name(&format!("origin/{}", &proj.reference)) [INFO] [stdout] 48 | | }) [INFO] [stdout] 49 | | .and_then(|ref_head| repo.reference_to_annotated_commit(&ref_head)) [INFO] [stdout] | |___________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 42 | let mut fopt = fetch_options(name); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | let refs: Vec<&str> = vec![]; [INFO] [stdout] 44 | / repo.find_remote("origin") [INFO] [stdout] 45 | | .and_then(|mut remote| remote.fetch(&refs, Some(&mut fopt), None)) [INFO] [stdout] 46 | | .and_then(|_| { [INFO] [stdout] 47 | | repo.resolve_reference_from_short_name(&format!("origin/{}", &proj.reference)) [INFO] [stdout] 48 | | }) [INFO] [stdout] 49 | | .and_then(|ref_head| repo.reference_to_annotated_commit(&ref_head)) [INFO] [stdout] | |___________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:227:9 [INFO] [stdout] | [INFO] [stdout] 224 | let mut opt = git2::StatusOptions::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | / self.repo [INFO] [stdout] 228 | | .statuses(Some(&mut opt)) [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/threadpool.rs:90:21 [INFO] [stdout] | [INFO] [stdout] 79 | fn new(id: usize, receiver: Arc>>) -> Worker { [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | let thread = thread::spawn(move || loop { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | thread: Some(thread), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:227:9 [INFO] [stdout] | [INFO] [stdout] 224 | let mut opt = git2::StatusOptions::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | / self.repo [INFO] [stdout] 228 | | .statuses(Some(&mut opt)) [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/threadpool.rs:90:21 [INFO] [stdout] | [INFO] [stdout] 79 | fn new(id: usize, receiver: Arc>>) -> Worker { [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | let thread = thread::spawn(move || loop { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | thread: Some(thread), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `glrepo` (bin "glrepo" test) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `glrepo` (bin "glrepo") due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "f96fcc3c1d936fe5fa9570236b9a34d06e5cc186caf350ebf1b38870bca60454", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f96fcc3c1d936fe5fa9570236b9a34d06e5cc186caf350ebf1b38870bca60454", kill_on_drop: false }` [INFO] [stdout] f96fcc3c1d936fe5fa9570236b9a34d06e5cc186caf350ebf1b38870bca60454