[INFO] fetching crate glowdust 0.0.1... [INFO] checking glowdust-0.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate glowdust 0.0.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate glowdust 0.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-6-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate glowdust 0.0.1 [INFO] finished tweaking crates.io crate glowdust 0.0.1 [INFO] tweaked toml for crates.io crate glowdust 0.0.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate glowdust 0.0.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 36577fa52d4769b028485bfa00c6fbf77d92262ccc91727ef74245e67f0f4049 [INFO] running `Command { std: "docker" "start" "-a" "36577fa52d4769b028485bfa00c6fbf77d92262ccc91727ef74245e67f0f4049", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "36577fa52d4769b028485bfa00c6fbf77d92262ccc91727ef74245e67f0f4049", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "36577fa52d4769b028485bfa00c6fbf77d92262ccc91727ef74245e67f0f4049", kill_on_drop: false }` [INFO] [stdout] 36577fa52d4769b028485bfa00c6fbf77d92262ccc91727ef74245e67f0f4049 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1c37ad98964a71caa51137ddaa748a83b4223f840bcff01b9d9677e9ad751406 [INFO] running `Command { std: "docker" "start" "-a" "1c37ad98964a71caa51137ddaa748a83b4223f840bcff01b9d9677e9ad751406", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.76 [INFO] [stderr] Compiling semver v1.0.20 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling libc v0.2.149 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Compiling serde v1.0.195 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Checking smallvec v1.11.1 [INFO] [stderr] Compiling rustix v0.38.21 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking linux-raw-sys v0.4.10 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking hash32 v0.2.1 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling serde_json v1.0.111 [INFO] [stderr] Checking endian-type v0.1.2 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Compiling io-uring v0.6.3 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking thread_local v1.1.7 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking unicode-segmentation v1.10.1 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking home v0.5.5 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Compiling heapless v0.7.16 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking fd-lock v4.0.2 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking serde-json-core v0.5.1 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling phf_macros v0.11.2 [INFO] [stderr] Compiling rustyline-derive v0.10.0 [INFO] [stderr] Compiling ctor v0.2.6 [INFO] [stderr] Checking rustyline v13.0.0 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking glowdust v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::io` [INFO] [stdout] --> src/compiler/cursor.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::io; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tracing::trace` [INFO] [stdout] --> src/compiler/parser/parse_state.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use tracing::trace; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `error` and `trace` [INFO] [stdout] --> src/compiler/parser/parser.rs:27:15 [INFO] [stdout] | [INFO] [stdout] 27 | use tracing::{error, trace}; [INFO] [stdout] | ^^^^^ ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::runtime::disassembler::disassemble_no_lines` [INFO] [stdout] --> src/runtime/vm.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | use crate::runtime::disassembler::disassemble_no_lines; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io` [INFO] [stdout] --> src/compiler/cursor.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::io; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tracing::trace` [INFO] [stdout] --> src/compiler/parser/parse_state.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use tracing::trace; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `error` and `trace` [INFO] [stdout] --> src/compiler/parser/parser.rs:27:15 [INFO] [stdout] | [INFO] [stdout] 27 | use tracing::{error, trace}; [INFO] [stdout] | ^^^^^ ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::runtime::disassembler::disassemble_no_lines` [INFO] [stdout] --> src/runtime/vm.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | use crate::runtime::disassembler::disassemble_no_lines; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> src/store/csv/uring.rs:4:33 [INFO] [stdout] | [INFO] [stdout] 4 | use std::io::{Error, ErrorKind, Read, Result}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/store/csv/uring.rs:20:13 [INFO] [stdout] | [INFO] [stdout] 20 | let mut source = OpenOptions::new().read(true).open(source)?; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `assumed_offset` [INFO] [stdout] --> src/store/csv/uring.rs:77:21 [INFO] [stdout] | [INFO] [stdout] 77 | let assumed_offset = cqe.user_data(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_assumed_offset` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `length` is never read [INFO] [stdout] --> src/compiler/parser/ast.rs:203:16 [INFO] [stdout] | [INFO] [stdout] 200 | pub struct Span { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] ... [INFO] [stdout] 203 | pub(crate) length: usize, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Span` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/compiler/query_solver.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 28 | Call { [INFO] [stdout] | ---- field in this variant [INFO] [stdout] 29 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CompiledCursor` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `cursor_id` is never read [INFO] [stdout] --> src/compiler/query_solver.rs:362:5 [INFO] [stdout] | [INFO] [stdout] 360 | struct CallFrame { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 361 | // the cursor id for this cursor. incremented externally, used for the OpCloseCursor in the epilogue [INFO] [stdout] 362 | cursor_id: u8, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CallFrame` has a derived impl for the trait `Default`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `set_value` is never used [INFO] [stdout] --> src/compiler/value.rs:441:23 [INFO] [stdout] | [INFO] [stdout] 434 | impl FunctionValuesObject { [INFO] [stdout] | ------------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 441 | pub(crate) fn set_value(&mut self, domain_value: Vec, codomain_value: Value) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `dump_stack` is never used [INFO] [stdout] --> src/runtime/vm.rs:235:8 [INFO] [stdout] | [INFO] [stdout] 63 | impl VirtualMachine { [INFO] [stdout] | ------------------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 235 | fn dump_stack(stack: &[Value]) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `CsvInput` is never constructed [INFO] [stdout] --> src/store/csv/mod.rs:11:19 [INFO] [stdout] | [INFO] [stdout] 11 | pub(crate) struct CsvInput { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/store/csv/mod.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 16 | impl CsvInput { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] 17 | pub fn new(function_name: &str, file_name: PathBuf) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `UringReader` is never constructed [INFO] [stdout] --> src/store/csv/uring.rs:8:12 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct UringReader { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `get_blocksize`, and `read` are never used [INFO] [stdout] --> src/store/csv/uring.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 14 | impl UringReader { [INFO] [stdout] | ---------------- associated items in this implementation [INFO] [stdout] 15 | pub fn new(source: &PathBuf, blocksize: u32) -> Result { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 29 | pub fn get_blocksize(&self) -> u32 { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 33 | pub fn read(&mut self, buffer: &mut [u8], offset: u64) -> Result { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compiler/parser/pointer.rs:10:11 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn P(value: T) -> P { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | P(Rc::new(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compiler/query_solver.rs:59:14 [INFO] [stdout] | [INFO] [stdout] 54 | let mut unbound_vars = HashSet::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | &mut walk_context.initialized_variables.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store/csv/mod.rs:68:29 [INFO] [stdout] | [INFO] [stdout] 61 | let file = OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | let reader = BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | FunctionCursor::Csv(CsvFunctionValueCursor { reader }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/store/csv/mod.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 103 | self.reader.seek(SeekFrom::Start(0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 103 | let _ = self.reader.seek(SeekFrom::Start(0)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store/csv/uring.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 20 | let mut source = OpenOptions::new().read(true).open(source)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let filesize = source.metadata()?.len(); [INFO] [stdout] 22 | Ok(UringReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 23 | | blocksize, [INFO] [stdout] 24 | | source, [INFO] [stdout] 25 | | filesize, [INFO] [stdout] 26 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store/serde/mod.rs:81:8 [INFO] [stdout] | [INFO] [stdout] 81 | Ok(( [INFO] [stdout] | ________^ [INFO] [stdout] 82 | | serde_json::from_slice(&buffer[HEADER_SIZE..(length + HEADER_SIZE)]).unwrap(), [INFO] [stdout] 83 | | in_use, [INFO] [stdout] 84 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store/serde/serialization.rs:268:13 [INFO] [stdout] | [INFO] [stdout] 237 | fn visit_map(self, mut map: A) -> Result [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 268 | Err(Error::custom( [INFO] [stdout] | _____________^ [INFO] [stdout] 269 | | "expected Primitive or Object, got nothing instead", [INFO] [stdout] 270 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> src/store/csv/uring.rs:4:33 [INFO] [stdout] | [INFO] [stdout] 4 | use std::io::{Error, ErrorKind, Read, Result}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 17 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `glowdust` (lib) due to 7 previous errors; 17 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/store/csv/uring.rs:20:13 [INFO] [stdout] | [INFO] [stdout] 20 | let mut source = OpenOptions::new().read(true).open(source)?; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `assumed_offset` [INFO] [stdout] --> src/store/csv/uring.rs:77:21 [INFO] [stdout] | [INFO] [stdout] 77 | let assumed_offset = cqe.user_data(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_assumed_offset` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `length` is never read [INFO] [stdout] --> src/compiler/parser/ast.rs:203:16 [INFO] [stdout] | [INFO] [stdout] 200 | pub struct Span { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] ... [INFO] [stdout] 203 | pub(crate) length: usize, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Span` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/compiler/query_solver.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 28 | Call { [INFO] [stdout] | ---- field in this variant [INFO] [stdout] 29 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CompiledCursor` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `cursor_id` is never read [INFO] [stdout] --> src/compiler/query_solver.rs:362:5 [INFO] [stdout] | [INFO] [stdout] 360 | struct CallFrame { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 361 | // the cursor id for this cursor. incremented externally, used for the OpCloseCursor in the epilogue [INFO] [stdout] 362 | cursor_id: u8, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CallFrame` has a derived impl for the trait `Default`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `dump_stack` is never used [INFO] [stdout] --> src/runtime/vm.rs:235:8 [INFO] [stdout] | [INFO] [stdout] 63 | impl VirtualMachine { [INFO] [stdout] | ------------------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 235 | fn dump_stack(stack: &[Value]) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `CsvInput` is never constructed [INFO] [stdout] --> src/store/csv/mod.rs:11:19 [INFO] [stdout] | [INFO] [stdout] 11 | pub(crate) struct CsvInput { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/store/csv/mod.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 16 | impl CsvInput { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] 17 | pub fn new(function_name: &str, file_name: PathBuf) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `UringReader` is never constructed [INFO] [stdout] --> src/store/csv/uring.rs:8:12 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct UringReader { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `get_blocksize`, and `read` are never used [INFO] [stdout] --> src/store/csv/uring.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 14 | impl UringReader { [INFO] [stdout] | ---------------- associated items in this implementation [INFO] [stdout] 15 | pub fn new(source: &PathBuf, blocksize: u32) -> Result { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 29 | pub fn get_blocksize(&self) -> u32 { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 33 | pub fn read(&mut self, buffer: &mut [u8], offset: u64) -> Result { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compiler/parser/pointer.rs:10:11 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn P(value: T) -> P { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | P(Rc::new(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compiler/query_solver.rs:59:14 [INFO] [stdout] | [INFO] [stdout] 54 | let mut unbound_vars = HashSet::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | &mut walk_context.initialized_variables.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store/csv/mod.rs:68:29 [INFO] [stdout] | [INFO] [stdout] 61 | let file = OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | let reader = BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | FunctionCursor::Csv(CsvFunctionValueCursor { reader }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/store/csv/mod.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 103 | self.reader.seek(SeekFrom::Start(0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 103 | let _ = self.reader.seek(SeekFrom::Start(0)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store/csv/uring.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 20 | let mut source = OpenOptions::new().read(true).open(source)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let filesize = source.metadata()?.len(); [INFO] [stdout] 22 | Ok(UringReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 23 | | blocksize, [INFO] [stdout] 24 | | source, [INFO] [stdout] 25 | | filesize, [INFO] [stdout] 26 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store/serde/mod.rs:81:8 [INFO] [stdout] | [INFO] [stdout] 81 | Ok(( [INFO] [stdout] | ________^ [INFO] [stdout] 82 | | serde_json::from_slice(&buffer[HEADER_SIZE..(length + HEADER_SIZE)]).unwrap(), [INFO] [stdout] 83 | | in_use, [INFO] [stdout] 84 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store/serde/serialization.rs:268:13 [INFO] [stdout] | [INFO] [stdout] 237 | fn visit_map(self, mut map: A) -> Result [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 268 | Err(Error::custom( [INFO] [stdout] | _____________^ [INFO] [stdout] 269 | | "expected Primitive or Object, got nothing instead", [INFO] [stdout] 270 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 16 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `glowdust` (lib test) due to 7 previous errors; 16 warnings emitted [INFO] running `Command { std: "docker" "inspect" "1c37ad98964a71caa51137ddaa748a83b4223f840bcff01b9d9677e9ad751406", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1c37ad98964a71caa51137ddaa748a83b4223f840bcff01b9d9677e9ad751406", kill_on_drop: false }` [INFO] [stdout] 1c37ad98964a71caa51137ddaa748a83b4223f840bcff01b9d9677e9ad751406