[INFO] fetching crate glock 0.1.2... [INFO] checking glock-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate glock 0.1.2 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate glock 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate glock 0.1.2 [INFO] finished tweaking crates.io crate glock 0.1.2 [INFO] tweaked toml for crates.io crate glock 0.1.2 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5ef92956dc10c3ea2a542d3fa198dac39e3d25de177363955acac9e02c8f2523 [INFO] running `Command { std: "docker" "start" "-a" "5ef92956dc10c3ea2a542d3fa198dac39e3d25de177363955acac9e02c8f2523", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5ef92956dc10c3ea2a542d3fa198dac39e3d25de177363955acac9e02c8f2523", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5ef92956dc10c3ea2a542d3fa198dac39e3d25de177363955acac9e02c8f2523", kill_on_drop: false }` [INFO] [stdout] 5ef92956dc10c3ea2a542d3fa198dac39e3d25de177363955acac9e02c8f2523 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c9de2a1aca4487d2f2efb68b3587dc652422b5bebcc1aea5e14055cb3bfcbe67 [INFO] running `Command { std: "docker" "start" "-a" "c9de2a1aca4487d2f2efb68b3587dc652422b5bebcc1aea5e14055cb3bfcbe67", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking glock v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/lock.rs:333:10 [INFO] [stdout] | [INFO] [stdout] 333 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lock.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn new_child(&self, data: T) -> LockResult> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | self.new_child_builder().and_then(|cb| cb.build(data)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lock.rs:57:43 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn new_child(&self, data: T) -> LockResult> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | self.new_child_builder().and_then(|cb| cb.build(data)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lock.rs:63:18 [INFO] [stdout] | [INFO] [stdout] 61 | pub fn build(self, data: T) -> LockResult> { [INFO] [stdout] | ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | self.kernel.own() [INFO] [stdout] 63 | .map(|_| GLock { [INFO] [stdout] | __________________^ [INFO] [stdout] 64 | | kernel: self.kernel, [INFO] [stdout] 65 | | data, [INFO] [stdout] 66 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lock.rs:96:56 [INFO] [stdout] | [INFO] [stdout] 96 | pub fn new_root(data: T) -> LockResult> { GLockBuilder::new_root_builder().build(data) } [INFO] [stdout] | ------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lock.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 106 | pub fn new_child(&self, data: T2) -> LockResult> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | self.new_child_builder().and_then(|cb| cb.build(data)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lock.rs:107:43 [INFO] [stdout] | [INFO] [stdout] 106 | pub fn new_child(&self, data: T2) -> LockResult> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | self.new_child_builder().and_then(|cb| cb.build(data)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kernel.rs:33:20 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn new(id: Option, parent: Option) -> LockKernel { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | state: Mutex::new(LockKernelState { [INFO] [stdout] | ____________________^ [INFO] [stdout] 34 | | owned: false, [INFO] [stdout] 35 | | counts: LOCK_EMPTY_COUNTS, [INFO] [stdout] 36 | | children: HashMap::new(), [INFO] [stdout] 37 | | children_counter: 0, [INFO] [stdout] 38 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kernel.rs:83:21 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn new(kernel: LockKernel) -> LockKernelRc { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | LockKernelRc { [INFO] [stdout] 83 | kernel: Arc::new(kernel), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kernel.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 108 | pub fn acquire(&self, lock_type: LockType, using_parent: Option>, auto_upgrade: bool, try_only: bool) -> LockResult... [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | [INFO] [stdout] 110 | let parent_instance = self.ensure_parent_lock(lock_type, using_parent, auto_upgrade, try_only)?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | [INFO] [stdout] 112 | self.lock_state() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kernel.rs:113:23 [INFO] [stdout] | [INFO] [stdout] 108 | pub fn acquire(&self, lock_type: LockType, using_parent: Option>, auto_upgrade: bool, try_only: bool) -> LockResult... [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | [INFO] [stdout] 110 | let parent_instance = self.ensure_parent_lock(lock_type, using_parent, auto_upgrade, try_only)?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | .and_then(|mut state| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 114 | | let mut ready = false; [INFO] [stdout] 115 | | [INFO] [stdout] 116 | | while !ready { [INFO] [stdout] ... | [INFO] [stdout] 134 | | Ok(LockInstance::new(self.clone(), parent_instance, lock_type)) [INFO] [stdout] 135 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kernel.rs:134:20 [INFO] [stdout] | [INFO] [stdout] 110 | let parent_instance = self.ensure_parent_lock(lock_type, using_parent, auto_upgrade, try_only)?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | .and_then(|mut state| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | Ok(LockInstance::new(self.clone(), parent_instance, lock_type)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kernel.rs:156:9 [INFO] [stdout] | [INFO] [stdout] 146 | fn upgrade(&self, from_type: LockType, to_type: LockType, using_parent: Option>, auto_upgrade: bool, try_only: bool... [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | self.lock_state() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kernel.rs:256:18 [INFO] [stdout] | [INFO] [stdout] 254 | fn new(kernel: LockKernelRc, parent: Option>, lock_type: LockType) -> Arc { [INFO] [stdout] | -------------------- --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 255 | [INFO] [stdout] 256 | Arc::new(LockInstance { [INFO] [stdout] | __________________^ [INFO] [stdout] 257 | | kernel, [INFO] [stdout] 258 | | parent, [INFO] [stdout] 259 | | state: Mutex::new(LockInstanceState { lock_type, }), [INFO] [stdout] 260 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `glock` (lib) due to 14 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lock.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn new_child(&self, data: T) -> LockResult> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | self.new_child_builder().and_then(|cb| cb.build(data)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lock.rs:57:43 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn new_child(&self, data: T) -> LockResult> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | self.new_child_builder().and_then(|cb| cb.build(data)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lock.rs:63:18 [INFO] [stdout] | [INFO] [stdout] 61 | pub fn build(self, data: T) -> LockResult> { [INFO] [stdout] | ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | self.kernel.own() [INFO] [stdout] 63 | .map(|_| GLock { [INFO] [stdout] | __________________^ [INFO] [stdout] 64 | | kernel: self.kernel, [INFO] [stdout] 65 | | data, [INFO] [stdout] 66 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lock.rs:96:56 [INFO] [stdout] | [INFO] [stdout] 96 | pub fn new_root(data: T) -> LockResult> { GLockBuilder::new_root_builder().build(data) } [INFO] [stdout] | ------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lock.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 106 | pub fn new_child(&self, data: T2) -> LockResult> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | self.new_child_builder().and_then(|cb| cb.build(data)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lock.rs:107:43 [INFO] [stdout] | [INFO] [stdout] 106 | pub fn new_child(&self, data: T2) -> LockResult> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | self.new_child_builder().and_then(|cb| cb.build(data)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kernel.rs:33:20 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn new(id: Option, parent: Option) -> LockKernel { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | state: Mutex::new(LockKernelState { [INFO] [stdout] | ____________________^ [INFO] [stdout] 34 | | owned: false, [INFO] [stdout] 35 | | counts: LOCK_EMPTY_COUNTS, [INFO] [stdout] 36 | | children: HashMap::new(), [INFO] [stdout] 37 | | children_counter: 0, [INFO] [stdout] 38 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kernel.rs:83:21 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn new(kernel: LockKernel) -> LockKernelRc { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | LockKernelRc { [INFO] [stdout] 83 | kernel: Arc::new(kernel), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kernel.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 108 | pub fn acquire(&self, lock_type: LockType, using_parent: Option>, auto_upgrade: bool, try_only: bool) -> LockResult... [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | [INFO] [stdout] 110 | let parent_instance = self.ensure_parent_lock(lock_type, using_parent, auto_upgrade, try_only)?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | [INFO] [stdout] 112 | self.lock_state() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kernel.rs:113:23 [INFO] [stdout] | [INFO] [stdout] 108 | pub fn acquire(&self, lock_type: LockType, using_parent: Option>, auto_upgrade: bool, try_only: bool) -> LockResult... [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | [INFO] [stdout] 110 | let parent_instance = self.ensure_parent_lock(lock_type, using_parent, auto_upgrade, try_only)?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | .and_then(|mut state| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 114 | | let mut ready = false; [INFO] [stdout] 115 | | [INFO] [stdout] 116 | | while !ready { [INFO] [stdout] ... | [INFO] [stdout] 134 | | Ok(LockInstance::new(self.clone(), parent_instance, lock_type)) [INFO] [stdout] 135 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kernel.rs:134:20 [INFO] [stdout] | [INFO] [stdout] 110 | let parent_instance = self.ensure_parent_lock(lock_type, using_parent, auto_upgrade, try_only)?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | .and_then(|mut state| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | Ok(LockInstance::new(self.clone(), parent_instance, lock_type)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kernel.rs:156:9 [INFO] [stdout] | [INFO] [stdout] 146 | fn upgrade(&self, from_type: LockType, to_type: LockType, using_parent: Option>, auto_upgrade: bool, try_only: bool... [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | self.lock_state() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kernel.rs:256:18 [INFO] [stdout] | [INFO] [stdout] 254 | fn new(kernel: LockKernelRc, parent: Option>, lock_type: LockType) -> Arc { [INFO] [stdout] | -------------------- --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 255 | [INFO] [stdout] 256 | Arc::new(LockInstance { [INFO] [stdout] | __________________^ [INFO] [stdout] 257 | | kernel, [INFO] [stdout] 258 | | parent, [INFO] [stdout] 259 | | state: Mutex::new(LockInstanceState { lock_type, }), [INFO] [stdout] 260 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `glock` (lib test) due to 14 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "c9de2a1aca4487d2f2efb68b3587dc652422b5bebcc1aea5e14055cb3bfcbe67", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c9de2a1aca4487d2f2efb68b3587dc652422b5bebcc1aea5e14055cb3bfcbe67", kill_on_drop: false }` [INFO] [stdout] c9de2a1aca4487d2f2efb68b3587dc652422b5bebcc1aea5e14055cb3bfcbe67