[INFO] fetching crate globwalk 0.9.1... [INFO] checking globwalk-0.9.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate globwalk 0.9.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate globwalk 0.9.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate globwalk 0.9.1 [INFO] finished tweaking crates.io crate globwalk 0.9.1 [INFO] tweaked toml for crates.io crate globwalk 0.9.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate globwalk 0.9.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f9e3947e5785cda6835dd6c52ee78bfbde74eef33dbdae762f3090f072c6c3b1 [INFO] running `Command { std: "docker" "start" "-a" "f9e3947e5785cda6835dd6c52ee78bfbde74eef33dbdae762f3090f072c6c3b1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f9e3947e5785cda6835dd6c52ee78bfbde74eef33dbdae762f3090f072c6c3b1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f9e3947e5785cda6835dd6c52ee78bfbde74eef33dbdae762f3090f072c6c3b1", kill_on_drop: false }` [INFO] [stdout] f9e3947e5785cda6835dd6c52ee78bfbde74eef33dbdae762f3090f072c6c3b1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c54dead677b6fd1331084e3e19dd9f2568bedc3fb62096664360fe4274c54bb1 [INFO] running `Command { std: "docker" "start" "-a" "c54dead677b6fd1331084e3e19dd9f2568bedc3fb62096664360fe4274c54bb1", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling rustix v0.38.28 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking thread_local v1.1.7 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking bstr v1.8.0 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Compiling backtrace-sys v0.1.37 [INFO] [stderr] Checking tempfile v3.9.0 [INFO] [stderr] Checking backtrace v0.3.35 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking which v2.0.1 [INFO] [stderr] Checking docmatic v0.1.2 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking ignore v0.4.20 [INFO] [stderr] Checking globwalk v0.9.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:107:19 [INFO] [stdout] | [INFO] [stdout] 106 | fn from(e: std::io::Error) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | GlobError(e.into()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:163:49 [INFO] [stdout] | [INFO] [stdout] 158 | pub fn new(base: P, pattern: S) -> Self [INFO] [stdout] | ------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 163 | GlobWalkerBuilder::from_patterns(base, &[pattern]) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:187:21 [INFO] [stdout] | [INFO] [stdout] 170 | pub fn from_patterns(base: P, patterns: &[S]) -> Self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | walker: WalkDir::new(base), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:320:12 [INFO] [stdout] | [INFO] [stdout] 309 | pub fn build(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 320 | Ok(GlobWalker { [INFO] [stdout] | ____________^ [INFO] [stdout] 321 | | ignore: builder.build().map_err(GlobError)?, [INFO] [stdout] 322 | | walker: self.walker.into_iter(), [INFO] [stdout] 323 | | file_type_filter: self.file_type, [INFO] [stdout] 324 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:458:5 [INFO] [stdout] | [INFO] [stdout] 457 | pub fn glob>(pattern: S) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 458 | glob_builder(pattern).build() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `globwalk` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:107:19 [INFO] [stdout] | [INFO] [stdout] 106 | fn from(e: std::io::Error) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | GlobError(e.into()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:163:49 [INFO] [stdout] | [INFO] [stdout] 158 | pub fn new(base: P, pattern: S) -> Self [INFO] [stdout] | ------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 163 | GlobWalkerBuilder::from_patterns(base, &[pattern]) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:187:21 [INFO] [stdout] | [INFO] [stdout] 170 | pub fn from_patterns(base: P, patterns: &[S]) -> Self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | walker: WalkDir::new(base), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:320:12 [INFO] [stdout] | [INFO] [stdout] 309 | pub fn build(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 320 | Ok(GlobWalker { [INFO] [stdout] | ____________^ [INFO] [stdout] 321 | | ignore: builder.build().map_err(GlobError)?, [INFO] [stdout] 322 | | walker: self.walker.into_iter(), [INFO] [stdout] 323 | | file_type_filter: self.file_type, [INFO] [stdout] 324 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:458:5 [INFO] [stdout] | [INFO] [stdout] 457 | pub fn glob>(pattern: S) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 458 | glob_builder(pattern).build() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `globwalk` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "c54dead677b6fd1331084e3e19dd9f2568bedc3fb62096664360fe4274c54bb1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c54dead677b6fd1331084e3e19dd9f2568bedc3fb62096664360fe4274c54bb1", kill_on_drop: false }` [INFO] [stdout] c54dead677b6fd1331084e3e19dd9f2568bedc3fb62096664360fe4274c54bb1