[INFO] fetching crate gll 0.0.2... [INFO] checking gll-0.0.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate gll 0.0.2 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate gll 0.0.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gll 0.0.2 [INFO] finished tweaking crates.io crate gll 0.0.2 [INFO] tweaked toml for crates.io crate gll 0.0.2 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 5 packages to latest compatible versions [INFO] [stderr] Adding indexing v0.3.2 (latest: v0.4.1) [INFO] [stderr] Adding ordermap v0.3.5 (latest: v0.5.3) [INFO] [stderr] Adding proc-macro2 v0.4.30 (latest: v1.0.86) [INFO] [stderr] Adding unicode-xid v0.1.0 (latest: v0.2.5) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7e9ccde18df63b8d338ffa6bd6ae1ee756661e2048fe3b19b8249569192e633b [INFO] running `Command { std: "docker" "start" "-a" "7e9ccde18df63b8d338ffa6bd6ae1ee756661e2048fe3b19b8249569192e633b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7e9ccde18df63b8d338ffa6bd6ae1ee756661e2048fe3b19b8249569192e633b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7e9ccde18df63b8d338ffa6bd6ae1ee756661e2048fe3b19b8249569192e633b", kill_on_drop: false }` [INFO] [stdout] 7e9ccde18df63b8d338ffa6bd6ae1ee756661e2048fe3b19b8249569192e633b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e260f2b4a8e2445322ce9de23fba45f951433b32eb41c847641ef7c3dcbf3c32 [INFO] running `Command { std: "docker" "start" "-a" "e260f2b4a8e2445322ce9de23fba45f951433b32eb41c847641ef7c3dcbf3c32", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling ordermap v0.3.5 [INFO] [stderr] Compiling indexing v0.3.2 [INFO] [stderr] Checking unicode-xid v0.1.0 [INFO] [stderr] Compiling gll v0.0.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/generate/rust.rs:41:30 [INFO] [stdout] | [INFO] [stdout] 41 | .map(|rule| (rule.clone(), "", OrderMap::new())) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/generate/rust.rs:41:48 [INFO] [stdout] | [INFO] [stdout] 41 | .map(|rule| (rule.clone(), "", OrderMap::new())) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/generate/rust.rs:994:31 [INFO] [stdout] | [INFO] [stdout] 994 | .and_then(|child| child.wait_with_output().map(|o| o.status.success())) [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/generate/rust.rs:1133:15 [INFO] [stdout] | [INFO] [stdout] 1132 | fn add(self, other: Thunk) -> Self::Output { [INFO] [stdout] | ---- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1133 | Thunk(Compose(other.0, self.0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/generate/rust.rs:1155:5 [INFO] [stdout] | [INFO] [stdout] 1154 | fn pop_state(f: impl FnOnce(&str) -> Thunk) -> Thunk { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1155 | f("c.state") + Thunk::new(|mut cont| { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/generate/rust.rs:1275:16 [INFO] [stdout] | [INFO] [stdout] 1274 | fn parallel(thunks: impl ForEachThunk) -> Thunk { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1275 | Thunk::new(|mut cont| { [INFO] [stdout] | ________________^ [INFO] [stdout] 1276 | | cont.to_label(); [INFO] [stdout] 1277 | | let mut code = String::new(); [INFO] [stdout] 1278 | | let mut child_nested_frames = None; [INFO] [stdout] ... | [INFO] [stdout] 1309 | | cont [INFO] [stdout] 1310 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/generate/rust.rs:1314:14 [INFO] [stdout] | [INFO] [stdout] 1313 | fn opt(thunk: Thunk) -> Thunk { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1314 | parallel((thunk, thunk!(""))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/generate/rust.rs:1318:16 [INFO] [stdout] | [INFO] [stdout] 1317 | fn fix(f: impl FnOnce(CodeLabel) -> Thunk) -> Thunk { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1318 | Thunk::new(|mut cont| { [INFO] [stdout] | ________________^ [INFO] [stdout] 1319 | | let nested_frames = mem::replace(&mut cont.nested_frames, vec![]); [INFO] [stdout] 1320 | | let ret_label = cont.to_label().clone(); [INFO] [stdout] 1321 | | cont.code = Code::Inline(String::new()); [INFO] [stdout] ... | [INFO] [stdout] 1331 | | cont [INFO] [stdout] 1332 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/generate/rust.rs:1396:21 [INFO] [stdout] | [INFO] [stdout] 1394 | let more = Rc::new(Rule::RepeatMore(rule.clone(), None)); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1395 | opt( [INFO] [stdout] 1396 | / thunk!(" [INFO] [stdout] 1397 | | assert_eq!(_range.start(), c.fn_input.start());") + [INFO] [stdout] 1398 | | rule.generate_parse(Some(parse_nodes)) + [INFO] [stdout] 1399 | | push_state("c.fn_input.subtract_suffix(_range).len()") + [INFO] [stdout] 1400 | | call(label) + [INFO] [stdout] 1401 | | pop_state(move |state| sppf_add(&more.parse_node_kind(parse_nodes), state)) [INFO] [stdout] | |_______________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/generate/rust.rs:1477:21 [INFO] [stdout] | [INFO] [stdout] 1477 | / write!( [INFO] [stdout] 1478 | | s, [INFO] [stdout] 1479 | | "{} _{}: {} => {},", [INFO] [stdout] 1480 | | i, [INFO] [stdout] ... | [INFO] [stdout] 1483 | | rule.generate_traverse_shape(true, parse_nodes) [INFO] [stdout] 1484 | | ); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this warning originates in the macro `write` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/generate/rust.rs:1486:17 [INFO] [stdout] | [INFO] [stdout] 1486 | write!(s, " }}"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: this warning originates in the macro `write` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grammar.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn new(x: T) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | Rc(::std::rc::Rc::new(x)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grammar.rs:100:20 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn insert_whitespace(self, whitespace: RuleWithNamedFields) -> Self [INFO] [stdout] | ---- ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | let mut inserter = WhitespaceInserter { whitespace }; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | Grammar { [INFO] [stdout] 100 | rules: self [INFO] [stdout] | ____________________^ [INFO] [stdout] 101 | | .rules [INFO] [stdout] 102 | | .into_iter() [INFO] [stdout] 103 | | .map(|(name, rule)| (name, rule.fold(&mut inserter))) [INFO] [stdout] 104 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grammar.rs:74:17 [INFO] [stdout] | [INFO] [stdout] 71 | left: RuleWithNamedFields, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | right: RuleWithNamedFields, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | ) -> RuleWithNamedFields { [INFO] [stdout] 74 | left.fold(self) + self.whitespace.clone() + right.fold(self) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grammar.rs:74:61 [INFO] [stdout] | [INFO] [stdout] 71 | left: RuleWithNamedFields, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | right: RuleWithNamedFields, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | ) -> RuleWithNamedFields { [INFO] [stdout] 74 | left.fold(self) + self.whitespace.clone() + right.fold(self) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grammar.rs:81:17 [INFO] [stdout] | [INFO] [stdout] 78 | elem: RuleWithNamedFields, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | sep: Option>, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | ) -> RuleWithNamedFields { [INFO] [stdout] 81 | elem.fold(self).repeat_many(Some( [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grammar.rs:81:45 [INFO] [stdout] | [INFO] [stdout] 78 | elem: RuleWithNamedFields, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | sep: Option>, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | ) -> RuleWithNamedFields { [INFO] [stdout] 81 | elem.fold(self).repeat_many(Some( [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 82 | | sep.map_or_else(empty, |sep| self.whitespace.clone() + sep.fold(self)) [INFO] [stdout] 83 | | + self.whitespace.clone(), [INFO] [stdout] 84 | | )) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grammar.rs:82:50 [INFO] [stdout] | [INFO] [stdout] 82 | sep.map_or_else(empty, |sep| self.whitespace.clone() + sep.fold(self)) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grammar.rs:82:76 [INFO] [stdout] | [INFO] [stdout] 82 | sep.map_or_else(empty, |sep| self.whitespace.clone() + sep.fold(self)) [INFO] [stdout] | --- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grammar.rs:91:17 [INFO] [stdout] | [INFO] [stdout] 88 | elem: RuleWithNamedFields, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | sep: Option>, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | ) -> RuleWithNamedFields { [INFO] [stdout] 91 | elem.fold(self).repeat_more(Some( [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grammar.rs:91:45 [INFO] [stdout] | [INFO] [stdout] 88 | elem: RuleWithNamedFields, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | sep: Option>, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | ) -> RuleWithNamedFields { [INFO] [stdout] 91 | elem.fold(self).repeat_more(Some( [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 92 | | sep.map_or_else(empty, |sep| self.whitespace.clone() + sep.fold(self)) [INFO] [stdout] 93 | | + self.whitespace.clone(), [INFO] [stdout] 94 | | )) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grammar.rs:92:50 [INFO] [stdout] | [INFO] [stdout] 92 | sep.map_or_else(empty, |sep| self.whitespace.clone() + sep.fold(self)) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grammar.rs:92:76 [INFO] [stdout] | [INFO] [stdout] 92 | sep.map_or_else(empty, |sep| self.whitespace.clone() + sep.fold(self)) [INFO] [stdout] | --- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grammar.rs:103:44 [INFO] [stdout] | [INFO] [stdout] 103 | .map(|(name, rule)| (name, rule.fold(&mut inserter))) [INFO] [stdout] | ------------ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grammar.rs:123:15 [INFO] [stdout] | [INFO] [stdout] 121 | pub fn eat(pat: impl Into) -> RuleWithNamedFields { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | RuleWithNamedFields { [INFO] [stdout] 123 | rule: Rc::new(Rule::Eat(pat.into())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grammar.rs:124:17 [INFO] [stdout] | [INFO] [stdout] 121 | pub fn eat(pat: impl Into) -> RuleWithNamedFields { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | fields: OrderMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grammar.rs:129:15 [INFO] [stdout] | [INFO] [stdout] 127 | pub fn negative_lookahead(pat: impl Into) -> RuleWithNamedFields { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | RuleWithNamedFields { [INFO] [stdout] 129 | rule: Rc::new(Rule::NegativeLookahead(pat.into())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grammar.rs:130:17 [INFO] [stdout] | [INFO] [stdout] 127 | pub fn negative_lookahead(pat: impl Into) -> RuleWithNamedFields { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | fields: OrderMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grammar.rs:160:21 [INFO] [stdout] | [INFO] [stdout] 157 | .map(|(name, paths)| { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | / paths [INFO] [stdout] 161 | | .into_iter() [INFO] [stdout] 162 | | .map(|mut path| { [INFO] [stdout] 163 | | path.insert(0, 0); [INFO] [stdout] 164 | | path [INFO] [stdout] 165 | | }) [INFO] [stdout] 166 | | .collect(), [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grammar.rs:180:21 [INFO] [stdout] | [INFO] [stdout] 177 | .map(|(name, paths)| { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | / paths [INFO] [stdout] 181 | | .into_iter() [INFO] [stdout] 182 | | .map(|mut path| { [INFO] [stdout] 183 | | path.insert(0, 0); [INFO] [stdout] 184 | | path [INFO] [stdout] 185 | | }) [INFO] [stdout] 186 | | .collect(), [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grammar.rs:203:21 [INFO] [stdout] | [INFO] [stdout] 200 | .map(|(name, paths)| { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 203 | / paths [INFO] [stdout] 204 | | .into_iter() [INFO] [stdout] 205 | | .map(|mut path| { [INFO] [stdout] 206 | | path.insert(0, 0); [INFO] [stdout] 207 | | path [INFO] [stdout] 208 | | }) [INFO] [stdout] 209 | | .collect(), [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grammar.rs:237:21 [INFO] [stdout] | [INFO] [stdout] 234 | .map(|(name, paths)| { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 237 | / paths [INFO] [stdout] 238 | | .into_iter() [INFO] [stdout] 239 | | .map(|mut path| { [INFO] [stdout] 240 | | path.insert(0, 0); [INFO] [stdout] 241 | | path [INFO] [stdout] 242 | | }) [INFO] [stdout] 243 | | .collect(), [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grammar.rs:304:19 [INFO] [stdout] | [INFO] [stdout] 268 | fn bitor(self, other: Self) -> Self { [INFO] [stdout] | ---- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 269 | let (old_rules, this, mut fields) = match &*self.rule { [INFO] [stdout] | ---- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 283 | let rules = { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 284 | let new_rules = [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 304 | rule: Rc::new(Rule::Or(rules)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grammar.rs:496:9 [INFO] [stdout] | [INFO] [stdout] 493 | left: RuleWithNamedFields, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 494 | right: RuleWithNamedFields, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 495 | ) -> RuleWithNamedFields { [INFO] [stdout] 496 | left.fold(self) + right.fold(self) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grammar.rs:496:27 [INFO] [stdout] | [INFO] [stdout] 493 | left: RuleWithNamedFields, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 494 | right: RuleWithNamedFields, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 495 | ) -> RuleWithNamedFields { [INFO] [stdout] 496 | left.fold(self) + right.fold(self) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grammar.rs:507:9 [INFO] [stdout] | [INFO] [stdout] 506 | fn fold_opt(&mut self, rule: RuleWithNamedFields) -> RuleWithNamedFields { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 507 | rule.fold(self).opt() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grammar.rs:514:9 [INFO] [stdout] | [INFO] [stdout] 511 | elem: RuleWithNamedFields, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 512 | sep: Option>, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 513 | ) -> RuleWithNamedFields { [INFO] [stdout] 514 | elem.fold(self).repeat_many(sep.map(|sep| sep.fold(self))) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grammar.rs:514:37 [INFO] [stdout] | [INFO] [stdout] 511 | elem: RuleWithNamedFields, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 512 | sep: Option>, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 513 | ) -> RuleWithNamedFields { [INFO] [stdout] 514 | elem.fold(self).repeat_many(sep.map(|sep| sep.fold(self))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grammar.rs:521:9 [INFO] [stdout] | [INFO] [stdout] 518 | elem: RuleWithNamedFields, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 519 | sep: Option>, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 520 | ) -> RuleWithNamedFields { [INFO] [stdout] 521 | elem.fold(self).repeat_more(sep.map(|sep| sep.fold(self))) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grammar.rs:521:37 [INFO] [stdout] | [INFO] [stdout] 518 | elem: RuleWithNamedFields, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 519 | sep: Option>, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 520 | ) -> RuleWithNamedFields { [INFO] [stdout] 521 | elem.fold(self).repeat_more(sep.map(|sep| sep.fold(self))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grammar.rs:560:19 [INFO] [stdout] | [INFO] [stdout] 560 | rule: rule.clone(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grammar.rs:561:21 [INFO] [stdout] | [INFO] [stdout] 561 | fields: self.filter_fields(Some(i)).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 40 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gll` (build script) due to 41 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e260f2b4a8e2445322ce9de23fba45f951433b32eb41c847641ef7c3dcbf3c32", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e260f2b4a8e2445322ce9de23fba45f951433b32eb41c847641ef7c3dcbf3c32", kill_on_drop: false }` [INFO] [stdout] e260f2b4a8e2445322ce9de23fba45f951433b32eb41c847641ef7c3dcbf3c32