[INFO] fetching crate glk 0.2.0... [INFO] checking glk-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate glk 0.2.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate glk 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate glk 0.2.0 [INFO] finished tweaking crates.io crate glk 0.2.0 [INFO] tweaked toml for crates.io crate glk 0.2.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate glk 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3780f5c2a641b320d6f4768af05563f05e7ec3d80fe78ef6b243a3dce889ebb3 [INFO] running `Command { std: "docker" "start" "-a" "3780f5c2a641b320d6f4768af05563f05e7ec3d80fe78ef6b243a3dce889ebb3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3780f5c2a641b320d6f4768af05563f05e7ec3d80fe78ef6b243a3dce889ebb3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3780f5c2a641b320d6f4768af05563f05e7ec3d80fe78ef6b243a3dce889ebb3", kill_on_drop: false }` [INFO] [stdout] 3780f5c2a641b320d6f4768af05563f05e7ec3d80fe78ef6b243a3dce889ebb3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 87dd950373068fe5ce99d4f9fa4aeddf5cad89a87812c889987e93500cbcf739 [INFO] running `Command { std: "docker" "start" "-a" "87dd950373068fe5ce99d4f9fa4aeddf5cad89a87812c889987e93500cbcf739", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.64 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling version_check v0.1.5 [INFO] [stderr] Compiling cc v1.0.45 [INFO] [stderr] Compiling glob v0.3.0 [INFO] [stderr] Compiling proc-macro2 v1.0.5 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling quick-error v1.2.2 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling regex-syntax v0.6.12 [INFO] [stderr] Compiling unicode-width v0.1.6 [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Compiling strsim v0.8.0 [INFO] [stderr] Compiling thread_local v0.3.6 [INFO] [stderr] Compiling humantime v1.3.0 [INFO] [stderr] Compiling vec_map v0.8.1 [INFO] [stderr] Compiling termcolor v1.0.5 [INFO] [stderr] Compiling textwrap v0.11.0 [INFO] [stderr] Compiling bindgen v0.51.1 [INFO] [stderr] Compiling nom v4.2.3 [INFO] [stderr] Compiling ansi_term v0.11.0 [INFO] [stderr] Compiling shlex v0.1.1 [INFO] [stderr] Compiling peeking_take_while v0.1.2 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Compiling clang-sys v0.28.1 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Compiling libloading v0.5.2 [INFO] [stderr] Compiling rustc-hash v1.0.1 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Compiling aho-corasick v0.7.6 [INFO] [stderr] Checking mio v0.6.19 [INFO] [stderr] Compiling atty v0.2.13 [INFO] [stderr] Compiling which v3.0.0 [INFO] [stderr] Compiling clap v2.33.0 [INFO] [stderr] Checking crossterm v0.12.1 [INFO] [stderr] Compiling cexpr v0.3.5 [INFO] [stderr] Compiling regex v1.3.1 [INFO] [stderr] Compiling env_logger v0.6.2 [INFO] [stderr] Compiling glk-sys v0.2.0 [INFO] [stderr] Compiling glulxe-sys v0.2.0 [INFO] [stderr] Checking glk v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: creating a mutable reference to mutable static is discouraged [INFO] [stdout] --> src/lib.rs:40:14 [INFO] [stdout] | [INFO] [stdout] 40 | unsafe { &mut DUMMY } [INFO] [stdout] | ^^^^^^^^^^ mutable reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #114447 [INFO] [stdout] = note: this will be a hard error in the 2024 edition [INFO] [stdout] = note: this mutable reference has lifetime `'static`, but if the static gets accessed (read or written) by any other means, or any other reference is created, then any further use of this mutable reference is Undefined Behavior [INFO] [stdout] = note: `#[warn(static_mut_refs)]` on by default [INFO] [stdout] help: use `addr_of_mut!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 40 | unsafe { addr_of_mut!(DUMMY) } [INFO] [stdout] | ~~~~~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/helpers/memory_stream.rs:88:13 [INFO] [stdout] | [INFO] [stdout] 88 | &buf[0..last - self.pos].copy_from_slice(&self.buffer[self.pos..last]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 88 | let _ = &buf[0..last - self.pos].copy_from_slice(&self.buffer[self.pos..last]); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/helpers/memory_stream.rs:189:13 [INFO] [stdout] | [INFO] [stdout] 189 | &buf[0..last - self.pos].copy_from_slice(&self.buffer[self.pos..last]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 189 | let _ = &buf[0..last - self.pos].copy_from_slice(&self.buffer[self.pos..last]); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers/pool.rs:720:20 [INFO] [stdout] | [INFO] [stdout] 718 | fn into_iter(self) -> Self::IntoIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 719 | IntoIter { [INFO] [stdout] 720 | slots: self.slots.into_iter().enumerate(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers/stream_manager.rs:53:21 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn from_file(&mut self, gamefile: File) -> strid_t { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | self.streams [INFO] [stdout] 53 | .insert(Box::new(FileStreamBin8::new(0, gamefile))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `glk` (lib) due to 3 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "87dd950373068fe5ce99d4f9fa4aeddf5cad89a87812c889987e93500cbcf739", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "87dd950373068fe5ce99d4f9fa4aeddf5cad89a87812c889987e93500cbcf739", kill_on_drop: false }` [INFO] [stdout] 87dd950373068fe5ce99d4f9fa4aeddf5cad89a87812c889987e93500cbcf739