[INFO] fetching crate glint 6.3.4... [INFO] checking glint-6.3.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate glint 6.3.4 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate glint 6.3.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-3-tc2/source/.cargo/config [INFO] started tweaking crates.io crate glint 6.3.4 [INFO] finished tweaking crates.io crate glint 6.3.4 [INFO] tweaked toml for crates.io crate glint 6.3.4 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate glint 6.3.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7b8df889135a0713160510de183d5e2ed78ac5312e192b755d5a788a04e7dcb8 [INFO] running `Command { std: "docker" "start" "-a" "7b8df889135a0713160510de183d5e2ed78ac5312e192b755d5a788a04e7dcb8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7b8df889135a0713160510de183d5e2ed78ac5312e192b755d5a788a04e7dcb8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7b8df889135a0713160510de183d5e2ed78ac5312e192b755d5a788a04e7dcb8", kill_on_drop: false }` [INFO] [stdout] 7b8df889135a0713160510de183d5e2ed78ac5312e192b755d5a788a04e7dcb8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0eca591aa8dc90284bf3af67f3967130083948b45be0d5b1987d5f2769db91bc [INFO] running `Command { std: "docker" "start" "-a" "0eca591aa8dc90284bf3af67f3967130083948b45be0d5b1987d5f2769db91bc", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.80 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling syn v1.0.53 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking unic-char-range v0.9.0 [INFO] [stderr] Compiling unicode-segmentation v1.7.1 [INFO] [stderr] Checking smallvec v1.5.1 [INFO] [stderr] Checking unic-common v0.9.0 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking unic-ucd-version v0.9.0 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking unic-char-property v0.9.0 [INFO] [stderr] Checking unic-ucd-segment v0.9.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Checking unic-segment v0.9.0 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking parking_lot_core v0.7.2 [INFO] [stderr] Checking mio v0.7.6 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking signal-hook-registry v1.2.2 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking parking_lot v0.10.2 [INFO] [stderr] Checking signal-hook v0.1.16 [INFO] [stderr] Checking crossterm v0.17.7 [INFO] [stderr] Compiling structopt-derive v0.4.16 [INFO] [stderr] Checking structopt v0.3.23 [INFO] [stderr] Checking glint v6.3.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `config` is never read [INFO] [stdout] --> src/prompt/message_prompt.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct MessagePrompt<'a> { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 11 | config: &'a Config, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `MessagePrompt` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `selected_index` is never read [INFO] [stdout] --> src/prompt/scope_prompt.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct ScopePrompt<'a> { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 13 | selected_index: u16, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ScopePrompt` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `first_row` is never read [INFO] [stdout] --> src/term_buffer.rs:253:5 [INFO] [stdout] | [INFO] [stdout] 250 | struct State { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 253 | first_row: u16, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `State` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:117:13 [INFO] [stdout] | [INFO] [stdout] 110 | pub fn log_parsed(&self, other_args: impl IntoIterator) -> io::Result> [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | let proc = self.log(other_args).stdout(Stdio::piped()).spawn()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | let stdout = proc.stdout.expect("must be able to access stdout"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | Ok(parse_log::parse_logs( [INFO] [stdout] 117 | BufReader::new(stdout).lines().filter_map(Result::ok), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `config` is never read [INFO] [stdout] --> src/prompt/message_prompt.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct MessagePrompt<'a> { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 11 | config: &'a Config, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `MessagePrompt` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `glint` (lib test) due to 2 previous errors; 3 warnings emitted [INFO] [stdout] warning: field `selected_index` is never read [INFO] [stdout] --> src/prompt/scope_prompt.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct ScopePrompt<'a> { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 13 | selected_index: u16, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ScopePrompt` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `first_row` is never read [INFO] [stdout] --> src/term_buffer.rs:253:5 [INFO] [stdout] | [INFO] [stdout] 250 | struct State { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 253 | first_row: u16, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `State` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:117:13 [INFO] [stdout] | [INFO] [stdout] 110 | pub fn log_parsed(&self, other_args: impl IntoIterator) -> io::Result> [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | let proc = self.log(other_args).stdout(Stdio::piped()).spawn()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | let stdout = proc.stdout.expect("must be able to access stdout"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | Ok(parse_log::parse_logs( [INFO] [stdout] 117 | BufReader::new(stdout).lines().filter_map(Result::ok), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `glint` (lib) due to 2 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "0eca591aa8dc90284bf3af67f3967130083948b45be0d5b1987d5f2769db91bc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0eca591aa8dc90284bf3af67f3967130083948b45be0d5b1987d5f2769db91bc", kill_on_drop: false }` [INFO] [stdout] 0eca591aa8dc90284bf3af67f3967130083948b45be0d5b1987d5f2769db91bc