[INFO] fetching crate glidesort 0.1.2... [INFO] checking glidesort-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate glidesort 0.1.2 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate glidesort 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate glidesort 0.1.2 [INFO] finished tweaking crates.io crate glidesort 0.1.2 [INFO] tweaked toml for crates.io crate glidesort 0.1.2 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 2 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 76bee3ea828917a383b412c5efcd2fbb525bb78d162b5b9d5331f24d4232fde9 [INFO] running `Command { std: "docker" "start" "-a" "76bee3ea828917a383b412c5efcd2fbb525bb78d162b5b9d5331f24d4232fde9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "76bee3ea828917a383b412c5efcd2fbb525bb78d162b5b9d5331f24d4232fde9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "76bee3ea828917a383b412c5efcd2fbb525bb78d162b5b9d5331f24d4232fde9", kill_on_drop: false }` [INFO] [stdout] 76bee3ea828917a383b412c5efcd2fbb525bb78d162b5b9d5331f24d4232fde9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4334530c0accd59fba7d7d4300d6ed1e6c490e5790cc8f2db31f83908d9a78b1 [INFO] running `Command { std: "docker" "start" "-a" "4334530c0accd59fba7d7d4300d6ed1e6c490e5790cc8f2db31f83908d9a78b1", kill_on_drop: false }` [INFO] [stderr] Checking glidesort v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:82:30 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn sort_by_key K, K: Ord>(v: &mut [T], mut f: F) { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | sort_with_vec_by(v, &mut Vec::new(), |a, b| f(a).cmp(&f(b))) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:82:49 [INFO] [stdout] | [INFO] [stdout] 82 | sort_with_vec_by(v, &mut Vec::new(), |a, b| f(a).cmp(&f(b))) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:82:59 [INFO] [stdout] | [INFO] [stdout] 82 | sort_with_vec_by(v, &mut Vec::new(), |a, b| f(a).cmp(&f(b))) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:90:30 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn sort_by(v: &mut [T], compare: F) [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | sort_with_vec_by(v, &mut Vec::new(), compare) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:108:45 [INFO] [stdout] | [INFO] [stdout] 108 | sort_with_vec_by(v, scratch_buf, |a, b| f(a).cmp(&f(b))) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:108:55 [INFO] [stdout] | [INFO] [stdout] 108 | sort_with_vec_by(v, scratch_buf, |a, b| f(a).cmp(&f(b))) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:160:43 [INFO] [stdout] | [INFO] [stdout] 160 | sort_with_buffer_by(v, buffer, |a, b| f(a).cmp(&f(b))) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:160:53 [INFO] [stdout] | [INFO] [stdout] 160 | sort_with_buffer_by(v, buffer, |a, b| f(a).cmp(&f(b))) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:199:30 [INFO] [stdout] | [INFO] [stdout] 199 | sort_in_vec_by(v, |a, b| f(a).cmp(&f(b))) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:199:40 [INFO] [stdout] | [INFO] [stdout] 199 | sort_in_vec_by(v, |a, b| f(a).cmp(&f(b))) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mut_slice.rs:403:62 [INFO] [stdout] | [INFO] [stdout] 398 | pub fn with_stack_scratch(name: &'static str, f: F) -> R [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 403 | MutSlice::from_maybeuninit_mut_slice(&mut scratch_space, |scratch| { [INFO] [stdout] | ______________________________________________________________^ [INFO] [stdout] 404 | | tracking::register_buffer(name, scratch.weak()); [INFO] [stdout] 405 | | let ret = f(scratch.assume_uninit()); [INFO] [stdout] 406 | | tracking::deregister_buffer(name); [INFO] [stdout] 407 | | ret [INFO] [stdout] 408 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `glidesort` (lib test) due to 12 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:82:30 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn sort_by_key K, K: Ord>(v: &mut [T], mut f: F) { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | sort_with_vec_by(v, &mut Vec::new(), |a, b| f(a).cmp(&f(b))) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:82:49 [INFO] [stdout] | [INFO] [stdout] 82 | sort_with_vec_by(v, &mut Vec::new(), |a, b| f(a).cmp(&f(b))) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:82:59 [INFO] [stdout] | [INFO] [stdout] 82 | sort_with_vec_by(v, &mut Vec::new(), |a, b| f(a).cmp(&f(b))) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:90:30 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn sort_by(v: &mut [T], compare: F) [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | sort_with_vec_by(v, &mut Vec::new(), compare) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:108:45 [INFO] [stdout] | [INFO] [stdout] 108 | sort_with_vec_by(v, scratch_buf, |a, b| f(a).cmp(&f(b))) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:108:55 [INFO] [stdout] | [INFO] [stdout] 108 | sort_with_vec_by(v, scratch_buf, |a, b| f(a).cmp(&f(b))) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:160:43 [INFO] [stdout] | [INFO] [stdout] 160 | sort_with_buffer_by(v, buffer, |a, b| f(a).cmp(&f(b))) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:160:53 [INFO] [stdout] | [INFO] [stdout] 160 | sort_with_buffer_by(v, buffer, |a, b| f(a).cmp(&f(b))) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:199:30 [INFO] [stdout] | [INFO] [stdout] 199 | sort_in_vec_by(v, |a, b| f(a).cmp(&f(b))) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:199:40 [INFO] [stdout] | [INFO] [stdout] 199 | sort_in_vec_by(v, |a, b| f(a).cmp(&f(b))) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mut_slice.rs:403:62 [INFO] [stdout] | [INFO] [stdout] 398 | pub fn with_stack_scratch(name: &'static str, f: F) -> R [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 403 | MutSlice::from_maybeuninit_mut_slice(&mut scratch_space, |scratch| { [INFO] [stdout] | ______________________________________________________________^ [INFO] [stdout] 404 | | tracking::register_buffer(name, scratch.weak()); [INFO] [stdout] 405 | | let ret = f(scratch.assume_uninit()); [INFO] [stdout] 406 | | tracking::deregister_buffer(name); [INFO] [stdout] 407 | | ret [INFO] [stdout] 408 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `glidesort` (lib) due to 12 previous errors [INFO] running `Command { std: "docker" "inspect" "4334530c0accd59fba7d7d4300d6ed1e6c490e5790cc8f2db31f83908d9a78b1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4334530c0accd59fba7d7d4300d6ed1e6c490e5790cc8f2db31f83908d9a78b1", kill_on_drop: false }` [INFO] [stdout] 4334530c0accd59fba7d7d4300d6ed1e6c490e5790cc8f2db31f83908d9a78b1