[INFO] fetching crate gix-worktree-stream 0.15.0... [INFO] checking gix-worktree-stream-0.15.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate gix-worktree-stream 0.15.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate gix-worktree-stream 0.15.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gix-worktree-stream 0.15.0 [INFO] finished tweaking crates.io crate gix-worktree-stream 0.15.0 [INFO] tweaked toml for crates.io crate gix-worktree-stream 0.15.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 76 packages to latest compatible versions [INFO] [stderr] Adding prodash v28.0.0 (latest: v29.0.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 211465bd5dc931ca5e1a3a50084121294b1c175d1a332698ea303b9f1341f01c [INFO] running `Command { std: "docker" "start" "-a" "211465bd5dc931ca5e1a3a50084121294b1c175d1a332698ea303b9f1341f01c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "211465bd5dc931ca5e1a3a50084121294b1c175d1a332698ea303b9f1341f01c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "211465bd5dc931ca5e1a3a50084121294b1c175d1a332698ea303b9f1341f01c", kill_on_drop: false }` [INFO] [stdout] 211465bd5dc931ca5e1a3a50084121294b1c175d1a332698ea303b9f1341f01c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] df5777e8646bd011431330d5165440b9532efde2a6cd554cad14f1c108d07998 [INFO] running `Command { std: "docker" "start" "-a" "df5777e8646bd011431330d5165440b9532efde2a6cd554cad14f1c108d07998", kill_on_drop: false }` [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking faster-hex v0.9.0 [INFO] [stderr] Checking gix-trace v0.1.9 [INFO] [stderr] Checking sha1_smol v1.0.1 [INFO] [stderr] Checking prodash v28.0.0 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking jiff v0.1.12 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking memmap2 v0.9.4 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking unicode-bom v2.0.3 [INFO] [stderr] Checking kstring v2.0.2 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Checking encoding_rs v0.8.34 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Checking gix-utils v0.1.12 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking gix-hash v0.14.2 [INFO] [stderr] Checking gix-validate v0.9.0 [INFO] [stderr] Checking gix-path v0.10.10 [INFO] [stderr] Checking gix-chunk v0.4.8 [INFO] [stderr] Checking gix-quote v0.4.12 [INFO] [stderr] Checking gix-packetline-blocking v0.17.5 [INFO] [stderr] Checking gix-command v0.3.9 [INFO] [stderr] Checking gix-features v0.38.2 [INFO] [stderr] Checking gix-hashtable v0.5.2 [INFO] [stderr] Checking gix-date v0.9.0 [INFO] [stderr] Checking gix-commitgraph v0.24.3 [INFO] [stderr] Checking gix-glob v0.16.5 [INFO] [stderr] Checking gix-fs v0.11.3 [INFO] [stderr] Checking gix-actor v0.32.0 [INFO] [stderr] Checking gix-object v0.44.0 [INFO] [stderr] Checking gix-attributes v0.22.5 [INFO] [stderr] Checking gix-revwalk v0.15.0 [INFO] [stderr] Checking gix-filter v0.13.0 [INFO] [stderr] Checking gix-traverse v0.41.0 [INFO] [stderr] Checking gix-worktree-stream v0.15.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:98:19 [INFO] [stdout] | [INFO] [stdout] 96 | pub fn from_read(read: impl std::io::Read + 'static) -> Self { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | Self { [INFO] [stdout] 98 | read: utils::Read::Unknown(Box::new(read)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:99:28 [INFO] [stdout] | [INFO] [stdout] 96 | pub fn from_read(read: impl std::io::Read + 'static) -> Self { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | extra_entries: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:101:18 [INFO] [stdout] | [INFO] [stdout] 96 | pub fn from_read(read: impl std::io::Read + 'static) -> Self { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | err: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:184:13 [INFO] [stdout] | [INFO] [stdout] 181 | let (write, read) = gix_features::io::pipe::unidirectional(in_flight_writes); [INFO] [stdout] | ----- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | let (tx_entries, rx_entries) = std::sync::mpsc::channel(); [INFO] [stdout] | ---------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | ( [INFO] [stdout] 184 | / Stream { [INFO] [stdout] 185 | | read: utils::Read::Known(read), [INFO] [stdout] 186 | | extra_entries: Some(tx_entries), [INFO] [stdout] 187 | | path_buf: Some(Vec::with_capacity(1024).into()), [INFO] [stdout] ... | [INFO] [stdout] 191 | | filled: 0, [INFO] [stdout] 192 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_tree/mod.rs:108:13 [INFO] [stdout] | [INFO] [stdout] 82 | mut attributes: impl FnMut(&BStr, gix_object::tree::EntryMode, &mut gix_attributes::search::Outcome) -> Result<(), E> [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | attributes(a, b, c).map_err(|err| Error::Attributes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_tree/mod.rs:109:25 [INFO] [stdout] | [INFO] [stdout] 108 | attributes(a, b, c).map_err(|err| Error::Attributes { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | source: Box::new(err), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gix-worktree-stream` (lib test) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:98:19 [INFO] [stdout] | [INFO] [stdout] 96 | pub fn from_read(read: impl std::io::Read + 'static) -> Self { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | Self { [INFO] [stdout] 98 | read: utils::Read::Unknown(Box::new(read)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:99:28 [INFO] [stdout] | [INFO] [stdout] 96 | pub fn from_read(read: impl std::io::Read + 'static) -> Self { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | extra_entries: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:101:18 [INFO] [stdout] | [INFO] [stdout] 96 | pub fn from_read(read: impl std::io::Read + 'static) -> Self { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | err: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:184:13 [INFO] [stdout] | [INFO] [stdout] 181 | let (write, read) = gix_features::io::pipe::unidirectional(in_flight_writes); [INFO] [stdout] | ----- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | let (tx_entries, rx_entries) = std::sync::mpsc::channel(); [INFO] [stdout] | ---------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | ( [INFO] [stdout] 184 | / Stream { [INFO] [stdout] 185 | | read: utils::Read::Known(read), [INFO] [stdout] 186 | | extra_entries: Some(tx_entries), [INFO] [stdout] 187 | | path_buf: Some(Vec::with_capacity(1024).into()), [INFO] [stdout] ... | [INFO] [stdout] 191 | | filled: 0, [INFO] [stdout] 192 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_tree/mod.rs:108:13 [INFO] [stdout] | [INFO] [stdout] 82 | mut attributes: impl FnMut(&BStr, gix_object::tree::EntryMode, &mut gix_attributes::search::Outcome) -> Result<(), E> [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | attributes(a, b, c).map_err(|err| Error::Attributes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_tree/mod.rs:109:25 [INFO] [stdout] | [INFO] [stdout] 108 | attributes(a, b, c).map_err(|err| Error::Attributes { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | source: Box::new(err), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gix-worktree-stream` (lib) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "df5777e8646bd011431330d5165440b9532efde2a6cd554cad14f1c108d07998", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "df5777e8646bd011431330d5165440b9532efde2a6cd554cad14f1c108d07998", kill_on_drop: false }` [INFO] [stdout] df5777e8646bd011431330d5165440b9532efde2a6cd554cad14f1c108d07998