[INFO] fetching crate gix-worktree-state 0.13.0... [INFO] checking gix-worktree-state-0.13.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate gix-worktree-state 0.13.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate gix-worktree-state 0.13.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gix-worktree-state 0.13.0 [INFO] finished tweaking crates.io crate gix-worktree-state 0.13.0 [INFO] tweaked toml for crates.io crate gix-worktree-state 0.13.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 97 packages to latest compatible versions [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding prodash v28.0.0 (latest: v29.0.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c3ab1def145bdad85cde369f987fbbc1d0f0b38af14107c11300890f46abf951 [INFO] running `Command { std: "docker" "start" "-a" "c3ab1def145bdad85cde369f987fbbc1d0f0b38af14107c11300890f46abf951", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c3ab1def145bdad85cde369f987fbbc1d0f0b38af14107c11300890f46abf951", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c3ab1def145bdad85cde369f987fbbc1d0f0b38af14107c11300890f46abf951", kill_on_drop: false }` [INFO] [stdout] c3ab1def145bdad85cde369f987fbbc1d0f0b38af14107c11300890f46abf951 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e22289c535d8de2c6d4a252f9d816b2e1901c8364d04feb22d02cba43ee0260e [INFO] running `Command { std: "docker" "start" "-a" "e22289c535d8de2c6d4a252f9d816b2e1901c8364d04feb22d02cba43ee0260e", kill_on_drop: false }` [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking gix-trace v0.1.9 [INFO] [stderr] Checking faster-hex v0.9.0 [INFO] [stderr] Checking sha1_smol v1.0.1 [INFO] [stderr] Checking prodash v28.0.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking jiff v0.1.12 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Checking memmap2 v0.9.4 [INFO] [stderr] Checking unicode-bom v2.0.3 [INFO] [stderr] Checking kstring v2.0.2 [INFO] [stderr] Checking filetime v0.2.25 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Checking encoding_rs v0.8.34 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking io-close v0.3.7 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking gix-utils v0.1.12 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking gix-hash v0.14.2 [INFO] [stderr] Checking gix-chunk v0.4.8 [INFO] [stderr] Checking gix-bitmap v0.2.11 [INFO] [stderr] Checking gix-validate v0.9.0 [INFO] [stderr] Checking gix-path v0.10.10 [INFO] [stderr] Checking gix-quote v0.4.12 [INFO] [stderr] Checking gix-packetline-blocking v0.17.5 [INFO] [stderr] Checking gix-features v0.38.2 [INFO] [stderr] Checking gix-hashtable v0.5.2 [INFO] [stderr] Checking gix-command v0.3.9 [INFO] [stderr] Checking gix-glob v0.16.5 [INFO] [stderr] Checking gix-commitgraph v0.24.3 [INFO] [stderr] Checking gix-fs v0.11.3 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking gix-attributes v0.22.5 [INFO] [stderr] Checking gix-ignore v0.11.4 [INFO] [stderr] Checking gix-tempfile v14.0.2 [INFO] [stderr] Checking gix-lock v14.0.0 [INFO] [stderr] Checking gix-date v0.9.0 [INFO] [stderr] Checking gix-actor v0.32.0 [INFO] [stderr] Checking gix-object v0.44.0 [INFO] [stderr] Checking gix-revwalk v0.15.0 [INFO] [stderr] Checking gix-filter v0.13.0 [INFO] [stderr] Checking gix-traverse v0.41.0 [INFO] [stderr] Checking gix-index v0.35.0 [INFO] [stderr] Checking gix-worktree v0.36.0 [INFO] [stderr] Checking gix-worktree-state v0.13.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/checkout/chunk.rs:146:8 [INFO] [stdout] | [INFO] [stdout] 103 | entries_with_paths: impl Iterator, [INFO] [stdout] | -------------------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | let mut errors = Vec::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | Ok(Outcome { [INFO] [stdout] | ________^ [INFO] [stdout] 147 | | bytes_written, [INFO] [stdout] 148 | | files: files_in_chunk, [INFO] [stdout] 149 | | errors, [INFO] [stdout] ... | [INFO] [stdout] 153 | | delayed_paths_unprocessed: Vec::new(), [INFO] [stdout] 154 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/checkout/function.rs:146:8 [INFO] [stdout] | [INFO] [stdout] 41 | dir: impl Into, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | objects: Find, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | mut options: crate::checkout::Options, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | let num_files = files.counter(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let num_bytes = bytes.counter(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | let mut ctx = chunk::Context { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | mut errors, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | let entries_with_paths = interrupt::Iter::new(index.entries_mut_with_paths_in(paths), should_interrupt); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | let mut delayed_filter_results = Vec::new(); [INFO] [stdout] 90 | let mut out = chunk::process( [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | let entries_with_paths = interrupt::Iter::new(index.entries_mut_with_paths_in(paths), should_interrupt); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | let ctx = ctx.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | Ok(crate::checkout::Outcome { [INFO] [stdout] | ________^ [INFO] [stdout] 147 | | files_updated, [INFO] [stdout] 148 | | collisions, [INFO] [stdout] 149 | | errors, [INFO] [stdout] ... | [INFO] [stdout] 152 | | delayed_paths_unprocessed, [INFO] [stdout] 153 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gix-worktree-state` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/checkout/chunk.rs:146:8 [INFO] [stdout] | [INFO] [stdout] 103 | entries_with_paths: impl Iterator, [INFO] [stdout] | -------------------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | let mut errors = Vec::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | Ok(Outcome { [INFO] [stdout] | ________^ [INFO] [stdout] 147 | | bytes_written, [INFO] [stdout] 148 | | files: files_in_chunk, [INFO] [stdout] 149 | | errors, [INFO] [stdout] ... | [INFO] [stdout] 153 | | delayed_paths_unprocessed: Vec::new(), [INFO] [stdout] 154 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/checkout/function.rs:146:8 [INFO] [stdout] | [INFO] [stdout] 41 | dir: impl Into, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | objects: Find, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | mut options: crate::checkout::Options, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | let num_files = files.counter(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let num_bytes = bytes.counter(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | let mut ctx = chunk::Context { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | mut errors, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | let entries_with_paths = interrupt::Iter::new(index.entries_mut_with_paths_in(paths), should_interrupt); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | let mut delayed_filter_results = Vec::new(); [INFO] [stdout] 90 | let mut out = chunk::process( [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | let entries_with_paths = interrupt::Iter::new(index.entries_mut_with_paths_in(paths), should_interrupt); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | let ctx = ctx.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | Ok(crate::checkout::Outcome { [INFO] [stdout] | ________^ [INFO] [stdout] 147 | | files_updated, [INFO] [stdout] 148 | | collisions, [INFO] [stdout] 149 | | errors, [INFO] [stdout] ... | [INFO] [stdout] 152 | | delayed_paths_unprocessed, [INFO] [stdout] 153 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gix-worktree-state` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "e22289c535d8de2c6d4a252f9d816b2e1901c8364d04feb22d02cba43ee0260e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e22289c535d8de2c6d4a252f9d816b2e1901c8364d04feb22d02cba43ee0260e", kill_on_drop: false }` [INFO] [stdout] e22289c535d8de2c6d4a252f9d816b2e1901c8364d04feb22d02cba43ee0260e