[INFO] fetching crate gix-traverse 0.41.0... [INFO] checking gix-traverse-0.41.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate gix-traverse 0.41.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate gix-traverse 0.41.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gix-traverse 0.41.0 [INFO] finished tweaking crates.io crate gix-traverse 0.41.0 [INFO] tweaked toml for crates.io crate gix-traverse 0.41.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 58 packages to latest compatible versions [INFO] [stderr] Adding prodash v28.0.0 (latest: v29.0.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 599629ce04de58f34efc6431d12baba87092d78efedf8105bc2fa8b20f38cf61 [INFO] running `Command { std: "docker" "start" "-a" "599629ce04de58f34efc6431d12baba87092d78efedf8105bc2fa8b20f38cf61", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "599629ce04de58f34efc6431d12baba87092d78efedf8105bc2fa8b20f38cf61", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "599629ce04de58f34efc6431d12baba87092d78efedf8105bc2fa8b20f38cf61", kill_on_drop: false }` [INFO] [stdout] 599629ce04de58f34efc6431d12baba87092d78efedf8105bc2fa8b20f38cf61 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 84eeaf8ee7936b5f85803ec25bcac071dc935e5c412d9bed21b49a63c0cab9e0 [INFO] running `Command { std: "docker" "start" "-a" "84eeaf8ee7936b5f85803ec25bcac071dc935e5c412d9bed21b49a63c0cab9e0", kill_on_drop: false }` [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking faster-hex v0.9.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking sha1_smol v1.0.1 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking jiff v0.1.12 [INFO] [stderr] Checking prodash v28.0.0 [INFO] [stderr] Checking gix-trace v0.1.9 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Checking memmap2 v0.9.4 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking gix-utils v0.1.12 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Checking gix-hash v0.14.2 [INFO] [stderr] Checking gix-chunk v0.4.8 [INFO] [stderr] Checking gix-features v0.38.2 [INFO] [stderr] Checking gix-hashtable v0.5.2 [INFO] [stderr] Checking gix-validate v0.9.0 [INFO] [stderr] Checking gix-commitgraph v0.24.3 [INFO] [stderr] Checking gix-date v0.9.0 [INFO] [stderr] Checking gix-actor v0.32.0 [INFO] [stderr] Checking gix-object v0.44.0 [INFO] [stderr] Checking gix-revwalk v0.15.0 [INFO] [stderr] Checking gix-traverse v0.41.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commit/simple.rs:223:24 [INFO] [stdout] | [INFO] [stdout] 205 | tips: impl IntoIterator>, [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | find: Find, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | mut predicate: Predicate, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 208 | ) -> Self { [INFO] [stdout] 209 | let tips = tips.into_iter(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 210 | let mut state = State::default(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 223 | cache: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commit/simple.rs:223:24 [INFO] [stdout] | [INFO] [stdout] 205 | tips: impl IntoIterator>, [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | find: Find, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | mut predicate: Predicate, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 208 | ) -> Self { [INFO] [stdout] 209 | let tips = tips.into_iter(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 210 | let mut state = State::default(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 223 | cache: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commit/simple.rs:339:18 [INFO] [stdout] | [INFO] [stdout] 290 | let mut parents: ParentIds = Default::default(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 339 | Some(Ok(Info { [INFO] [stdout] | __________________^ [INFO] [stdout] 340 | | id: oid, [INFO] [stdout] 341 | | parent_ids: parents, [INFO] [stdout] 342 | | commit_time: Some(commit_time), [INFO] [stdout] 343 | | })) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commit/simple.rs:397:18 [INFO] [stdout] | [INFO] [stdout] 356 | let mut parents: ParentIds = Default::default(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 397 | Some(Ok(Info { [INFO] [stdout] | __________________^ [INFO] [stdout] 398 | | id: oid, [INFO] [stdout] 399 | | parent_ids: parents, [INFO] [stdout] 400 | | commit_time: None, [INFO] [stdout] 401 | | })) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commit/simple.rs:339:18 [INFO] [stdout] | [INFO] [stdout] 290 | let mut parents: ParentIds = Default::default(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 339 | Some(Ok(Info { [INFO] [stdout] | __________________^ [INFO] [stdout] 340 | | id: oid, [INFO] [stdout] 341 | | parent_ids: parents, [INFO] [stdout] 342 | | commit_time: Some(commit_time), [INFO] [stdout] 343 | | })) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commit/topo/init.rs:37:27 [INFO] [stdout] | [INFO] [stdout] 27 | find: Find, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | tips: impl IntoIterator>, [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | ends: Option>>, [INFO] [stdout] | ----------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | commit_graph: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commit/simple.rs:397:18 [INFO] [stdout] | [INFO] [stdout] 356 | let mut parents: ParentIds = Default::default(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 397 | Some(Ok(Info { [INFO] [stdout] | __________________^ [INFO] [stdout] 398 | | id: oid, [INFO] [stdout] 399 | | parent_ids: parents, [INFO] [stdout] 400 | | commit_time: None, [INFO] [stdout] 401 | | })) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commit/topo/init.rs:37:27 [INFO] [stdout] | [INFO] [stdout] 27 | find: Find, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | tips: impl IntoIterator>, [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | ends: Option>>, [INFO] [stdout] | ----------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | commit_graph: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commit/topo/init.rs:33:22 [INFO] [stdout] | [INFO] [stdout] 33 | .map(|e| e.into_iter().map(Into::into).collect::>()) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commit/topo/iter.rs:213:14 [INFO] [stdout] | [INFO] [stdout] 200 | let commit = self.topo_queue.pop()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | Some(Ok(commit)) [INFO] [stdout] | ^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commit/topo/init.rs:33:22 [INFO] [stdout] | [INFO] [stdout] 33 | .map(|e| e.into_iter().map(Into::into).collect::>()) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commit/topo/iter.rs:213:14 [INFO] [stdout] | [INFO] [stdout] 200 | let commit = self.topo_queue.pop()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | Some(Ok(commit)) [INFO] [stdout] | ^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gix-traverse` (lib test) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `gix-traverse` (lib) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "84eeaf8ee7936b5f85803ec25bcac071dc935e5c412d9bed21b49a63c0cab9e0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "84eeaf8ee7936b5f85803ec25bcac071dc935e5c412d9bed21b49a63c0cab9e0", kill_on_drop: false }` [INFO] [stdout] 84eeaf8ee7936b5f85803ec25bcac071dc935e5c412d9bed21b49a63c0cab9e0