[INFO] fetching crate gix-tempfile 14.0.2... [INFO] checking gix-tempfile-14.0.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate gix-tempfile 14.0.2 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate gix-tempfile 14.0.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gix-tempfile 14.0.2 [INFO] finished tweaking crates.io crate gix-tempfile 14.0.2 [INFO] tweaked toml for crates.io crate gix-tempfile 14.0.2 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate gix-tempfile 14.0.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f35746704a0cd3e9651b1f26c0707692f9b8d37545edf6aec098c629a0015fce [INFO] running `Command { std: "docker" "start" "-a" "f35746704a0cd3e9651b1f26c0707692f9b8d37545edf6aec098c629a0015fce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f35746704a0cd3e9651b1f26c0707692f9b8d37545edf6aec098c629a0015fce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f35746704a0cd3e9651b1f26c0707692f9b8d37545edf6aec098c629a0015fce", kill_on_drop: false }` [INFO] [stdout] f35746704a0cd3e9651b1f26c0707692f9b8d37545edf6aec098c629a0015fce [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bff8bc6ae1338505628a0ec24d19d3392944bf585005f667b96bc47baf0ef905 [INFO] running `Command { std: "docker" "start" "-a" "bff8bc6ae1338505628a0ec24d19d3392944bf585005f667b96bc47baf0ef905", kill_on_drop: false }` [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking faster-hex v0.9.0 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking gix-trace v0.1.9 [INFO] [stderr] Checking dashmap v6.0.1 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking gix-utils v0.1.12 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking gix-hash v0.14.2 [INFO] [stderr] Checking gix-features v0.38.2 [INFO] [stderr] Checking gix-fs v0.11.3 [INFO] [stderr] Checking gix-tempfile v14.0.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/forksafe.rs:22:20 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn new(tempfile: NamedTempFile, cleanup: AutoRemove, mode: handle::Mode) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | inner: match mode { [INFO] [stdout] | ____________________^ [INFO] [stdout] 23 | | Closed => TempfileOrTemppath::Temppath(tempfile.into_temp_path()), [INFO] [stdout] 24 | | Writable => TempfileOrTemppath::Tempfile(tempfile), [INFO] [stdout] 25 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:88:12 [INFO] [stdout] | [INFO] [stdout] 87 | pub fn at(path: impl AsRef, directory: ContainingDirectory, cleanup: AutoRemove) -> io::Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | Ok(Handle { [INFO] [stdout] | ____________^ [INFO] [stdout] 89 | | id: Handle::<()>::at_path(path.as_ref(), directory, cleanup, Mode::Closed, None)?, [INFO] [stdout] 90 | | _marker: Default::default(), [INFO] [stdout] 91 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:101:12 [INFO] [stdout] | [INFO] [stdout] 96 | path: impl AsRef, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | Ok(Handle { [INFO] [stdout] | ____________^ [INFO] [stdout] 102 | | id: Handle::<()>::at_path(path.as_ref(), directory, cleanup, Mode::Closed, Some(permissions))?, [INFO] [stdout] 103 | | _marker: Default::default(), [INFO] [stdout] 104 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:129:12 [INFO] [stdout] | [INFO] [stdout] 128 | pub fn at(path: impl AsRef, directory: ContainingDirectory, cleanup: AutoRemove) -> io::Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | Ok(Handle { [INFO] [stdout] | ____________^ [INFO] [stdout] 130 | | id: Handle::<()>::at_path(path.as_ref(), directory, cleanup, Mode::Writable, None)?, [INFO] [stdout] 131 | | _marker: Default::default(), [INFO] [stdout] 132 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:142:12 [INFO] [stdout] | [INFO] [stdout] 137 | path: impl AsRef, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 142 | Ok(Handle { [INFO] [stdout] | ____________^ [INFO] [stdout] 143 | | id: Handle::<()>::at_path(path.as_ref(), directory, cleanup, Mode::Writable, Some(permissions))?, [INFO] [stdout] 144 | | _marker: Default::default(), [INFO] [stdout] 145 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:161:12 [INFO] [stdout] | [INFO] [stdout] 157 | containing_directory: impl AsRef, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | Ok(Handle { [INFO] [stdout] | ____________^ [INFO] [stdout] 162 | | id: Handle::<()>::new_writable_inner(containing_directory.as_ref(), directory, cleanup, Mode::Writable)?, [INFO] [stdout] 163 | | _marker: Default::default(), [INFO] [stdout] 164 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:173:42 [INFO] [stdout] | [INFO] [stdout] 173 | res.and_then(|(_k, v)| v.map(|v| v.into_tempfile().expect("correct runtime typing"))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:182:15 [INFO] [stdout] | [INFO] [stdout] 181 | pub fn close(self) -> std::io::Result> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | match REGISTRY.remove(&self.id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:210:15 [INFO] [stdout] | [INFO] [stdout] 209 | pub fn with_mut(&mut self, once: impl FnOnce(&mut NamedTempFile) -> T) -> std::io::Result { [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 210 | match REGISTRY.remove(&self.id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:298:19 [INFO] [stdout] | [INFO] [stdout] 295 | pub fn persist(self, path: impl AsRef) -> Result, Error> { [INFO] [stdout] | ---- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 296 | let res = REGISTRY.remove(&self.id); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 297 | [INFO] [stdout] 298 | match res.and_then(|(_k, v)| v.map(|v| v.persist(path))) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:298:48 [INFO] [stdout] | [INFO] [stdout] 295 | pub fn persist(self, path: impl AsRef) -> Result, Error> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 298 | match res.and_then(|(_k, v)| v.map(|v| v.persist(path))) { [INFO] [stdout] | ------- ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:325:19 [INFO] [stdout] | [INFO] [stdout] 322 | pub fn persist(self, path: impl AsRef) -> Result<(), Error> { [INFO] [stdout] | ---- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 323 | let res = REGISTRY.remove(&self.id); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 324 | [INFO] [stdout] 325 | match res.and_then(|(_k, v)| v.map(|v| v.persist(path))) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:325:48 [INFO] [stdout] | [INFO] [stdout] 322 | pub fn persist(self, path: impl AsRef) -> Result<(), Error> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 325 | match res.and_then(|(_k, v)| v.map(|v| v.persist(path))) { [INFO] [stdout] | ------- ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gix-tempfile` (lib) due to 14 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/forksafe.rs:22:20 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn new(tempfile: NamedTempFile, cleanup: AutoRemove, mode: handle::Mode) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | inner: match mode { [INFO] [stdout] | ____________________^ [INFO] [stdout] 23 | | Closed => TempfileOrTemppath::Temppath(tempfile.into_temp_path()), [INFO] [stdout] 24 | | Writable => TempfileOrTemppath::Tempfile(tempfile), [INFO] [stdout] 25 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:88:12 [INFO] [stdout] | [INFO] [stdout] 87 | pub fn at(path: impl AsRef, directory: ContainingDirectory, cleanup: AutoRemove) -> io::Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | Ok(Handle { [INFO] [stdout] | ____________^ [INFO] [stdout] 89 | | id: Handle::<()>::at_path(path.as_ref(), directory, cleanup, Mode::Closed, None)?, [INFO] [stdout] 90 | | _marker: Default::default(), [INFO] [stdout] 91 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:101:12 [INFO] [stdout] | [INFO] [stdout] 96 | path: impl AsRef, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | Ok(Handle { [INFO] [stdout] | ____________^ [INFO] [stdout] 102 | | id: Handle::<()>::at_path(path.as_ref(), directory, cleanup, Mode::Closed, Some(permissions))?, [INFO] [stdout] 103 | | _marker: Default::default(), [INFO] [stdout] 104 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:129:12 [INFO] [stdout] | [INFO] [stdout] 128 | pub fn at(path: impl AsRef, directory: ContainingDirectory, cleanup: AutoRemove) -> io::Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | Ok(Handle { [INFO] [stdout] | ____________^ [INFO] [stdout] 130 | | id: Handle::<()>::at_path(path.as_ref(), directory, cleanup, Mode::Writable, None)?, [INFO] [stdout] 131 | | _marker: Default::default(), [INFO] [stdout] 132 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:142:12 [INFO] [stdout] | [INFO] [stdout] 137 | path: impl AsRef, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 142 | Ok(Handle { [INFO] [stdout] | ____________^ [INFO] [stdout] 143 | | id: Handle::<()>::at_path(path.as_ref(), directory, cleanup, Mode::Writable, Some(permissions))?, [INFO] [stdout] 144 | | _marker: Default::default(), [INFO] [stdout] 145 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:161:12 [INFO] [stdout] | [INFO] [stdout] 157 | containing_directory: impl AsRef, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | Ok(Handle { [INFO] [stdout] | ____________^ [INFO] [stdout] 162 | | id: Handle::<()>::new_writable_inner(containing_directory.as_ref(), directory, cleanup, Mode::Writable)?, [INFO] [stdout] 163 | | _marker: Default::default(), [INFO] [stdout] 164 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:173:42 [INFO] [stdout] | [INFO] [stdout] 173 | res.and_then(|(_k, v)| v.map(|v| v.into_tempfile().expect("correct runtime typing"))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:182:15 [INFO] [stdout] | [INFO] [stdout] 181 | pub fn close(self) -> std::io::Result> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | match REGISTRY.remove(&self.id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:210:15 [INFO] [stdout] | [INFO] [stdout] 209 | pub fn with_mut(&mut self, once: impl FnOnce(&mut NamedTempFile) -> T) -> std::io::Result { [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 210 | match REGISTRY.remove(&self.id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:298:19 [INFO] [stdout] | [INFO] [stdout] 295 | pub fn persist(self, path: impl AsRef) -> Result, Error> { [INFO] [stdout] | ---- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 296 | let res = REGISTRY.remove(&self.id); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 297 | [INFO] [stdout] 298 | match res.and_then(|(_k, v)| v.map(|v| v.persist(path))) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:298:48 [INFO] [stdout] | [INFO] [stdout] 295 | pub fn persist(self, path: impl AsRef) -> Result, Error> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 298 | match res.and_then(|(_k, v)| v.map(|v| v.persist(path))) { [INFO] [stdout] | ------- ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:325:19 [INFO] [stdout] | [INFO] [stdout] 322 | pub fn persist(self, path: impl AsRef) -> Result<(), Error> { [INFO] [stdout] | ---- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 323 | let res = REGISTRY.remove(&self.id); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 324 | [INFO] [stdout] 325 | match res.and_then(|(_k, v)| v.map(|v| v.persist(path))) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:325:48 [INFO] [stdout] | [INFO] [stdout] 322 | pub fn persist(self, path: impl AsRef) -> Result<(), Error> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 325 | match res.and_then(|(_k, v)| v.map(|v| v.persist(path))) { [INFO] [stdout] | ------- ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gix-tempfile` (lib test) due to 14 previous errors [INFO] running `Command { std: "docker" "inspect" "bff8bc6ae1338505628a0ec24d19d3392944bf585005f667b96bc47baf0ef905", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bff8bc6ae1338505628a0ec24d19d3392944bf585005f667b96bc47baf0ef905", kill_on_drop: false }` [INFO] [stdout] bff8bc6ae1338505628a0ec24d19d3392944bf585005f667b96bc47baf0ef905