[INFO] fetching crate gix-submodule 0.14.0... [INFO] checking gix-submodule-0.14.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate gix-submodule 0.14.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate gix-submodule 0.14.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gix-submodule 0.14.0 [INFO] finished tweaking crates.io crate gix-submodule 0.14.0 [INFO] tweaked toml for crates.io crate gix-submodule 0.14.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 91 packages to latest compatible versions [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding prodash v28.0.0 (latest: v29.0.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 484376b2c91ce1ed693ea3dbdbde4df375423512c4a740f764755d792cba8dd0 [INFO] running `Command { std: "docker" "start" "-a" "484376b2c91ce1ed693ea3dbdbde4df375423512c4a740f764755d792cba8dd0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "484376b2c91ce1ed693ea3dbdbde4df375423512c4a740f764755d792cba8dd0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "484376b2c91ce1ed693ea3dbdbde4df375423512c4a740f764755d792cba8dd0", kill_on_drop: false }` [INFO] [stdout] 484376b2c91ce1ed693ea3dbdbde4df375423512c4a740f764755d792cba8dd0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c728e1bcf263d3c6d9a0730b2d34c9ed4a13eb6f5dd06d9213799fb5429dc266 [INFO] running `Command { std: "docker" "start" "-a" "c728e1bcf263d3c6d9a0730b2d34c9ed4a13eb6f5dd06d9213799fb5429dc266", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking gix-trace v0.1.9 [INFO] [stderr] Checking faster-hex v0.9.0 [INFO] [stderr] Checking prodash v28.0.0 [INFO] [stderr] Checking sha1_smol v1.0.1 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking jiff v0.1.12 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking memmap2 v0.9.4 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking unicode-bom v2.0.3 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking kstring v2.0.2 [INFO] [stderr] Checking gix-sec v0.10.8 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Checking gix-utils v0.1.12 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking gix-hash v0.14.2 [INFO] [stderr] Checking gix-path v0.10.10 [INFO] [stderr] Checking gix-date v0.9.0 [INFO] [stderr] Checking gix-validate v0.9.0 [INFO] [stderr] Checking gix-chunk v0.4.8 [INFO] [stderr] Checking gix-quote v0.4.12 [INFO] [stderr] Checking gix-config-value v0.14.8 [INFO] [stderr] Checking gix-features v0.38.2 [INFO] [stderr] Checking gix-actor v0.32.0 [INFO] [stderr] Checking gix-hashtable v0.5.2 [INFO] [stderr] Checking gix-fs v0.11.3 [INFO] [stderr] Checking gix-commitgraph v0.24.3 [INFO] [stderr] Checking gix-glob v0.16.5 [INFO] [stderr] Checking gix-url v0.27.5 [INFO] [stderr] Checking gix-object v0.44.0 [INFO] [stderr] Checking gix-tempfile v14.0.2 [INFO] [stderr] Checking gix-attributes v0.22.5 [INFO] [stderr] Checking gix-lock v14.0.0 [INFO] [stderr] Checking gix-pathspec v0.7.7 [INFO] [stderr] Checking gix-revwalk v0.15.0 [INFO] [stderr] Checking gix-ref v0.47.0 [INFO] [stderr] Checking gix-revision v0.29.0 [INFO] [stderr] Checking gix-refspec v0.25.0 [INFO] [stderr] Checking gix-config v0.40.0 [INFO] [stderr] Checking gix-submodule v0.14.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/access.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 33 | let mut seen = HashSet::<&BStr>::default(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | / self.config [INFO] [stdout] 35 | | .sections_by_name("submodule") [INFO] [stdout] 36 | | .into_iter() [INFO] [stdout] 37 | | .flatten() [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/access.rs:38:25 [INFO] [stdout] | [INFO] [stdout] 33 | let mut seen = HashSet::<&BStr>::default(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | .filter_map(move |s| { [INFO] [stdout] | _________________________^ [INFO] [stdout] 39 | | s.header() [INFO] [stdout] 40 | | .subsection_name() [INFO] [stdout] 41 | | .filter(|_| s.meta().source == crate::init::META_MARKER) [INFO] [stdout] 42 | | .filter(|name| seen.insert(*name)) [INFO] [stdout] 43 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/access.rs:94:12 [INFO] [stdout] | [INFO] [stdout] 80 | let search = config [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | Ok(IsActivePlatform { search }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/access.rs:87:20 [INFO] [stdout] | [INFO] [stdout] 83 | let patterns = patterns [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | Ok(gix_pathspec::Search::from_specs( [INFO] [stdout] | ____________________^ [INFO] [stdout] 88 | | patterns, [INFO] [stdout] 89 | | None, [INFO] [stdout] 90 | | std::path::Path::new(""), [INFO] [stdout] 91 | | )?) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/access.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 33 | let mut seen = HashSet::<&BStr>::default(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | / self.config [INFO] [stdout] 35 | | .sections_by_name("submodule") [INFO] [stdout] 36 | | .into_iter() [INFO] [stdout] 37 | | .flatten() [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/access.rs:38:25 [INFO] [stdout] | [INFO] [stdout] 33 | let mut seen = HashSet::<&BStr>::default(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | .filter_map(move |s| { [INFO] [stdout] | _________________________^ [INFO] [stdout] 39 | | s.header() [INFO] [stdout] 40 | | .subsection_name() [INFO] [stdout] 41 | | .filter(|_| s.meta().source == crate::init::META_MARKER) [INFO] [stdout] 42 | | .filter(|name| seen.insert(*name)) [INFO] [stdout] 43 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/access.rs:94:12 [INFO] [stdout] | [INFO] [stdout] 80 | let search = config [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | Ok(IsActivePlatform { search }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/access.rs:87:20 [INFO] [stdout] | [INFO] [stdout] 83 | let patterns = patterns [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | Ok(gix_pathspec::Search::from_specs( [INFO] [stdout] | ____________________^ [INFO] [stdout] 88 | | patterns, [INFO] [stdout] 89 | | None, [INFO] [stdout] 90 | | std::path::Path::new(""), [INFO] [stdout] 91 | | )?) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gix-submodule` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `gix-submodule` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "c728e1bcf263d3c6d9a0730b2d34c9ed4a13eb6f5dd06d9213799fb5429dc266", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c728e1bcf263d3c6d9a0730b2d34c9ed4a13eb6f5dd06d9213799fb5429dc266", kill_on_drop: false }` [INFO] [stdout] c728e1bcf263d3c6d9a0730b2d34c9ed4a13eb6f5dd06d9213799fb5429dc266