[INFO] fetching crate gix-status 0.13.0... [INFO] checking gix-status-0.13.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate gix-status 0.13.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate gix-status 0.13.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gix-status 0.13.0 [INFO] finished tweaking crates.io crate gix-status 0.13.0 [INFO] tweaked toml for crates.io crate gix-status 0.13.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 112 packages to latest compatible versions [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding prodash v28.0.0 (latest: v29.0.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2835c6f1eb0127d0bce7a046aed5453ddfb11c4ed68310cd766e9e3f28fddce3 [INFO] running `Command { std: "docker" "start" "-a" "2835c6f1eb0127d0bce7a046aed5453ddfb11c4ed68310cd766e9e3f28fddce3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2835c6f1eb0127d0bce7a046aed5453ddfb11c4ed68310cd766e9e3f28fddce3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2835c6f1eb0127d0bce7a046aed5453ddfb11c4ed68310cd766e9e3f28fddce3", kill_on_drop: false }` [INFO] [stdout] 2835c6f1eb0127d0bce7a046aed5453ddfb11c4ed68310cd766e9e3f28fddce3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f6b553d6dd72e5ae9d5800b5c04a096383d132711bcc0947955e6012ce799d55 [INFO] running `Command { std: "docker" "start" "-a" "f6b553d6dd72e5ae9d5800b5c04a096383d132711bcc0947955e6012ce799d55", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking gix-trace v0.1.9 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking faster-hex v0.9.0 [INFO] [stderr] Checking sha1_smol v1.0.1 [INFO] [stderr] Checking prodash v28.0.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Checking jiff v0.1.12 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking unicode-bom v2.0.3 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Checking kstring v2.0.2 [INFO] [stderr] Checking encoding_rs v0.8.34 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking memmap2 v0.9.4 [INFO] [stderr] Checking filetime v0.2.25 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking gix-utils v0.1.12 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking gix-hash v0.14.2 [INFO] [stderr] Checking gix-path v0.10.10 [INFO] [stderr] Checking gix-date v0.9.0 [INFO] [stderr] Checking gix-validate v0.9.0 [INFO] [stderr] Checking gix-chunk v0.4.8 [INFO] [stderr] Checking gix-quote v0.4.12 [INFO] [stderr] Checking gix-bitmap v0.2.11 [INFO] [stderr] Checking gix-packetline-blocking v0.17.5 [INFO] [stderr] Checking gix-actor v0.32.0 [INFO] [stderr] Checking gix-config-value v0.14.8 [INFO] [stderr] Checking gix-command v0.3.9 [INFO] [stderr] Checking gix-features v0.38.2 [INFO] [stderr] Checking gix-hashtable v0.5.2 [INFO] [stderr] Checking gix-glob v0.16.5 [INFO] [stderr] Checking gix-commitgraph v0.24.3 [INFO] [stderr] Checking gix-fs v0.11.3 [INFO] [stderr] Checking gix-object v0.44.0 [INFO] [stderr] Checking gix-tempfile v14.0.2 [INFO] [stderr] Checking gix-attributes v0.22.5 [INFO] [stderr] Checking gix-ignore v0.11.4 [INFO] [stderr] Checking gix-lock v14.0.0 [INFO] [stderr] Checking gix-pathspec v0.7.7 [INFO] [stderr] Checking gix-revwalk v0.15.0 [INFO] [stderr] Checking gix-filter v0.13.0 [INFO] [stderr] Checking gix-traverse v0.41.0 [INFO] [stderr] Checking gix-index v0.35.0 [INFO] [stderr] Checking gix-worktree v0.36.0 [INFO] [stderr] Checking gix-status v0.13.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index_as_worktree/recorder.rs:40:27 [INFO] [stdout] | [INFO] [stdout] 38 | status: EntryStatus, [INFO] [stdout] | --------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | ) { [INFO] [stdout] 40 | self.records.push(Record { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 41 | | entry, [INFO] [stdout] 42 | | entry_index, [INFO] [stdout] 43 | | relative_path, [INFO] [stdout] 44 | | status, [INFO] [stdout] 45 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index_as_worktree/function.rs:116:17 [INFO] [stdout] | [INFO] [stdout] 57 | compare: impl CompareBlobs + Send + Clone, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | submodule: impl SubmoduleStatus + Send + Clone, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | objects: Find, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | pathspec, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | stack, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | filter, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | / State { [INFO] [stdout] 117 | | buf: Vec::new(), [INFO] [stdout] 118 | | buf2: Vec::new(), [INFO] [stdout] 119 | | attr_stack: stack, [INFO] [stdout] ... | [INFO] [stdout] 134 | | odb_bytes, [INFO] [stdout] 135 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index_as_worktree/function.rs:374:37 [INFO] [stdout] | [INFO] [stdout] 372 | .map_err(|err| Error::SubmoduleStatus { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 373 | rela_path: rela_path.into(), [INFO] [stdout] 374 | source: Box::new(err), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index_as_worktree/function.rs:376:51 [INFO] [stdout] | [INFO] [stdout] 376 | return Ok(status.map(|status| Change::SubmoduleModification(status).into())); [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index_as_worktree/traits.rs:121:9 [INFO] [stdout] | [INFO] [stdout] 112 | data: impl ReadData<'a>, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | / HashEq [INFO] [stdout] 122 | | .compare_blobs(entry, worktree_file_size, data, buf) [INFO] [stdout] | |________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gix-status` (lib test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index_as_worktree/recorder.rs:40:27 [INFO] [stdout] | [INFO] [stdout] 38 | status: EntryStatus, [INFO] [stdout] | --------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | ) { [INFO] [stdout] 40 | self.records.push(Record { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 41 | | entry, [INFO] [stdout] 42 | | entry_index, [INFO] [stdout] 43 | | relative_path, [INFO] [stdout] 44 | | status, [INFO] [stdout] 45 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index_as_worktree/function.rs:116:17 [INFO] [stdout] | [INFO] [stdout] 57 | compare: impl CompareBlobs + Send + Clone, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | submodule: impl SubmoduleStatus + Send + Clone, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | objects: Find, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | pathspec, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | stack, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | filter, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | / State { [INFO] [stdout] 117 | | buf: Vec::new(), [INFO] [stdout] 118 | | buf2: Vec::new(), [INFO] [stdout] 119 | | attr_stack: stack, [INFO] [stdout] ... | [INFO] [stdout] 134 | | odb_bytes, [INFO] [stdout] 135 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index_as_worktree/function.rs:374:37 [INFO] [stdout] | [INFO] [stdout] 372 | .map_err(|err| Error::SubmoduleStatus { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 373 | rela_path: rela_path.into(), [INFO] [stdout] 374 | source: Box::new(err), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index_as_worktree/function.rs:376:51 [INFO] [stdout] | [INFO] [stdout] 376 | return Ok(status.map(|status| Change::SubmoduleModification(status).into())); [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index_as_worktree/traits.rs:121:9 [INFO] [stdout] | [INFO] [stdout] 112 | data: impl ReadData<'a>, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | / HashEq [INFO] [stdout] 122 | | .compare_blobs(entry, worktree_file_size, data, buf) [INFO] [stdout] | |________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gix-status` (lib) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "f6b553d6dd72e5ae9d5800b5c04a096383d132711bcc0947955e6012ce799d55", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f6b553d6dd72e5ae9d5800b5c04a096383d132711bcc0947955e6012ce799d55", kill_on_drop: false }` [INFO] [stdout] f6b553d6dd72e5ae9d5800b5c04a096383d132711bcc0947955e6012ce799d55