[INFO] fetching crate gix-revwalk 0.15.0... [INFO] checking gix-revwalk-0.15.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate gix-revwalk 0.15.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate gix-revwalk 0.15.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gix-revwalk 0.15.0 [INFO] finished tweaking crates.io crate gix-revwalk 0.15.0 [INFO] tweaked toml for crates.io crate gix-revwalk 0.15.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 57 packages to latest compatible versions [INFO] [stderr] Adding prodash v28.0.0 (latest: v29.0.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1a184f1250f6c92acf68ca36e6017d8025b14394a08ad304259a809c91962c32 [INFO] running `Command { std: "docker" "start" "-a" "1a184f1250f6c92acf68ca36e6017d8025b14394a08ad304259a809c91962c32", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1a184f1250f6c92acf68ca36e6017d8025b14394a08ad304259a809c91962c32", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1a184f1250f6c92acf68ca36e6017d8025b14394a08ad304259a809c91962c32", kill_on_drop: false }` [INFO] [stdout] 1a184f1250f6c92acf68ca36e6017d8025b14394a08ad304259a809c91962c32 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b8222440743785a7e2c15b3c700be566b08144426295fb4b382ed1d8211e93d9 [INFO] running `Command { std: "docker" "start" "-a" "b8222440743785a7e2c15b3c700be566b08144426295fb4b382ed1d8211e93d9", kill_on_drop: false }` [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking faster-hex v0.9.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking prodash v28.0.0 [INFO] [stderr] Checking gix-trace v0.1.9 [INFO] [stderr] Checking jiff v0.1.12 [INFO] [stderr] Checking sha1_smol v1.0.1 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking memmap2 v0.9.4 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking gix-utils v0.1.12 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking gix-hash v0.14.2 [INFO] [stderr] Checking gix-chunk v0.4.8 [INFO] [stderr] Checking gix-validate v0.9.0 [INFO] [stderr] Checking gix-features v0.38.2 [INFO] [stderr] Checking gix-hashtable v0.5.2 [INFO] [stderr] Checking gix-commitgraph v0.24.3 [INFO] [stderr] Checking gix-date v0.9.0 [INFO] [stderr] Checking gix-actor v0.32.0 [INFO] [stderr] Checking gix-object v0.44.0 [INFO] [stderr] Checking gix-revwalk v0.15.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph/mod.rs:160:19 [INFO] [stdout] | [INFO] [stdout] 158 | pub fn new(objects: impl gix_object::Find + 'find, cache: impl Into>) -> Self { [INFO] [stdout] | -------------------------------------- ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | Graph { [INFO] [stdout] 160 | find: Box::new(objects), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph/mod.rs:161:20 [INFO] [stdout] | [INFO] [stdout] 158 | pub fn new(objects: impl gix_object::Find + 'find, cache: impl Into>) -> Self { [INFO] [stdout] | -------------------------------------- ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | cache: cache.into(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph/mod.rs:162:18 [INFO] [stdout] | [INFO] [stdout] 158 | pub fn new(objects: impl gix_object::Find + 'find, cache: impl Into>) -> Self { [INFO] [stdout] | -------------------------------------- ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | map: gix_hashtable::HashMap::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph/mod.rs:239:20 [INFO] [stdout] | [INFO] [stdout] 235 | default: impl FnOnce() -> T, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 236 | update_data: impl FnOnce(&mut T), [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 239 | Ok(res.map(|commit| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 240 | | match self.map.entry(id) { [INFO] [stdout] 241 | | gix_hashtable::hash_map::Entry::Vacant(entry) => { [INFO] [stdout] 242 | | let mut data = default(); [INFO] [stdout] ... | [INFO] [stdout] 250 | | commit [INFO] [stdout] 251 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph/commit.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn to_owned(&self, new_data: impl FnOnce() -> T) -> Result, to_owned::Error> { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let data = new_data(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | Ok(match &self.backing { [INFO] [stdout] | ____________^ [INFO] [stdout] 41 | | Either::Left(buf) => { [INFO] [stdout] 42 | | use gix_object::commit::ref_iter::Token; [INFO] [stdout] 43 | | let iter = gix_object::CommitRefIter::from_bytes(buf); [INFO] [stdout] ... | [INFO] [stdout] 86 | | } [INFO] [stdout] 87 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/queue.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 91 | pub fn into_iter_unordered(self) -> impl Iterator { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | self.0.into_vec().into_iter().map(|item| (item.key, item.value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gix-revwalk` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph/mod.rs:160:19 [INFO] [stdout] | [INFO] [stdout] 158 | pub fn new(objects: impl gix_object::Find + 'find, cache: impl Into>) -> Self { [INFO] [stdout] | -------------------------------------- ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | Graph { [INFO] [stdout] 160 | find: Box::new(objects), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph/mod.rs:161:20 [INFO] [stdout] | [INFO] [stdout] 158 | pub fn new(objects: impl gix_object::Find + 'find, cache: impl Into>) -> Self { [INFO] [stdout] | -------------------------------------- ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | cache: cache.into(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph/mod.rs:162:18 [INFO] [stdout] | [INFO] [stdout] 158 | pub fn new(objects: impl gix_object::Find + 'find, cache: impl Into>) -> Self { [INFO] [stdout] | -------------------------------------- ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | map: gix_hashtable::HashMap::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph/mod.rs:239:20 [INFO] [stdout] | [INFO] [stdout] 235 | default: impl FnOnce() -> T, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 236 | update_data: impl FnOnce(&mut T), [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 239 | Ok(res.map(|commit| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 240 | | match self.map.entry(id) { [INFO] [stdout] 241 | | gix_hashtable::hash_map::Entry::Vacant(entry) => { [INFO] [stdout] 242 | | let mut data = default(); [INFO] [stdout] ... | [INFO] [stdout] 250 | | commit [INFO] [stdout] 251 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph/commit.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn to_owned(&self, new_data: impl FnOnce() -> T) -> Result, to_owned::Error> { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let data = new_data(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | Ok(match &self.backing { [INFO] [stdout] | ____________^ [INFO] [stdout] 41 | | Either::Left(buf) => { [INFO] [stdout] 42 | | use gix_object::commit::ref_iter::Token; [INFO] [stdout] 43 | | let iter = gix_object::CommitRefIter::from_bytes(buf); [INFO] [stdout] ... | [INFO] [stdout] 86 | | } [INFO] [stdout] 87 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/queue.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 91 | pub fn into_iter_unordered(self) -> impl Iterator { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | self.0.into_vec().into_iter().map(|item| (item.key, item.value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gix-revwalk` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "b8222440743785a7e2c15b3c700be566b08144426295fb4b382ed1d8211e93d9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b8222440743785a7e2c15b3c700be566b08144426295fb4b382ed1d8211e93d9", kill_on_drop: false }` [INFO] [stdout] b8222440743785a7e2c15b3c700be566b08144426295fb4b382ed1d8211e93d9