[INFO] fetching crate gix-pathspec 0.7.7... [INFO] checking gix-pathspec-0.7.7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate gix-pathspec 0.7.7 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate gix-pathspec 0.7.7 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gix-pathspec 0.7.7 [INFO] finished tweaking crates.io crate gix-pathspec 0.7.7 [INFO] tweaked toml for crates.io crate gix-pathspec 0.7.7 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 67 packages to latest compatible versions [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8b267db305f196322d451fe24e9b33e6195f731628f081e6b8edc16c4771e4d2 [INFO] running `Command { std: "docker" "start" "-a" "8b267db305f196322d451fe24e9b33e6195f731628f081e6b8edc16c4771e4d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8b267db305f196322d451fe24e9b33e6195f731628f081e6b8edc16c4771e4d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8b267db305f196322d451fe24e9b33e6195f731628f081e6b8edc16c4771e4d2", kill_on_drop: false }` [INFO] [stdout] 8b267db305f196322d451fe24e9b33e6195f731628f081e6b8edc16c4771e4d2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5784a284e51e4fbcf772ea06d11230adf72ae4b0f449e568856ac035f20e725d [INFO] running `Command { std: "docker" "start" "-a" "5784a284e51e4fbcf772ea06d11230adf72ae4b0f449e568856ac035f20e725d", kill_on_drop: false }` [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking gix-trace v0.1.9 [INFO] [stderr] Checking faster-hex v0.9.0 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking sdd v3.0.2 [INFO] [stderr] Checking unicode-bom v2.0.3 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking kstring v2.0.2 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking scc v2.1.16 [INFO] [stderr] Checking gix-utils v0.1.12 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling serial_test_derive v3.1.1 [INFO] [stderr] Checking serial_test v3.1.1 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking gix-path v0.10.10 [INFO] [stderr] Checking gix-hash v0.14.2 [INFO] [stderr] Checking gix-quote v0.4.12 [INFO] [stderr] Checking gix-config-value v0.14.8 [INFO] [stderr] Checking gix-features v0.38.2 [INFO] [stderr] Checking gix-glob v0.16.5 [INFO] [stderr] Checking gix-attributes v0.22.5 [INFO] [stderr] Checking gix-pathspec v0.7.7 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/search/init.rs:31:8 [INFO] [stdout] | [INFO] [stdout] 7 | mut pathspec: Pattern, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | Ok(gix_glob::search::pattern::Mapping { [INFO] [stdout] | ________^ [INFO] [stdout] 32 | | pattern: glob, [INFO] [stdout] 33 | | value: Spec { [INFO] [stdout] 34 | | attrs_match: { [INFO] [stdout] ... | [INFO] [stdout] 46 | | sequence_number, [INFO] [stdout] 47 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/search/init.rs:139:20 [INFO] [stdout] | [INFO] [stdout] 98 | pathspecs: impl IntoIterator, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | inner(&mut pathspecs.into_iter(), prefix, root) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/search/init.rs:132:16 [INFO] [stdout] | [INFO] [stdout] 108 | let mut patterns = pathspecs [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | Ok(Search { [INFO] [stdout] | ________________^ [INFO] [stdout] 133 | | all_patterns_are_excluded: patterns.iter().all(|s| s.value.pattern.is_excluded()), [INFO] [stdout] 134 | | patterns, [INFO] [stdout] 135 | | source: None, [INFO] [stdout] 136 | | common_prefix_len, [INFO] [stdout] 137 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/search/init.rs:144:9 [INFO] [stdout] | [INFO] [stdout] 143 | pub fn into_patterns(self) -> impl Iterator { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | self.patterns.into_iter().map(|p| p.value.pattern) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gix-pathspec` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/search/init.rs:31:8 [INFO] [stdout] | [INFO] [stdout] 7 | mut pathspec: Pattern, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | Ok(gix_glob::search::pattern::Mapping { [INFO] [stdout] | ________^ [INFO] [stdout] 32 | | pattern: glob, [INFO] [stdout] 33 | | value: Spec { [INFO] [stdout] 34 | | attrs_match: { [INFO] [stdout] ... | [INFO] [stdout] 46 | | sequence_number, [INFO] [stdout] 47 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/search/init.rs:139:20 [INFO] [stdout] | [INFO] [stdout] 98 | pathspecs: impl IntoIterator, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | inner(&mut pathspecs.into_iter(), prefix, root) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/search/init.rs:132:16 [INFO] [stdout] | [INFO] [stdout] 108 | let mut patterns = pathspecs [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | Ok(Search { [INFO] [stdout] | ________________^ [INFO] [stdout] 133 | | all_patterns_are_excluded: patterns.iter().all(|s| s.value.pattern.is_excluded()), [INFO] [stdout] 134 | | patterns, [INFO] [stdout] 135 | | source: None, [INFO] [stdout] 136 | | common_prefix_len, [INFO] [stdout] 137 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/search/init.rs:144:9 [INFO] [stdout] | [INFO] [stdout] 143 | pub fn into_patterns(self) -> impl Iterator { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | self.patterns.into_iter().map(|p| p.value.pattern) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gix-pathspec` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "5784a284e51e4fbcf772ea06d11230adf72ae4b0f449e568856ac035f20e725d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5784a284e51e4fbcf772ea06d11230adf72ae4b0f449e568856ac035f20e725d", kill_on_drop: false }` [INFO] [stdout] 5784a284e51e4fbcf772ea06d11230adf72ae4b0f449e568856ac035f20e725d