[INFO] fetching crate gix-fs 0.11.3... [INFO] checking gix-fs-0.11.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate gix-fs 0.11.3 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate gix-fs 0.11.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gix-fs 0.11.3 [INFO] finished tweaking crates.io crate gix-fs 0.11.3 [INFO] tweaked toml for crates.io crate gix-fs 0.11.3 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 39 packages to latest compatible versions [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a99d2a56ae45ad85a8d0d17c426e6e47ded54ad2d303ff4c6d07a57fa881a443 [INFO] running `Command { std: "docker" "start" "-a" "a99d2a56ae45ad85a8d0d17c426e6e47ded54ad2d303ff4c6d07a57fa881a443", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a99d2a56ae45ad85a8d0d17c426e6e47ded54ad2d303ff4c6d07a57fa881a443", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a99d2a56ae45ad85a8d0d17c426e6e47ded54ad2d303ff4c6d07a57fa881a443", kill_on_drop: false }` [INFO] [stdout] a99d2a56ae45ad85a8d0d17c426e6e47ded54ad2d303ff4c6d07a57fa881a443 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 455ebaf1b6edbd355bdd4fca1188cc5bfe5c8c15bcca4766fd51286eae2c7959 [INFO] running `Command { std: "docker" "start" "-a" "455ebaf1b6edbd355bdd4fca1188cc5bfe5c8c15bcca4766fd51286eae2c7959", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking faster-hex v0.9.0 [INFO] [stderr] Checking gix-trace v0.1.9 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking gix-utils v0.1.12 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking gix-hash v0.14.2 [INFO] [stderr] Checking gix-features v0.38.2 [INFO] [stderr] Checking gix-fs v0.11.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/capabilities.rs:70:27 [INFO] [stdout] | [INFO] [stdout] 70 | .and_then(|f| f.metadata().map(|m| m.mode() & 0o100 == 0o100)); [INFO] [stdout] | - ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/snapshot.rs:89:65 [INFO] [stdout] | [INFO] [stdout] 89 | *state = open()?.map(|(modified, value)| OwnShared::new(FileSnapshot { value, modified })); [INFO] [stdout] | ----------------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/snapshot.rs:121:44 [INFO] [stdout] | [INFO] [stdout] 120 | *state = open()?.map(|value| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | OwnShared::new(FileSnapshot { [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 122 | | value, [INFO] [stdout] 123 | | modified: modified_time, [INFO] [stdout] 124 | | }) [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/snapshot.rs:142:40 [INFO] [stdout] | [INFO] [stdout] 141 | *state = open()?.map(|value| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | OwnShared::new(FileSnapshot { [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 143 | | value, [INFO] [stdout] 144 | | modified: modified_time, [INFO] [stdout] 145 | | }) [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir/create.rs:125:14 [INFO] [stdout] | [INFO] [stdout] 122 | err: impl Into, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | Some(Err(Error::Permanent { [INFO] [stdout] | ______________^ [INFO] [stdout] 126 | | err: err.into(), [INFO] [stdout] 127 | | dir, [INFO] [stdout] 128 | | retries_left: self.retries, [INFO] [stdout] 129 | | retries: self.original_retries, [INFO] [stdout] 130 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir/create.rs:134:14 [INFO] [stdout] | [INFO] [stdout] 133 | fn intermediate_failure(&self, dir: &'a Path, err: std::io::Error) -> Option>> { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | Some(Err(Error::Intermediate { dir, kind: err.kind() })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gix-fs` (lib test) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/capabilities.rs:70:27 [INFO] [stdout] | [INFO] [stdout] 70 | .and_then(|f| f.metadata().map(|m| m.mode() & 0o100 == 0o100)); [INFO] [stdout] | - ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/snapshot.rs:89:65 [INFO] [stdout] | [INFO] [stdout] 89 | *state = open()?.map(|(modified, value)| OwnShared::new(FileSnapshot { value, modified })); [INFO] [stdout] | ----------------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/snapshot.rs:121:44 [INFO] [stdout] | [INFO] [stdout] 120 | *state = open()?.map(|value| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | OwnShared::new(FileSnapshot { [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 122 | | value, [INFO] [stdout] 123 | | modified: modified_time, [INFO] [stdout] 124 | | }) [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/snapshot.rs:142:40 [INFO] [stdout] | [INFO] [stdout] 141 | *state = open()?.map(|value| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | OwnShared::new(FileSnapshot { [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 143 | | value, [INFO] [stdout] 144 | | modified: modified_time, [INFO] [stdout] 145 | | }) [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir/create.rs:125:14 [INFO] [stdout] | [INFO] [stdout] 122 | err: impl Into, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | Some(Err(Error::Permanent { [INFO] [stdout] | ______________^ [INFO] [stdout] 126 | | err: err.into(), [INFO] [stdout] 127 | | dir, [INFO] [stdout] 128 | | retries_left: self.retries, [INFO] [stdout] 129 | | retries: self.original_retries, [INFO] [stdout] 130 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir/create.rs:134:14 [INFO] [stdout] | [INFO] [stdout] 133 | fn intermediate_failure(&self, dir: &'a Path, err: std::io::Error) -> Option>> { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | Some(Err(Error::Intermediate { dir, kind: err.kind() })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gix-fs` (lib) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "455ebaf1b6edbd355bdd4fca1188cc5bfe5c8c15bcca4766fd51286eae2c7959", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "455ebaf1b6edbd355bdd4fca1188cc5bfe5c8c15bcca4766fd51286eae2c7959", kill_on_drop: false }` [INFO] [stdout] 455ebaf1b6edbd355bdd4fca1188cc5bfe5c8c15bcca4766fd51286eae2c7959