[INFO] fetching crate gix-diff 0.46.0... [INFO] checking gix-diff-0.46.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate gix-diff 0.46.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate gix-diff 0.46.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gix-diff 0.46.0 [INFO] finished tweaking crates.io crate gix-diff 0.46.0 [INFO] tweaked toml for crates.io crate gix-diff 0.46.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 108 packages to latest compatible versions [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding prodash v28.0.0 (latest: v29.0.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5fc54f38585766c0ed036b40781837690fb66bab62d9aa27ed6f1e6a7c87b9c9 [INFO] running `Command { std: "docker" "start" "-a" "5fc54f38585766c0ed036b40781837690fb66bab62d9aa27ed6f1e6a7c87b9c9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5fc54f38585766c0ed036b40781837690fb66bab62d9aa27ed6f1e6a7c87b9c9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5fc54f38585766c0ed036b40781837690fb66bab62d9aa27ed6f1e6a7c87b9c9", kill_on_drop: false }` [INFO] [stdout] 5fc54f38585766c0ed036b40781837690fb66bab62d9aa27ed6f1e6a7c87b9c9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1a1d37f8726ab60a440dd1b62eacc0852dd585b0b44239974fa77a314c6052d8 [INFO] running `Command { std: "docker" "start" "-a" "1a1d37f8726ab60a440dd1b62eacc0852dd585b0b44239974fa77a314c6052d8", kill_on_drop: false }` [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking gix-trace v0.1.9 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking faster-hex v0.9.0 [INFO] [stderr] Checking sha1_smol v1.0.1 [INFO] [stderr] Checking prodash v28.0.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking jiff v0.1.12 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Checking gix-utils v0.1.12 [INFO] [stderr] Checking memmap2 v0.9.4 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking unicode-bom v2.0.3 [INFO] [stderr] Checking kstring v2.0.2 [INFO] [stderr] Checking filetime v0.2.25 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking gix-hash v0.14.2 [INFO] [stderr] Checking gix-chunk v0.4.8 [INFO] [stderr] Checking gix-bitmap v0.2.11 [INFO] [stderr] Checking dashmap v6.0.1 [INFO] [stderr] Checking imara-diff v0.1.7 [INFO] [stderr] Checking gix-features v0.38.2 [INFO] [stderr] Checking gix-hashtable v0.5.2 [INFO] [stderr] Checking gix-fs v0.11.3 [INFO] [stderr] Checking gix-validate v0.9.0 [INFO] [stderr] Checking gix-path v0.10.10 [INFO] [stderr] Checking gix-commitgraph v0.24.3 [INFO] [stderr] Checking gix-quote v0.4.12 [INFO] [stderr] Checking gix-packetline-blocking v0.17.5 [INFO] [stderr] Checking gix-glob v0.16.5 [INFO] [stderr] Checking gix-command v0.3.9 [INFO] [stderr] Checking gix-attributes v0.22.5 [INFO] [stderr] Checking gix-ignore v0.11.4 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking gix-tempfile v14.0.2 [INFO] [stderr] Checking gix-lock v14.0.0 [INFO] [stderr] Checking gix-date v0.9.0 [INFO] [stderr] Checking gix-actor v0.32.0 [INFO] [stderr] Checking gix-object v0.44.0 [INFO] [stderr] Checking gix-revwalk v0.15.0 [INFO] [stderr] Checking gix-filter v0.13.0 [INFO] [stderr] Checking gix-traverse v0.41.0 [INFO] [stderr] Checking gix-index v0.35.0 [INFO] [stderr] Checking gix-worktree v0.36.0 [INFO] [stderr] Checking gix-diff v0.46.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rewrites/tracker.rs:252:84 [INFO] [stdout] | [INFO] [stdout] 252 | .map_err(|err| emit::Error::GetItemsForExhaustiveCopyDetection(Box::new(err)))?; [INFO] [stdout] | --- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rewrites/tracker.rs:399:5 [INFO] [stdout] | [INFO] [stdout] 396 | items: impl IntoIterator, [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 399 | / items [INFO] [stdout] 400 | | .into_iter() [INFO] [stdout] 401 | | .filter(|(emitted, _)| match kind { [INFO] [stdout] 402 | | visit::SourceKind::Rename => !*emitted, [INFO] [stdout] 403 | | visit::SourceKind::Copy => true, [INFO] [stdout] 404 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rewrites/tracker.rs:252:84 [INFO] [stdout] | [INFO] [stdout] 252 | .map_err(|err| emit::Error::GetItemsForExhaustiveCopyDetection(Box::new(err)))?; [INFO] [stdout] | --- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rewrites/tracker.rs:399:5 [INFO] [stdout] | [INFO] [stdout] 396 | items: impl IntoIterator, [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 399 | / items [INFO] [stdout] 400 | | .into_iter() [INFO] [stdout] 401 | | .filter(|(emitted, _)| match kind { [INFO] [stdout] 402 | | visit::SourceKind::Rename => !*emitted, [INFO] [stdout] 403 | | visit::SourceKind::Copy => true, [INFO] [stdout] 404 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree/changes.rs:336:33 [INFO] [stdout] | [INFO] [stdout] 335 | fn peekable(iter: I) -> IteratorType { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 336 | std::mem::ManuallyDrop::new(iter.peekable()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree/changes.rs:336:33 [INFO] [stdout] | [INFO] [stdout] 335 | fn peekable(iter: I) -> IteratorType { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 336 | std::mem::ManuallyDrop::new(iter.peekable()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blob/pipeline.rs:175:20 [INFO] [stdout] | [INFO] [stdout] 165 | worktree_filter: gix_filter::Pipeline, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | attrs: { [INFO] [stdout] | ____________________^ [INFO] [stdout] 176 | | let mut out = gix_filter::attributes::search::Outcome::default(); [INFO] [stdout] 177 | | out.initialize_with_selection(&Default::default(), Some("diff")); [INFO] [stdout] 178 | | out [INFO] [stdout] 179 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blob/pipeline.rs:326:64 [INFO] [stdout] | [INFO] [stdout] 326 | ... &mut |buf| objects.try_find(id, buf).map(|obj| obj.map(|_| ())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blob/pipeline.rs:423:49 [INFO] [stdout] | [INFO] [stdout] 421 | ... .map(|tmp_file| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 422 | ... ( [INFO] [stdout] 423 | / ... d.prepare_binary_to_text_cmd(&self.path) [INFO] [stdout] 424 | | ... .expect("always get cmd if command is set"), [INFO] [stdout] | |_____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blob/pipeline.rs:175:20 [INFO] [stdout] | [INFO] [stdout] 165 | worktree_filter: gix_filter::Pipeline, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | attrs: { [INFO] [stdout] | ____________________^ [INFO] [stdout] 176 | | let mut out = gix_filter::attributes::search::Outcome::default(); [INFO] [stdout] 177 | | out.initialize_with_selection(&Default::default(), Some("diff")); [INFO] [stdout] 178 | | out [INFO] [stdout] 179 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blob/pipeline.rs:326:64 [INFO] [stdout] | [INFO] [stdout] 326 | ... &mut |buf| objects.try_find(id, buf).map(|obj| obj.map(|_| ())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blob/pipeline.rs:423:49 [INFO] [stdout] | [INFO] [stdout] 421 | ... .map(|tmp_file| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 422 | ... ( [INFO] [stdout] 423 | / ... d.prepare_binary_to_text_cmd(&self.path) [INFO] [stdout] 424 | | ... .expect("always get cmd if command is set"), [INFO] [stdout] | |_____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gix-diff` (lib test) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `gix-diff` (lib) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "1a1d37f8726ab60a440dd1b62eacc0852dd585b0b44239974fa77a314c6052d8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1a1d37f8726ab60a440dd1b62eacc0852dd585b0b44239974fa77a314c6052d8", kill_on_drop: false }` [INFO] [stdout] 1a1d37f8726ab60a440dd1b62eacc0852dd585b0b44239974fa77a314c6052d8