[INFO] fetching crate gix-attributes 0.22.5... [INFO] checking gix-attributes-0.22.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate gix-attributes 0.22.5 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate gix-attributes 0.22.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gix-attributes 0.22.5 [INFO] finished tweaking crates.io crate gix-attributes 0.22.5 [INFO] tweaked toml for crates.io crate gix-attributes 0.22.5 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 44 packages to latest compatible versions [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 29d2600561615643a3eec13e0b99aa3f35d89eb6ecc0def8659d5fce3aa81620 [INFO] running `Command { std: "docker" "start" "-a" "29d2600561615643a3eec13e0b99aa3f35d89eb6ecc0def8659d5fce3aa81620", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "29d2600561615643a3eec13e0b99aa3f35d89eb6ecc0def8659d5fce3aa81620", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "29d2600561615643a3eec13e0b99aa3f35d89eb6ecc0def8659d5fce3aa81620", kill_on_drop: false }` [INFO] [stdout] 29d2600561615643a3eec13e0b99aa3f35d89eb6ecc0def8659d5fce3aa81620 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7db59cd7581f081d11a8bf1f1d34657f758af7c08259fef1813c9076cd09ec61 [INFO] running `Command { std: "docker" "start" "-a" "7db59cd7581f081d11a8bf1f1d34657f758af7c08259fef1813c9076cd09ec61", kill_on_drop: false }` [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking faster-hex v0.9.0 [INFO] [stderr] Checking gix-trace v0.1.9 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking unicode-bom v2.0.3 [INFO] [stderr] Checking kstring v2.0.2 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking gix-utils v0.1.12 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking gix-hash v0.14.2 [INFO] [stderr] Checking gix-features v0.38.2 [INFO] [stderr] Checking gix-path v0.10.10 [INFO] [stderr] Checking gix-quote v0.4.12 [INFO] [stderr] Checking gix-glob v0.16.5 [INFO] [stderr] Checking gix-attributes v0.22.5 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/search/attributes.rs:135:32 [INFO] [stdout] | [INFO] [stdout] 135 | inner: a.to_owned(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/search/attributes.rs:174:17 [INFO] [stdout] | [INFO] [stdout] 156 | .filter_map(|(pattern_kind, assignments, line_number)| { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 157 | let (pattern, value) = match pattern_kind { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | crate::parse::Kind::Macro(macro_name) => ( [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | / pattern::Mapping { [INFO] [stdout] 175 | | pattern, [INFO] [stdout] 176 | | value, [INFO] [stdout] 177 | | sequence_number: line_number, [INFO] [stdout] 178 | | } [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/search/outcome.rs:49:63 [INFO] [stdout] | [INFO] [stdout] 47 | attribute_names: impl IntoIterator>>, [INFO] [stdout] | -------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | ) { [INFO] [stdout] 49 | self.initialize_with_selection_inner(collection, &mut attribute_names.into_iter().map(Into::into)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/search/outcome.rs:182:39 [INFO] [stdout] | [INFO] [stdout] 182 | .map(|attr| (attr.id, attr.inner.clone(), None)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/search/outcome.rs:218:47 [INFO] [stdout] | [INFO] [stdout] 218 | .map(|attr| (attr.id, attr.inner.clone(), Some(id))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:165:5 [INFO] [stdout] | [INFO] [stdout] 142 | let kind_res = match line.strip_prefix(b"[attr]") { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | let kind = match kind_res { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | Ok(kind) => kind, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | Ok((kind, Iter::new(attrs), line_number)).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:148:37 [INFO] [stdout] | [INFO] [stdout] 148 | .map(|name| Kind::Macro(name.to_owned())), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gix-attributes` (lib test) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/search/attributes.rs:135:32 [INFO] [stdout] | [INFO] [stdout] 135 | inner: a.to_owned(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/search/attributes.rs:174:17 [INFO] [stdout] | [INFO] [stdout] 156 | .filter_map(|(pattern_kind, assignments, line_number)| { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 157 | let (pattern, value) = match pattern_kind { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | crate::parse::Kind::Macro(macro_name) => ( [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | / pattern::Mapping { [INFO] [stdout] 175 | | pattern, [INFO] [stdout] 176 | | value, [INFO] [stdout] 177 | | sequence_number: line_number, [INFO] [stdout] 178 | | } [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/search/outcome.rs:49:63 [INFO] [stdout] | [INFO] [stdout] 47 | attribute_names: impl IntoIterator>>, [INFO] [stdout] | -------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | ) { [INFO] [stdout] 49 | self.initialize_with_selection_inner(collection, &mut attribute_names.into_iter().map(Into::into)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/search/outcome.rs:182:39 [INFO] [stdout] | [INFO] [stdout] 182 | .map(|attr| (attr.id, attr.inner.clone(), None)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/search/outcome.rs:218:47 [INFO] [stdout] | [INFO] [stdout] 218 | .map(|attr| (attr.id, attr.inner.clone(), Some(id))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:165:5 [INFO] [stdout] | [INFO] [stdout] 142 | let kind_res = match line.strip_prefix(b"[attr]") { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | let kind = match kind_res { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | Ok(kind) => kind, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | Ok((kind, Iter::new(attrs), line_number)).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:148:37 [INFO] [stdout] | [INFO] [stdout] 148 | .map(|name| Kind::Macro(name.to_owned())), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gix-attributes` (lib) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "7db59cd7581f081d11a8bf1f1d34657f758af7c08259fef1813c9076cd09ec61", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7db59cd7581f081d11a8bf1f1d34657f758af7c08259fef1813c9076cd09ec61", kill_on_drop: false }` [INFO] [stdout] 7db59cd7581f081d11a8bf1f1d34657f758af7c08259fef1813c9076cd09ec61