[INFO] fetching crate gitt 0.2.2... [INFO] checking gitt-0.2.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate gitt 0.2.2 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate gitt 0.2.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gitt 0.2.2 [INFO] finished tweaking crates.io crate gitt 0.2.2 [INFO] tweaked toml for crates.io crate gitt 0.2.2 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate gitt 0.2.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a98b9d0e3476f6962e8d9bed5e8dfedb0d44c8755974f85e329390030c94b272 [INFO] running `Command { std: "docker" "start" "-a" "a98b9d0e3476f6962e8d9bed5e8dfedb0d44c8755974f85e329390030c94b272", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a98b9d0e3476f6962e8d9bed5e8dfedb0d44c8755974f85e329390030c94b272", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a98b9d0e3476f6962e8d9bed5e8dfedb0d44c8755974f85e329390030c94b272", kill_on_drop: false }` [INFO] [stdout] a98b9d0e3476f6962e8d9bed5e8dfedb0d44c8755974f85e329390030c94b272 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 076313a3f71e9fe788b38aca052f52bf695ecf7e5d4e1c07d391d68aa9e1cbd8 [INFO] running `Command { std: "docker" "start" "-a" "076313a3f71e9fe788b38aca052f52bf695ecf7e5d4e1c07d391d68aa9e1cbd8", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.95 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Compiling signal-hook v0.3.9 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Checking matches v0.1.8 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking hashbrown v0.9.1 [INFO] [stderr] Checking textwrap v0.14.2 [INFO] [stderr] Checking unicode-segmentation v1.7.1 [INFO] [stderr] Checking instant v0.1.9 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking lock_api v0.4.4 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking tinyvec v1.2.0 [INFO] [stderr] Checking unicode-bidi v0.3.5 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling indexmap v1.6.2 [INFO] [stderr] Compiling jobserver v0.1.22 [INFO] [stderr] Compiling cc v1.0.68 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Checking unicode-normalization v0.1.18 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking mio v0.7.11 [INFO] [stderr] Checking parking_lot_core v0.8.3 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v3.1.0 [INFO] [stderr] Checking parking_lot v0.11.1 [INFO] [stderr] Compiling libz-sys v1.1.3 [INFO] [stderr] Compiling libgit2-sys v0.12.21+1.1.0 [INFO] [stderr] Checking signal-hook v0.1.17 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking signal-hook-mio v0.2.1 [INFO] [stderr] Checking crossterm v0.20.0 [INFO] [stderr] Checking crossterm v0.19.0 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking tui v0.16.0 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking git2 v0.13.20 [INFO] [stderr] Checking gitt v0.2.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: variant `Text` is never constructed [INFO] [stdout] --> src/model.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 17 | pub enum CommitFilter { [INFO] [stdout] | ------------ variant in this enum [INFO] [stdout] 18 | Path((PathBuf, HashSet)), [INFO] [stdout] 19 | Text(String), // TODO: author? time? [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:23:26 [INFO] [stdout] | [INFO] [stdout] 23 | .or_else(|| Some(std::env::current_dir().map_err(|e| format!("{}", e)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:90:47 [INFO] [stdout] | [INFO] [stdout] 37 | let repository = git2::Repository::discover(&repository_dir).unwrap(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | let model = model::AppModel::new( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | let repository = git2::Repository::discover(&repository_dir).unwrap(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | [INFO] [stdout] 48 | let ids: HashSet = model [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | model::CommitFilter::Path((path, ids)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:52:82 [INFO] [stdout] | [INFO] [stdout] 52 | ... let parent_tree = commit.parent(0).ok().and_then(|p| p.tree().ok()); [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:56:51 [INFO] [stdout] | [INFO] [stdout] 56 | ... .and_then(|p| t.get_path(p).ok().map(|t_p| t_p.id())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:60:51 [INFO] [stdout] | [INFO] [stdout] 60 | ... .and_then(|p| t.get_path(p).ok().map(|t_p| t_p.id())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model.rs:206:66 [INFO] [stdout] | [INFO] [stdout] 206 | let parent_tree = commit.parent(0).ok().and_then(|p| p.tree().ok()); [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gitt` (bin "gitt" test) due to 7 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variant `Text` is never constructed [INFO] [stdout] --> src/model.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 17 | pub enum CommitFilter { [INFO] [stdout] | ------------ variant in this enum [INFO] [stdout] 18 | Path((PathBuf, HashSet)), [INFO] [stdout] 19 | Text(String), // TODO: author? time? [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:23:26 [INFO] [stdout] | [INFO] [stdout] 23 | .or_else(|| Some(std::env::current_dir().map_err(|e| format!("{}", e)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:90:47 [INFO] [stdout] | [INFO] [stdout] 37 | let repository = git2::Repository::discover(&repository_dir).unwrap(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | let model = model::AppModel::new( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | let repository = git2::Repository::discover(&repository_dir).unwrap(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | [INFO] [stdout] 48 | let ids: HashSet = model [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | model::CommitFilter::Path((path, ids)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:52:82 [INFO] [stdout] | [INFO] [stdout] 52 | ... let parent_tree = commit.parent(0).ok().and_then(|p| p.tree().ok()); [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:56:51 [INFO] [stdout] | [INFO] [stdout] 56 | ... .and_then(|p| t.get_path(p).ok().map(|t_p| t_p.id())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:60:51 [INFO] [stdout] | [INFO] [stdout] 60 | ... .and_then(|p| t.get_path(p).ok().map(|t_p| t_p.id())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model.rs:206:66 [INFO] [stdout] | [INFO] [stdout] 206 | let parent_tree = commit.parent(0).ok().and_then(|p| p.tree().ok()); [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gitt` (bin "gitt") due to 7 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "076313a3f71e9fe788b38aca052f52bf695ecf7e5d4e1c07d391d68aa9e1cbd8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "076313a3f71e9fe788b38aca052f52bf695ecf7e5d4e1c07d391d68aa9e1cbd8", kill_on_drop: false }` [INFO] [stdout] 076313a3f71e9fe788b38aca052f52bf695ecf7e5d4e1c07d391d68aa9e1cbd8