[INFO] fetching crate gitm 0.4.3... [INFO] checking gitm-0.4.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate gitm 0.4.3 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate gitm 0.4.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gitm 0.4.3 [INFO] finished tweaking crates.io crate gitm 0.4.3 [INFO] tweaked toml for crates.io crate gitm 0.4.3 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate gitm 0.4.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2029c9620cac1c1f75d4c0b4032948b52dd0421079fbfab3837ca89a408c3a1a [INFO] running `Command { std: "docker" "start" "-a" "2029c9620cac1c1f75d4c0b4032948b52dd0421079fbfab3837ca89a408c3a1a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2029c9620cac1c1f75d4c0b4032948b52dd0421079fbfab3837ca89a408c3a1a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2029c9620cac1c1f75d4c0b4032948b52dd0421079fbfab3837ca89a408c3a1a", kill_on_drop: false }` [INFO] [stdout] 2029c9620cac1c1f75d4c0b4032948b52dd0421079fbfab3837ca89a408c3a1a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1edb6523c6833c64c42dd8a31d8b9047a965ecf8566149d9baefe16ddf9571bc [INFO] running `Command { std: "docker" "start" "-a" "1edb6523c6833c64c42dd8a31d8b9047a965ecf8566149d9baefe16ddf9571bc", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.82 [INFO] [stderr] Compiling thiserror v1.0.60 [INFO] [stderr] Checking either v1.12.0 [INFO] [stderr] Compiling serde v1.0.202 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Checking unicode-width v0.1.12 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.64 [INFO] [stderr] Checking clier_parser v0.7.4 [INFO] [stderr] Compiling serde_derive v1.0.202 [INFO] [stderr] Compiling thiserror-impl v1.0.60 [INFO] [stderr] Checking clier v0.7.4 [INFO] [stderr] Checking gitm v0.4.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `command` [INFO] [stdout] --> src/integrations/editor/editor_nvim.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | let command = Command::new("nvim") [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_command` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/integrations/search/fzf.rs:43:11 [INFO] [stdout] | [INFO] [stdout] 21 | let echo_output = Command::new("echo") [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | let mut command_builder = Command::new("fzf"); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | let command = command_builder [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | match command.wait_with_output() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/integrations/search/pick.rs:38:11 [INFO] [stdout] | [INFO] [stdout] 22 | let echo_output = Command::new("echo") [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | let command = Command::new("pick") [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | match command.wait_with_output() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/integrations/srcs/local.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 11 | let dir = std::fs::read_dir(config.project_directory).unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | [INFO] [stdout] 13 | / dir [INFO] [stdout] 14 | | .into_iter() [INFO] [stdout] 15 | | .map(|value| { [INFO] [stdout] 16 | | let value_buf = value.unwrap().path(); [INFO] [stdout] ... | [INFO] [stdout] 26 | | } [INFO] [stdout] 27 | | }) [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gitm` (lib test) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `command` [INFO] [stdout] --> src/integrations/editor/editor_nvim.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | let command = Command::new("nvim") [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_command` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/integrations/search/fzf.rs:43:11 [INFO] [stdout] | [INFO] [stdout] 21 | let echo_output = Command::new("echo") [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | let mut command_builder = Command::new("fzf"); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | let command = command_builder [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | match command.wait_with_output() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/integrations/search/pick.rs:38:11 [INFO] [stdout] | [INFO] [stdout] 22 | let echo_output = Command::new("echo") [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | let command = Command::new("pick") [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | match command.wait_with_output() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/integrations/srcs/local.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 11 | let dir = std::fs::read_dir(config.project_directory).unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | [INFO] [stdout] 13 | / dir [INFO] [stdout] 14 | | .into_iter() [INFO] [stdout] 15 | | .map(|value| { [INFO] [stdout] 16 | | let value_buf = value.unwrap().path(); [INFO] [stdout] ... | [INFO] [stdout] 26 | | } [INFO] [stdout] 27 | | }) [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gitm` (lib) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "1edb6523c6833c64c42dd8a31d8b9047a965ecf8566149d9baefe16ddf9571bc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1edb6523c6833c64c42dd8a31d8b9047a965ecf8566149d9baefe16ddf9571bc", kill_on_drop: false }` [INFO] [stdout] 1edb6523c6833c64c42dd8a31d8b9047a965ecf8566149d9baefe16ddf9571bc