[INFO] fetching crate gitlab-runner 0.1.0... [INFO] checking gitlab-runner-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate gitlab-runner 0.1.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate gitlab-runner 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gitlab-runner 0.1.0 [INFO] finished tweaking crates.io crate gitlab-runner 0.1.0 [INFO] tweaked toml for crates.io crate gitlab-runner 0.1.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate gitlab-runner 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c858b2bbbf8e29da4d96899fb59036afb112a94ca59b6096eae0ea5ae7d30eb4 [INFO] running `Command { std: "docker" "start" "-a" "c858b2bbbf8e29da4d96899fb59036afb112a94ca59b6096eae0ea5ae7d30eb4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c858b2bbbf8e29da4d96899fb59036afb112a94ca59b6096eae0ea5ae7d30eb4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c858b2bbbf8e29da4d96899fb59036afb112a94ca59b6096eae0ea5ae7d30eb4", kill_on_drop: false }` [INFO] [stdout] c858b2bbbf8e29da4d96899fb59036afb112a94ca59b6096eae0ea5ae7d30eb4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f9f20bd0da8c9aa70780b94af8ab67d17728a669f12dcdf9456eefc8b67158e8 [INFO] running `Command { std: "docker" "start" "-a" "f9f20bd0da8c9aa70780b94af8ab67d17728a669f12dcdf9456eefc8b67158e8", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Compiling proc-macro2 v1.0.82 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling serde v1.0.202 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Compiling anyhow v1.0.83 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Compiling openssl v0.10.64 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Compiling crc32fast v1.4.0 [INFO] [stderr] Compiling syn v2.0.64 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Compiling powerfmt v0.2.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling thiserror v1.0.60 [INFO] [stderr] Compiling itoa v1.0.11 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling deranged v0.3.11 [INFO] [stderr] Compiling num_threads v0.1.7 [INFO] [stderr] Compiling zstd-safe v7.1.0 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Compiling jobserver v0.1.31 [INFO] [stderr] Compiling vergen v8.3.1 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Compiling mime_guess v2.0.4 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking encoding_rs v0.8.34 [INFO] [stderr] Checking crc-catalog v2.4.0 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling cc v1.0.97 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Checking parking_lot v0.12.2 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking http-body-util v0.1.1 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking crc v3.2.1 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Compiling time v0.3.36 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling multer v3.1.0 [INFO] [stderr] Checking deadpool-runtime v0.1.3 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking rustls-pki-types v1.7.0 [INFO] [stderr] Checking typed-arena v2.0.2 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Compiling zip v1.3.0 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling unicode-segmentation v1.11.0 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking unicode-width v0.1.12 [INFO] [stderr] Checking zopfli v0.8.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling cmake v0.1.50 [INFO] [stderr] Checking lzma-rs v0.3.0 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking sync_wrapper v0.1.2 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking deflate64 v0.1.8 [INFO] [stderr] Checking constant_time_eq v0.3.0 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Compiling openssl-sys v0.9.102 [INFO] [stderr] Compiling zstd-sys v2.0.10+zstd.1.5.6 [INFO] [stderr] Compiling bzip2-sys v0.1.11+1.0.8 [INFO] [stderr] Compiling libz-ng-sys v1.1.15 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking bzip2 v0.4.4 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Compiling gitlab-runner v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling serde_derive v1.0.202 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling thiserror-impl v1.0.60 [INFO] [stderr] Compiling async-trait v0.1.80 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling displaydoc v0.2.4 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking structopt v0.3.26 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking zstd v0.13.1 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking deadpool v0.10.0 [INFO] [stderr] Checking h2 v0.4.4 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking tracing-serde v0.1.3 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Checking assert-json-diff v2.0.2 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking hyper v1.3.1 [INFO] [stderr] Checking hyper-util v0.1.3 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking wiremock v0.6.0 [INFO] [stderr] Checking reqwest v0.12.4 [INFO] [stderr] Checking gitlab-runner-mock v0.1.0 [INFO] [stdout] warning: field `trace_update_interval` is never read [INFO] [stdout] --> src/client.rs:109:9 [INFO] [stdout] | [INFO] [stdout] 108 | pub struct JobUpdateReply { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 109 | pub trace_update_interval: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `JobUpdateReply` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:260:23 [INFO] [stdout] | [INFO] [stdout] 251 | token: S, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 252 | build_dir: P, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 253 | jobs: JobRunList, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 260 | run_list: jobs.inner(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:416:58 [INFO] [stdout] | [INFO] [stdout] 403 | pub async fn request_job(&mut self, process: F) -> Result [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 414 | let mut run = Run::new(self.client.clone(), response, &mut self.run_list); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 415 | tokio::spawn( [INFO] [stdout] 416 | async move { run.run(process, build_dir).await }.with_current_subscriber(), [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/artifact.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 46 | pub(crate) fn new(data: Box) -> ZipResult { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | let zip = zip::ZipArchive::new(data)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | Ok(Self { zip }) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:20:8 [INFO] [stdout] | [INFO] [stdout] 14 | fn deserialize_null_default<'de, D, T>(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | let opt = Option::deserialize(deserializer)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | Ok(opt.unwrap_or_default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/logging.rs:86:13 [INFO] [stdout] | [INFO] [stdout] 83 | let run_list = RunList::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | let job_run_list = JobRunList::from(run_list.clone()); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | ( [INFO] [stdout] 86 | Filtered::new(GitlabLayer { run_list }, GitlabFilter {}), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/logging.rs:105:38 [INFO] [stdout] | [INFO] [stdout] 105 | .find_map(|span| span.extensions().get::().cloned()) [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/run.rs:192:23 [INFO] [stdout] | [INFO] [stdout] 180 | client: Client, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | let response = Arc::new(response); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | let now = Instant::now(); [INFO] [stdout] 186 | let joblog = JobLog::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | let joblog = run_list.insert(response.id, joblog); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 192 | interval: Self::create_interval(now, Duration::from_secs(3)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/job.rs:268:24 [INFO] [stdout] | [INFO] [stdout] 258 | client: Client, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 259 | response: Arc, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 260 | build_dir: PathBuf, [INFO] [stdout] 261 | log: JobLog, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 268 | artifacts: ArtifactCache::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/uploader.rs:229:12 [INFO] [stdout] | [INFO] [stdout] 207 | client: Client, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | let temp = tempfile::tempfile_in(build_dir) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | let (tx, rx) = mpsc::channel(2); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 229 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 230 | | client, [INFO] [stdout] 231 | | job_id, [INFO] [stdout] 232 | | job_token, [INFO] [stdout] 233 | | artifact, [INFO] [stdout] 234 | | tx, [INFO] [stdout] 235 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runlist.rs:69:20 [INFO] [stdout] | [INFO] [stdout] 67 | let (tx, rx) = watch::channel(0); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | RunList { [INFO] [stdout] 69 | inner: Arc::new(Inner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 70 | | rundata: RwLock::new(HashMap::new()), [INFO] [stdout] 71 | | changed: tx, [INFO] [stdout] 72 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runlist.rs:96:20 [INFO] [stdout] | [INFO] [stdout] 91 | pub(crate) fn insert(&mut self, id: K, data: V) -> RunListEntry { [INFO] [stdout] | ----- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | let mut r = self.inner.rundata.write(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | owner: self.inner.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gitlab-runner` (lib) due to 12 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `trace_update_interval` is never read [INFO] [stdout] --> src/client.rs:109:9 [INFO] [stdout] | [INFO] [stdout] 108 | pub struct JobUpdateReply { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 109 | pub trace_update_interval: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `JobUpdateReply` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:260:23 [INFO] [stdout] | [INFO] [stdout] 251 | token: S, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 252 | build_dir: P, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 253 | jobs: JobRunList, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 260 | run_list: jobs.inner(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:416:58 [INFO] [stdout] | [INFO] [stdout] 403 | pub async fn request_job(&mut self, process: F) -> Result [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 414 | let mut run = Run::new(self.client.clone(), response, &mut self.run_list); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 415 | tokio::spawn( [INFO] [stdout] 416 | async move { run.run(process, build_dir).await }.with_current_subscriber(), [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/artifact.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 46 | pub(crate) fn new(data: Box) -> ZipResult { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | let zip = zip::ZipArchive::new(data)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | Ok(Self { zip }) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:20:8 [INFO] [stdout] | [INFO] [stdout] 14 | fn deserialize_null_default<'de, D, T>(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | let opt = Option::deserialize(deserializer)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | Ok(opt.unwrap_or_default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/logging.rs:86:13 [INFO] [stdout] | [INFO] [stdout] 83 | let run_list = RunList::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | let job_run_list = JobRunList::from(run_list.clone()); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | ( [INFO] [stdout] 86 | Filtered::new(GitlabLayer { run_list }, GitlabFilter {}), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/logging.rs:105:38 [INFO] [stdout] | [INFO] [stdout] 105 | .find_map(|span| span.extensions().get::().cloned()) [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/run.rs:192:23 [INFO] [stdout] | [INFO] [stdout] 180 | client: Client, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | let response = Arc::new(response); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | let now = Instant::now(); [INFO] [stdout] 186 | let joblog = JobLog::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | let joblog = run_list.insert(response.id, joblog); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 192 | interval: Self::create_interval(now, Duration::from_secs(3)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/job.rs:268:24 [INFO] [stdout] | [INFO] [stdout] 258 | client: Client, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 259 | response: Arc, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 260 | build_dir: PathBuf, [INFO] [stdout] 261 | log: JobLog, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 268 | artifacts: ArtifactCache::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/uploader.rs:229:12 [INFO] [stdout] | [INFO] [stdout] 207 | client: Client, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | let temp = tempfile::tempfile_in(build_dir) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | let (tx, rx) = mpsc::channel(2); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 229 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 230 | | client, [INFO] [stdout] 231 | | job_id, [INFO] [stdout] 232 | | job_token, [INFO] [stdout] 233 | | artifact, [INFO] [stdout] 234 | | tx, [INFO] [stdout] 235 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runlist.rs:69:20 [INFO] [stdout] | [INFO] [stdout] 67 | let (tx, rx) = watch::channel(0); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | RunList { [INFO] [stdout] 69 | inner: Arc::new(Inner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 70 | | rundata: RwLock::new(HashMap::new()), [INFO] [stdout] 71 | | changed: tx, [INFO] [stdout] 72 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runlist.rs:96:20 [INFO] [stdout] | [INFO] [stdout] 91 | pub(crate) fn insert(&mut self, id: K, data: V) -> RunListEntry { [INFO] [stdout] | ----- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | let mut r = self.inner.rundata.write(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | owner: self.inner.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gitlab-runner` (lib test) due to 12 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "f9f20bd0da8c9aa70780b94af8ab67d17728a669f12dcdf9456eefc8b67158e8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f9f20bd0da8c9aa70780b94af8ab67d17728a669f12dcdf9456eefc8b67158e8", kill_on_drop: false }` [INFO] [stdout] f9f20bd0da8c9aa70780b94af8ab67d17728a669f12dcdf9456eefc8b67158e8