[INFO] fetching crate gitlab-ci-ls 0.21.0... [INFO] checking gitlab-ci-ls-0.21.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate gitlab-ci-ls 0.21.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate gitlab-ci-ls 0.21.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gitlab-ci-ls 0.21.0 [INFO] finished tweaking crates.io crate gitlab-ci-ls 0.21.0 [INFO] tweaked toml for crates.io crate gitlab-ci-ls 0.21.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate gitlab-ci-ls 0.21.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9f45a9566fa5668b8c32d8c0e227310a34d11d6765457c332d40441ffeed1085 [INFO] running `Command { std: "docker" "start" "-a" "9f45a9566fa5668b8c32d8c0e227310a34d11d6765457c332d40441ffeed1085", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9f45a9566fa5668b8c32d8c0e227310a34d11d6765457c332d40441ffeed1085", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9f45a9566fa5668b8c32d8c0e227310a34d11d6765457c332d40441ffeed1085", kill_on_drop: false }` [INFO] [stdout] 9f45a9566fa5668b8c32d8c0e227310a34d11d6765457c332d40441ffeed1085 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 35e4f53145b18fbe2c4dda1f0e707f060adeac7f6ca02347f76ceca85eb2cc1d [INFO] running `Command { std: "docker" "start" "-a" "35e4f53145b18fbe2c4dda1f0e707f060adeac7f6ca02347f76ceca85eb2cc1d", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling cc v1.0.97 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling serde v1.0.208 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling openssl v0.10.66 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Compiling serde_json v1.0.125 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Compiling syn v2.0.58 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Checking base64 v0.22.0 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Checking http-body-util v0.1.1 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking rustls-pki-types v1.4.1 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking crossbeam-channel v0.5.12 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking thread-id v3.3.0 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Checking encoding_rs v0.8.33 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking simple-logging v2.0.2 [INFO] [stderr] Checking crc64 v2.0.0 [INFO] [stderr] Checking tokio v1.39.3 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Compiling tree-sitter v0.22.6 [INFO] [stderr] Compiling tree-sitter-yaml v0.6.1 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking simple_logger v5.0.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling serde_derive v1.0.208 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling serde_repr v0.1.18 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking h2 v0.4.4 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking hyper v1.2.0 [INFO] [stderr] Checking lsp-server v0.7.6 [INFO] [stderr] Checking lsp-types v0.95.1 [INFO] [stderr] Checking hyper-util v0.1.3 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.5 [INFO] [stderr] Checking gitlab-ci-ls v0.21.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Position` [INFO] [stdout] --> src/gitlab_ci_ls_parser/mod.rs:4:29 [INFO] [stdout] | [INFO] [stdout] 4 | use lsp_types::{Diagnostic, Position, TextEdit, Url}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `warn` [INFO] [stdout] --> src/gitlab_ci_ls_parser/treesitter.rs:1:18 [INFO] [stdout] | [INFO] [stdout] 1 | use log::{error, warn}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Position` [INFO] [stdout] --> src/gitlab_ci_ls_parser/mod.rs:4:29 [INFO] [stdout] | [INFO] [stdout] 4 | use lsp_types::{Diagnostic, Position, TextEdit, Url}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `warn` [INFO] [stdout] --> src/gitlab_ci_ls_parser/treesitter.rs:1:18 [INFO] [stdout] | [INFO] [stdout] 1 | use log::{error, warn}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `err` is never read [INFO] [stdout] --> src/gitlab_ci_ls_parser/mod.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 47 | pub struct RenameResult { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 50 | pub err: Option, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RenameResult` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `key` and `uri` are never read [INFO] [stdout] --> src/gitlab_ci_ls_parser/mod.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 111 | pub struct GitlabCacheElement { [INFO] [stdout] | ------------------ fields in this struct [INFO] [stdout] 112 | pub key: String, [INFO] [stdout] | ^^^ [INFO] [stdout] 113 | pub content: Option, [INFO] [stdout] 114 | pub uri: String, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `GitlabCacheElement` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `content` and `uri` are never read [INFO] [stdout] --> src/gitlab_ci_ls_parser/mod.rs:122:9 [INFO] [stdout] | [INFO] [stdout] 120 | pub struct GitlabInputElement { [INFO] [stdout] | ------------------ fields in this struct [INFO] [stdout] 121 | pub key: String, [INFO] [stdout] 122 | pub content: Option, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 123 | pub uri: String, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `GitlabInputElement` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `uri` is never read [INFO] [stdout] --> src/gitlab_ci_ls_parser/mod.rs:135:9 [INFO] [stdout] | [INFO] [stdout] 132 | pub struct GitlabComponentElement { [INFO] [stdout] | ---------------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 135 | pub uri: String, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `GitlabComponentElement` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `value` is never read [INFO] [stdout] --> src/gitlab_ci_ls_parser/mod.rs:195:5 [INFO] [stdout] | [INFO] [stdout] 194 | pub struct ComponentInputValuePlain { [INFO] [stdout] | ------------------------ field in this struct [INFO] [stdout] 195 | value: String, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ComponentInputValuePlain` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `value` and `hovered` are never read [INFO] [stdout] --> src/gitlab_ci_ls_parser/mod.rs:201:5 [INFO] [stdout] | [INFO] [stdout] 200 | pub struct ComponentInputValueBlock { [INFO] [stdout] | ------------------------ fields in this struct [INFO] [stdout] 201 | value: String, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 202 | hovered: bool, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ComponentInputValueBlock` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gitlab_ci_ls_parser/handlers.rs:93:15 [INFO] [stdout] | [INFO] [stdout] 81 | let store = self.store.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | let nodes = self.nodes.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | match self.parser.get_position_type(document, position) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gitlab_ci_ls_parser/handlers.rs:436:14 [INFO] [stdout] | [INFO] [stdout] 299 | let store = self.store.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 304 | let stages = self.stages.lock().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 436 | Some(LSPResult::Definition(DefinitionResult { [INFO] [stdout] | ______________^ [INFO] [stdout] 437 | | id: request.id, [INFO] [stdout] 438 | | locations, [INFO] [stdout] 439 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gitlab_ci_ls_parser/handlers.rs:634:14 [INFO] [stdout] | [INFO] [stdout] 605 | let store = self.store.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 622 | component: Some(component), [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 634 | Some(LSPResult::Completion(CompletionResult { [INFO] [stdout] | ______________^ [INFO] [stdout] 635 | | id: request.id, [INFO] [stdout] 636 | | list: items, [INFO] [stdout] 637 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gitlab_ci_ls_parser/handlers.rs:1183:14 [INFO] [stdout] | [INFO] [stdout] 1006 | let store = self.store.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1007 | let all_nodes = self.nodes.lock().unwrap(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1045 | let all_stages = self.stages.lock().unwrap(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1120 | let all_components = self.components.lock().unwrap(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1183 | Some(LSPResult::Diagnostics(DiagnosticsNotification { [INFO] [stdout] | ______________^ [INFO] [stdout] 1184 | | uri: document_uri, [INFO] [stdout] 1185 | | diagnostics, [INFO] [stdout] 1186 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gitlab_ci_ls_parser/handlers.rs:1263:14 [INFO] [stdout] | [INFO] [stdout] 1201 | let store = self.store.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1208 | let position_type = self.parser.get_position_type(document, position); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1263 | Some(LSPResult::References(ReferencesResult { [INFO] [stdout] | ______________^ [INFO] [stdout] 1264 | | id: request.id, [INFO] [stdout] 1265 | | locations: references, [INFO] [stdout] 1266 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gitlab_ci_ls_parser/handlers.rs:1677:14 [INFO] [stdout] | [INFO] [stdout] 1519 | let store = self.store.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1677 | Some(LSPResult::Rename(RenameResult { [INFO] [stdout] | ______________^ [INFO] [stdout] 1678 | | id: request.id, [INFO] [stdout] 1679 | | edits: Some(edits), [INFO] [stdout] 1680 | | err: None, [INFO] [stdout] 1681 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gitlab_ci_ls_parser/parser.rs:162:18 [INFO] [stdout] | [INFO] [stdout] 157 | treesitter: Box, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | fs_utils: Box, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | git: Box::new(git::GitImpl::new( [INFO] [stdout] | __________________^ [INFO] [stdout] 163 | | remote_urls, [INFO] [stdout] 164 | | package_map, [INFO] [stdout] 165 | | cache_path, [INFO] [stdout] 166 | | fs_utils, [INFO] [stdout] 167 | | )), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gitlab_ci_ls_parser/parser.rs:406:23 [INFO] [stdout] | [INFO] [stdout] 398 | .map(|i| crate::gitlab_ci_ls_parser::ComponentInput { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 406 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gitlab_ci_ls_parser/parser.rs:643:9 [INFO] [stdout] | [INFO] [stdout] 621 | let init = serde_yaml::from_str("") [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 624 | let merged = all_nodes [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 638 | let mut top_level_map = serde_yaml::Mapping::new(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 641 | let merged_with_key = serde_yaml::Value::Mapping(top_level_map); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 642 | [INFO] [stdout] 643 | serde_yaml::to_string(&merged_with_key) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gitlab-ci-ls` (bin "gitlab-ci-ls") due to 10 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `err` is never read [INFO] [stdout] --> src/gitlab_ci_ls_parser/mod.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 47 | pub struct RenameResult { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 50 | pub err: Option, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RenameResult` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `key` and `uri` are never read [INFO] [stdout] --> src/gitlab_ci_ls_parser/mod.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 111 | pub struct GitlabCacheElement { [INFO] [stdout] | ------------------ fields in this struct [INFO] [stdout] 112 | pub key: String, [INFO] [stdout] | ^^^ [INFO] [stdout] 113 | pub content: Option, [INFO] [stdout] 114 | pub uri: String, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `GitlabCacheElement` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `content` and `uri` are never read [INFO] [stdout] --> src/gitlab_ci_ls_parser/mod.rs:122:9 [INFO] [stdout] | [INFO] [stdout] 120 | pub struct GitlabInputElement { [INFO] [stdout] | ------------------ fields in this struct [INFO] [stdout] 121 | pub key: String, [INFO] [stdout] 122 | pub content: Option, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 123 | pub uri: String, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `GitlabInputElement` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `uri` is never read [INFO] [stdout] --> src/gitlab_ci_ls_parser/mod.rs:135:9 [INFO] [stdout] | [INFO] [stdout] 132 | pub struct GitlabComponentElement { [INFO] [stdout] | ---------------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 135 | pub uri: String, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `GitlabComponentElement` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `value` is never read [INFO] [stdout] --> src/gitlab_ci_ls_parser/mod.rs:195:5 [INFO] [stdout] | [INFO] [stdout] 194 | pub struct ComponentInputValuePlain { [INFO] [stdout] | ------------------------ field in this struct [INFO] [stdout] 195 | value: String, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ComponentInputValuePlain` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `value` and `hovered` are never read [INFO] [stdout] --> src/gitlab_ci_ls_parser/mod.rs:201:5 [INFO] [stdout] | [INFO] [stdout] 200 | pub struct ComponentInputValueBlock { [INFO] [stdout] | ------------------------ fields in this struct [INFO] [stdout] 201 | value: String, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 202 | hovered: bool, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ComponentInputValueBlock` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gitlab_ci_ls_parser/handlers.rs:93:15 [INFO] [stdout] | [INFO] [stdout] 81 | let store = self.store.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | let nodes = self.nodes.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | match self.parser.get_position_type(document, position) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gitlab_ci_ls_parser/handlers.rs:436:14 [INFO] [stdout] | [INFO] [stdout] 299 | let store = self.store.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 304 | let stages = self.stages.lock().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 436 | Some(LSPResult::Definition(DefinitionResult { [INFO] [stdout] | ______________^ [INFO] [stdout] 437 | | id: request.id, [INFO] [stdout] 438 | | locations, [INFO] [stdout] 439 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gitlab_ci_ls_parser/handlers.rs:634:14 [INFO] [stdout] | [INFO] [stdout] 605 | let store = self.store.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 622 | component: Some(component), [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 634 | Some(LSPResult::Completion(CompletionResult { [INFO] [stdout] | ______________^ [INFO] [stdout] 635 | | id: request.id, [INFO] [stdout] 636 | | list: items, [INFO] [stdout] 637 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gitlab_ci_ls_parser/handlers.rs:1183:14 [INFO] [stdout] | [INFO] [stdout] 1006 | let store = self.store.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1007 | let all_nodes = self.nodes.lock().unwrap(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1045 | let all_stages = self.stages.lock().unwrap(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1120 | let all_components = self.components.lock().unwrap(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1183 | Some(LSPResult::Diagnostics(DiagnosticsNotification { [INFO] [stdout] | ______________^ [INFO] [stdout] 1184 | | uri: document_uri, [INFO] [stdout] 1185 | | diagnostics, [INFO] [stdout] 1186 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gitlab_ci_ls_parser/handlers.rs:1263:14 [INFO] [stdout] | [INFO] [stdout] 1201 | let store = self.store.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1208 | let position_type = self.parser.get_position_type(document, position); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1263 | Some(LSPResult::References(ReferencesResult { [INFO] [stdout] | ______________^ [INFO] [stdout] 1264 | | id: request.id, [INFO] [stdout] 1265 | | locations: references, [INFO] [stdout] 1266 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gitlab_ci_ls_parser/handlers.rs:1677:14 [INFO] [stdout] | [INFO] [stdout] 1519 | let store = self.store.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1677 | Some(LSPResult::Rename(RenameResult { [INFO] [stdout] | ______________^ [INFO] [stdout] 1678 | | id: request.id, [INFO] [stdout] 1679 | | edits: Some(edits), [INFO] [stdout] 1680 | | err: None, [INFO] [stdout] 1681 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gitlab_ci_ls_parser/parser.rs:162:18 [INFO] [stdout] | [INFO] [stdout] 157 | treesitter: Box, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | fs_utils: Box, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | git: Box::new(git::GitImpl::new( [INFO] [stdout] | __________________^ [INFO] [stdout] 163 | | remote_urls, [INFO] [stdout] 164 | | package_map, [INFO] [stdout] 165 | | cache_path, [INFO] [stdout] 166 | | fs_utils, [INFO] [stdout] 167 | | )), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gitlab_ci_ls_parser/parser.rs:406:23 [INFO] [stdout] | [INFO] [stdout] 398 | .map(|i| crate::gitlab_ci_ls_parser::ComponentInput { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 406 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gitlab_ci_ls_parser/parser.rs:643:9 [INFO] [stdout] | [INFO] [stdout] 621 | let init = serde_yaml::from_str("") [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 624 | let merged = all_nodes [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 638 | let mut top_level_map = serde_yaml::Mapping::new(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 641 | let merged_with_key = serde_yaml::Value::Mapping(top_level_map); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 642 | [INFO] [stdout] 643 | serde_yaml::to_string(&merged_with_key) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gitlab-ci-ls` (bin "gitlab-ci-ls" test) due to 10 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "35e4f53145b18fbe2c4dda1f0e707f060adeac7f6ca02347f76ceca85eb2cc1d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "35e4f53145b18fbe2c4dda1f0e707f060adeac7f6ca02347f76ceca85eb2cc1d", kill_on_drop: false }` [INFO] [stdout] 35e4f53145b18fbe2c4dda1f0e707f060adeac7f6ca02347f76ceca85eb2cc1d