[INFO] fetching crate git2-curl 0.20.0... [INFO] checking git2-curl-0.20.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate git2-curl 0.20.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate git2-curl 0.20.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate git2-curl 0.20.0 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate git2-curl 0.20.0 [INFO] tweaked toml for crates.io crate git2-curl 0.20.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 65 packages to latest compatible versions [INFO] [stderr] Adding aho-corasick v0.5.3 (latest: v1.1.3) [INFO] [stderr] Adding conduit v0.8.1 (latest: v0.10.0) [INFO] [stderr] Adding conduit-git-http-backend v0.8.0 (latest: v0.10.0) [INFO] [stderr] Adding flate2 v0.2.20 (latest: v1.0.33) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding lazy_static v0.2.11 (latest: v1.5.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding memchr v0.1.11 (latest: v2.7.4) [INFO] [stderr] Adding regex v0.1.80 (latest: v1.10.6) [INFO] [stderr] Adding regex-syntax v0.3.9 (latest: v0.8.4) [INFO] [stderr] Adding semver v0.5.1 (latest: v1.0.23) [INFO] [stderr] Adding semver-parser v0.6.2 (latest: v0.10.2) [INFO] [stderr] Adding thread-id v2.0.0 (latest: v4.2.2) [INFO] [stderr] Adding thread_local v0.2.7 (latest: v1.1.8) [INFO] [stderr] Adding utf8-ranges v0.1.3 (latest: v1.0.5) [INFO] [stderr] Adding winapi v0.2.8 (latest: v0.3.9) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 38751419d982c2a3f39676584a653812dfb84087906331bbc4a21ef9ad03973c [INFO] running `Command { std: "docker" "start" "-a" "38751419d982c2a3f39676584a653812dfb84087906331bbc4a21ef9ad03973c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "38751419d982c2a3f39676584a653812dfb84087906331bbc4a21ef9ad03973c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "38751419d982c2a3f39676584a653812dfb84087906331bbc4a21ef9ad03973c", kill_on_drop: false }` [INFO] [stdout] 38751419d982c2a3f39676584a653812dfb84087906331bbc4a21ef9ad03973c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 611a8084bb5006d326a6c4d7c8571a5e6b6518619e8064839095b3730865e759 [INFO] running `Command { std: "docker" "start" "-a" "611a8084bb5006d326a6c4d7c8571a5e6b6518619e8064839095b3730865e759", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling winapi-build v0.1.1 [INFO] [stderr] Checking winapi v0.2.8 [INFO] [stderr] Checking utf8-ranges v0.1.3 [INFO] [stderr] Checking regex-syntax v0.3.9 [INFO] [stderr] Checking lazy_static v0.2.11 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Compiling curl v0.4.46 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling kernel32-sys v0.2.2 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking semver-parser v0.6.2 [INFO] [stderr] Checking semver v0.5.1 [INFO] [stderr] Checking conduit v0.8.1 [INFO] [stderr] Compiling libz-sys v1.1.20 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Compiling curl-sys v0.4.74+curl-8.9.0 [INFO] [stderr] Compiling libgit2-sys v0.17.0+1.8.1 [INFO] [stderr] Compiling miniz-sys v0.1.12 [INFO] [stderr] Compiling civet-sys v0.3.0 [INFO] [stderr] Checking flate2 v0.2.20 [INFO] [stderr] Checking conduit-git-http-backend v0.8.0 [INFO] [stderr] Checking civet v0.11.0 [INFO] [stderr] Checking git2 v0.19.0 [INFO] [stderr] Checking git2-curl v0.20.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:77:73 [INFO] [stdout] | [INFO] [stdout] 74 | let handle = Arc::new(Mutex::new(handle)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | git2::transport::register("http", move |remote| factory(remote, handle.clone())).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git2-curl` (lib) due to 5 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:78:74 [INFO] [stdout] | [INFO] [stdout] 75 | let handle2 = handle.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | git2::transport::register("https", move |remote| factory(remote, handle2.clone())).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 82 | fn factory(remote: &git2::Remote<'_>, handle: Arc>) -> Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | / CurlTransport { [INFO] [stdout] 87 | | handle: handle, [INFO] [stdout] 88 | | base_url: Arc::new(Mutex::new(String::new())), [INFO] [stdout] 89 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:112:12 [INFO] [stdout] | [INFO] [stdout] 99 | let mut base_url = self.base_url.lock().unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | Ok(Box::new(CurlSubtransport { [INFO] [stdout] | ____________^ [INFO] [stdout] 113 | | handle: self.handle.clone(), [INFO] [stdout] 114 | | service: service, [INFO] [stdout] 115 | | url_path: path, [INFO] [stdout] ... | [INFO] [stdout] 119 | | sent_request: false, [INFO] [stdout] 120 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:77:73 [INFO] [stdout] | [INFO] [stdout] 74 | let handle = Arc::new(Mutex::new(handle)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | git2::transport::register("http", move |remote| factory(remote, handle.clone())).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:78:74 [INFO] [stdout] | [INFO] [stdout] 75 | let handle2 = handle.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | git2::transport::register("https", move |remote| factory(remote, handle2.clone())).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 82 | fn factory(remote: &git2::Remote<'_>, handle: Arc>) -> Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | / CurlTransport { [INFO] [stdout] 87 | | handle: handle, [INFO] [stdout] 88 | | base_url: Arc::new(Mutex::new(String::new())), [INFO] [stdout] 89 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:112:12 [INFO] [stdout] | [INFO] [stdout] 99 | let mut base_url = self.base_url.lock().unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | Ok(Box::new(CurlSubtransport { [INFO] [stdout] | ____________^ [INFO] [stdout] 113 | | handle: self.handle.clone(), [INFO] [stdout] 114 | | service: service, [INFO] [stdout] 115 | | url_path: path, [INFO] [stdout] ... | [INFO] [stdout] 119 | | sent_request: false, [INFO] [stdout] 120 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git2-curl` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "611a8084bb5006d326a6c4d7c8571a5e6b6518619e8064839095b3730865e759", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "611a8084bb5006d326a6c4d7c8571a5e6b6518619e8064839095b3730865e759", kill_on_drop: false }` [INFO] [stdout] 611a8084bb5006d326a6c4d7c8571a5e6b6518619e8064839095b3730865e759