[INFO] fetching crate git-tempfile 3.0.3... [INFO] checking git-tempfile-3.0.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate git-tempfile 3.0.3 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate git-tempfile 3.0.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate git-tempfile 3.0.3 [INFO] finished tweaking crates.io crate git-tempfile 3.0.3 [INFO] tweaked toml for crates.io crate git-tempfile 3.0.3 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate git-tempfile 3.0.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 62c6bd78c097ed5e7db4fb475d362020cf127bbbc82f5165c3b8f79bfac39aa8 [INFO] running `Command { std: "docker" "start" "-a" "62c6bd78c097ed5e7db4fb475d362020cf127bbbc82f5165c3b8f79bfac39aa8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "62c6bd78c097ed5e7db4fb475d362020cf127bbbc82f5165c3b8f79bfac39aa8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "62c6bd78c097ed5e7db4fb475d362020cf127bbbc82f5165c3b8f79bfac39aa8", kill_on_drop: false }` [INFO] [stdout] 62c6bd78c097ed5e7db4fb475d362020cf127bbbc82f5165c3b8f79bfac39aa8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e823276bacb474f480eef90e570ae3473650083a9965f17aa3134011cead4d22 [INFO] running `Command { std: "docker" "start" "-a" "e823276bacb474f480eef90e570ae3473650083a9965f17aa3134011cead4d22", kill_on_drop: false }` [INFO] [stderr] Compiling parking_lot_core v0.9.7 [INFO] [stderr] Compiling signal-hook v0.3.15 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking smallvec v1.10.0 [INFO] [stderr] Compiling lock_api v0.4.9 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking once_cell v1.17.1 [INFO] [stderr] Checking fastrand v1.9.0 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking tempfile v3.3.0 [INFO] [stderr] Checking dashmap v5.4.0 [INFO] [stderr] Checking git-tempfile v3.0.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs/create_dir.rs:125:14 [INFO] [stdout] | [INFO] [stdout] 122 | err: impl Into, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | Some(Err(Error::Permanent { [INFO] [stdout] | ______________^ [INFO] [stdout] 126 | | err: err.into(), [INFO] [stdout] 127 | | dir, [INFO] [stdout] 128 | | retries_left: self.retries, [INFO] [stdout] 129 | | retries: self.original_retries, [INFO] [stdout] 130 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs/create_dir.rs:134:14 [INFO] [stdout] | [INFO] [stdout] 133 | fn intermediate_failure(&self, dir: &'a Path, err: std::io::Error) -> Option>> { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | Some(Err(Error::Intermediate { dir, kind: err.kind() })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/forksafe.rs:22:20 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn new(tempfile: NamedTempFile, cleanup: AutoRemove, mode: handle::Mode) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | inner: match mode { [INFO] [stdout] | ____________________^ [INFO] [stdout] 23 | | Closed => TempfileOrTemppath::Temppath(tempfile.into_temp_path()), [INFO] [stdout] 24 | | Writable => TempfileOrTemppath::Tempfile(tempfile), [INFO] [stdout] 25 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn at(path: impl AsRef, directory: ContainingDirectory, cleanup: AutoRemove) -> io::Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | Ok(Handle { [INFO] [stdout] | ____________^ [INFO] [stdout] 80 | | id: Handle::<()>::at_path(path, directory, cleanup, Mode::Closed)?, [INFO] [stdout] 81 | | _marker: Default::default(), [INFO] [stdout] 82 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:102:12 [INFO] [stdout] | [INFO] [stdout] 101 | pub fn at(path: impl AsRef, directory: ContainingDirectory, cleanup: AutoRemove) -> io::Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | Ok(Handle { [INFO] [stdout] | ____________^ [INFO] [stdout] 103 | | id: Handle::<()>::at_path(path, directory, cleanup, Mode::Writable)?, [INFO] [stdout] 104 | | _marker: Default::default(), [INFO] [stdout] 105 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:116:12 [INFO] [stdout] | [INFO] [stdout] 112 | containing_directory: impl AsRef, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | Ok(Handle { [INFO] [stdout] | ____________^ [INFO] [stdout] 117 | | id: Handle::<()>::new_writable_inner(containing_directory, directory, cleanup, Mode::Writable)?, [INFO] [stdout] 118 | | _marker: Default::default(), [INFO] [stdout] 119 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:128:42 [INFO] [stdout] | [INFO] [stdout] 128 | res.and_then(|(_k, v)| v.map(|v| v.into_tempfile().expect("correct runtime typing"))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:137:15 [INFO] [stdout] | [INFO] [stdout] 136 | pub fn close(self) -> std::io::Result> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | match REGISTER.remove(&self.id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:165:15 [INFO] [stdout] | [INFO] [stdout] 164 | pub fn with_mut(&mut self, once: impl FnOnce(&mut NamedTempFile) -> T) -> std::io::Result { [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | match REGISTER.remove(&self.id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:252:19 [INFO] [stdout] | [INFO] [stdout] 249 | pub fn persist(self, path: impl AsRef) -> Result, Error> { [INFO] [stdout] | ---- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 250 | let res = REGISTER.remove(&self.id); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 251 | [INFO] [stdout] 252 | match res.and_then(|(_k, v)| v.map(|v| v.persist(path))) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:252:48 [INFO] [stdout] | [INFO] [stdout] 249 | pub fn persist(self, path: impl AsRef) -> Result, Error> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 252 | match res.and_then(|(_k, v)| v.map(|v| v.persist(path))) { [INFO] [stdout] | ------- ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:279:19 [INFO] [stdout] | [INFO] [stdout] 276 | pub fn persist(self, path: impl AsRef) -> Result<(), Error> { [INFO] [stdout] | ---- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 277 | let res = REGISTER.remove(&self.id); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 278 | [INFO] [stdout] 279 | match res.and_then(|(_k, v)| v.map(|v| v.persist(path))) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:279:48 [INFO] [stdout] | [INFO] [stdout] 276 | pub fn persist(self, path: impl AsRef) -> Result<(), Error> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 279 | match res.and_then(|(_k, v)| v.map(|v| v.persist(path))) { [INFO] [stdout] | ------- ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-tempfile` (lib) due to 14 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs/create_dir.rs:125:14 [INFO] [stdout] | [INFO] [stdout] 122 | err: impl Into, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | Some(Err(Error::Permanent { [INFO] [stdout] | ______________^ [INFO] [stdout] 126 | | err: err.into(), [INFO] [stdout] 127 | | dir, [INFO] [stdout] 128 | | retries_left: self.retries, [INFO] [stdout] 129 | | retries: self.original_retries, [INFO] [stdout] 130 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs/create_dir.rs:134:14 [INFO] [stdout] | [INFO] [stdout] 133 | fn intermediate_failure(&self, dir: &'a Path, err: std::io::Error) -> Option>> { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | Some(Err(Error::Intermediate { dir, kind: err.kind() })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 59 | fn filecount_in(path: impl AsRef) -> usize { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | std::fs::read_dir(path).expect("valid dir").count() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/forksafe.rs:22:20 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn new(tempfile: NamedTempFile, cleanup: AutoRemove, mode: handle::Mode) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | inner: match mode { [INFO] [stdout] | ____________________^ [INFO] [stdout] 23 | | Closed => TempfileOrTemppath::Temppath(tempfile.into_temp_path()), [INFO] [stdout] 24 | | Writable => TempfileOrTemppath::Tempfile(tempfile), [INFO] [stdout] 25 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn at(path: impl AsRef, directory: ContainingDirectory, cleanup: AutoRemove) -> io::Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | Ok(Handle { [INFO] [stdout] | ____________^ [INFO] [stdout] 80 | | id: Handle::<()>::at_path(path, directory, cleanup, Mode::Closed)?, [INFO] [stdout] 81 | | _marker: Default::default(), [INFO] [stdout] 82 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:102:12 [INFO] [stdout] | [INFO] [stdout] 101 | pub fn at(path: impl AsRef, directory: ContainingDirectory, cleanup: AutoRemove) -> io::Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | Ok(Handle { [INFO] [stdout] | ____________^ [INFO] [stdout] 103 | | id: Handle::<()>::at_path(path, directory, cleanup, Mode::Writable)?, [INFO] [stdout] 104 | | _marker: Default::default(), [INFO] [stdout] 105 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:116:12 [INFO] [stdout] | [INFO] [stdout] 112 | containing_directory: impl AsRef, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | Ok(Handle { [INFO] [stdout] | ____________^ [INFO] [stdout] 117 | | id: Handle::<()>::new_writable_inner(containing_directory, directory, cleanup, Mode::Writable)?, [INFO] [stdout] 118 | | _marker: Default::default(), [INFO] [stdout] 119 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:128:42 [INFO] [stdout] | [INFO] [stdout] 128 | res.and_then(|(_k, v)| v.map(|v| v.into_tempfile().expect("correct runtime typing"))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:137:15 [INFO] [stdout] | [INFO] [stdout] 136 | pub fn close(self) -> std::io::Result> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | match REGISTER.remove(&self.id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:165:15 [INFO] [stdout] | [INFO] [stdout] 164 | pub fn with_mut(&mut self, once: impl FnOnce(&mut NamedTempFile) -> T) -> std::io::Result { [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | match REGISTER.remove(&self.id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:252:19 [INFO] [stdout] | [INFO] [stdout] 249 | pub fn persist(self, path: impl AsRef) -> Result, Error> { [INFO] [stdout] | ---- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 250 | let res = REGISTER.remove(&self.id); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 251 | [INFO] [stdout] 252 | match res.and_then(|(_k, v)| v.map(|v| v.persist(path))) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:252:48 [INFO] [stdout] | [INFO] [stdout] 249 | pub fn persist(self, path: impl AsRef) -> Result, Error> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 252 | match res.and_then(|(_k, v)| v.map(|v| v.persist(path))) { [INFO] [stdout] | ------- ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:279:19 [INFO] [stdout] | [INFO] [stdout] 276 | pub fn persist(self, path: impl AsRef) -> Result<(), Error> { [INFO] [stdout] | ---- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 277 | let res = REGISTER.remove(&self.id); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 278 | [INFO] [stdout] 279 | match res.and_then(|(_k, v)| v.map(|v| v.persist(path))) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:279:48 [INFO] [stdout] | [INFO] [stdout] 276 | pub fn persist(self, path: impl AsRef) -> Result<(), Error> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 279 | match res.and_then(|(_k, v)| v.map(|v| v.persist(path))) { [INFO] [stdout] | ------- ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-tempfile` (lib test) due to 15 previous errors [INFO] running `Command { std: "docker" "inspect" "e823276bacb474f480eef90e570ae3473650083a9965f17aa3134011cead4d22", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e823276bacb474f480eef90e570ae3473650083a9965f17aa3134011cead4d22", kill_on_drop: false }` [INFO] [stdout] e823276bacb474f480eef90e570ae3473650083a9965f17aa3134011cead4d22