[INFO] fetching crate git-summary 0.1.1... [INFO] checking git-summary-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate git-summary 0.1.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate git-summary 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate git-summary 0.1.1 [INFO] finished tweaking crates.io crate git-summary 0.1.1 [INFO] tweaked toml for crates.io crate git-summary 0.1.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate git-summary 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3c905ac0b7bb08a896f5e653bde3d015d0c0b15360f3054ca3da84db40ebd2da [INFO] running `Command { std: "docker" "start" "-a" "3c905ac0b7bb08a896f5e653bde3d015d0c0b15360f3054ca3da84db40ebd2da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3c905ac0b7bb08a896f5e653bde3d015d0c0b15360f3054ca3da84db40ebd2da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3c905ac0b7bb08a896f5e653bde3d015d0c0b15360f3054ca3da84db40ebd2da", kill_on_drop: false }` [INFO] [stdout] 3c905ac0b7bb08a896f5e653bde3d015d0c0b15360f3054ca3da84db40ebd2da [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 717dfbea2d76652acc5098ce1619240202e61732ab2799c01a1cc616a1216c94 [INFO] running `Command { std: "docker" "start" "-a" "717dfbea2d76652acc5098ce1619240202e61732ab2799c01a1cc616a1216c94", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.107 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling pkg-config v0.3.22 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Compiling crossbeam-epoch v0.9.5 [INFO] [stderr] Compiling serde v1.0.130 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Compiling rayon-core v1.9.1 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Checking unicode-bidi v0.3.7 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking tinyvec v1.5.1 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Compiling anyhow v1.0.45 [INFO] [stderr] Compiling memoffset v0.6.4 [INFO] [stderr] Compiling rayon v1.5.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking openssl-probe v0.1.4 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking encode_unicode v0.3.6 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Compiling jobserver v0.1.24 [INFO] [stderr] Compiling cc v1.0.72 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking dirs v1.0.5 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Checking term v0.5.2 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Compiling openssl-sys v0.9.70 [INFO] [stderr] Compiling libz-sys v1.1.3 [INFO] [stderr] Compiling libssh2-sys v0.2.23 [INFO] [stderr] Compiling libgit2-sys v0.12.24+1.3.0 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking pretty_env_logger v0.4.0 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking prettytable-rs v0.8.0 [INFO] [stderr] Checking git2 v0.13.23 [INFO] [stderr] Checking git-summary v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:60:62 [INFO] [stdout] | [INFO] [stdout] 60 | .map(|repo| git_util::branch_name(&repo).map(|b| (p, repo, b))) [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:69:17 [INFO] [stdout] | [INFO] [stdout] 68 | res.and_then(|(p, repo, branch)| { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | git_util::summarize_one_git_repo(&repo, do_fetch, netcache.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/main.rs:100:22 [INFO] [stdout] | [INFO] [stdout] 100 | for cause in e.source() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 100 | while let Some(cause) = e.source() { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 100 | if let Some(cause) = e.source() { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:48:19 [INFO] [stdout] | [INFO] [stdout] 47 | let mut map = self.map.lock().unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | match map.entry(key.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs_util.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 30 | src_path: P, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | / WalkDir::new(src_path.as_ref()) [INFO] [stdout] 35 | | .follow_links(true) [INFO] [stdout] 36 | | .into_iter() [INFO] [stdout] 37 | | .filter_entry(move |e| !deep_filter(deep, !do_hidden, e)) [INFO] [stdout] ... | [INFO] [stdout] 46 | | None [INFO] [stdout] 47 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net_util.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn tcp_check(sd: T) -> bool { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | / sd.to_socket_addrs() [INFO] [stdout] 48 | | .and_then(|addrs| { [INFO] [stdout] 49 | | for addr in addrs { [INFO] [stdout] 50 | | log::trace!("Making connection to: {:?}", addr); [INFO] [stdout] ... | [INFO] [stdout] 54 | | Ok(false) [INFO] [stdout] 55 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-summary` (bin "git-summary") due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:60:62 [INFO] [stdout] | [INFO] [stdout] 60 | .map(|repo| git_util::branch_name(&repo).map(|b| (p, repo, b))) [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-summary` (bin "git-summary" test) due to 6 previous errors; 1 warning emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:69:17 [INFO] [stdout] | [INFO] [stdout] 68 | res.and_then(|(p, repo, branch)| { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | git_util::summarize_one_git_repo(&repo, do_fetch, netcache.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/main.rs:100:22 [INFO] [stdout] | [INFO] [stdout] 100 | for cause in e.source() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 100 | while let Some(cause) = e.source() { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 100 | if let Some(cause) = e.source() { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:48:19 [INFO] [stdout] | [INFO] [stdout] 47 | let mut map = self.map.lock().unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | match map.entry(key.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs_util.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 30 | src_path: P, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | / WalkDir::new(src_path.as_ref()) [INFO] [stdout] 35 | | .follow_links(true) [INFO] [stdout] 36 | | .into_iter() [INFO] [stdout] 37 | | .filter_entry(move |e| !deep_filter(deep, !do_hidden, e)) [INFO] [stdout] ... | [INFO] [stdout] 46 | | None [INFO] [stdout] 47 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net_util.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn tcp_check(sd: T) -> bool { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | / sd.to_socket_addrs() [INFO] [stdout] 48 | | .and_then(|addrs| { [INFO] [stdout] 49 | | for addr in addrs { [INFO] [stdout] 50 | | log::trace!("Making connection to: {:?}", addr); [INFO] [stdout] ... | [INFO] [stdout] 54 | | Ok(false) [INFO] [stdout] 55 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "717dfbea2d76652acc5098ce1619240202e61732ab2799c01a1cc616a1216c94", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "717dfbea2d76652acc5098ce1619240202e61732ab2799c01a1cc616a1216c94", kill_on_drop: false }` [INFO] [stdout] 717dfbea2d76652acc5098ce1619240202e61732ab2799c01a1cc616a1216c94