[INFO] fetching crate git-stack 0.10.17... [INFO] checking git-stack-0.10.17 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate git-stack 0.10.17 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate git-stack 0.10.17 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate git-stack 0.10.17 [INFO] finished tweaking crates.io crate git-stack 0.10.17 [INFO] tweaked toml for crates.io crate git-stack 0.10.17 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate git-stack 0.10.17 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 94949edd5145b0aff687aa595c6bf1c4b428b8296106b66b4d042c7ba5327152 [INFO] running `Command { std: "docker" "start" "-a" "94949edd5145b0aff687aa595c6bf1c4b428b8296106b66b4d042c7ba5327152", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "94949edd5145b0aff687aa595c6bf1c4b428b8296106b66b4d042c7ba5327152", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "94949edd5145b0aff687aa595c6bf1c4b428b8296106b66b4d042c7ba5327152", kill_on_drop: false }` [INFO] [stdout] 94949edd5145b0aff687aa595c6bf1c4b428b8296106b66b4d042c7ba5327152 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a049732bb9861a897e9d13715ddc3aeabec5b565b7f5c0dcfc4dd0b703368237 [INFO] running `Command { std: "docker" "start" "-a" "a049732bb9861a897e9d13715ddc3aeabec5b565b7f5c0dcfc4dd0b703368237", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.140 [INFO] [stderr] Compiling proc-macro2 v1.0.63 [INFO] [stderr] Compiling quote v1.0.26 [INFO] [stderr] Compiling unicode-ident v1.0.8 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling io-lifetimes v1.0.9 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling serde_derive v1.0.159 [INFO] [stderr] Checking once_cell v1.17.1 [INFO] [stderr] Compiling serde v1.0.159 [INFO] [stderr] Compiling pkg-config v0.3.26 [INFO] [stderr] Compiling rustix v0.36.4 [INFO] [stderr] Checking anstyle v1.0.0 [INFO] [stderr] Checking linux-raw-sys v0.1.3 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking anstyle-parse v0.2.0 [INFO] [stderr] Checking aho-corasick v0.7.19 [INFO] [stderr] Checking either v1.8.1 [INFO] [stderr] Compiling syn v2.0.13 [INFO] [stderr] Compiling rustix v0.37.6 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking percent-encoding v2.2.0 [INFO] [stderr] Checking linux-raw-sys v0.3.1 [INFO] [stderr] Compiling jobserver v0.1.26 [INFO] [stderr] Compiling cc v1.0.79 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking unicode-bidi v0.3.13 [INFO] [stderr] Compiling indexmap v1.9.1 [INFO] [stderr] Checking form_urlencoded v1.1.0 [INFO] [stderr] Checking getrandom v0.2.7 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Compiling crossbeam-utils v0.8.12 [INFO] [stderr] Checking fastrand v1.9.0 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking idna v0.3.0 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking url v2.3.1 [INFO] [stderr] Checking clap_lex v0.5.0 [INFO] [stderr] Compiling libz-sys v1.1.8 [INFO] [stderr] Compiling libgit2-sys v0.15.0+1.6.3 [INFO] [stderr] Checking is-terminal v0.4.4 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Checking ryu v1.0.13 [INFO] [stderr] Compiling eyre v0.6.8 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking clap_builder v4.3.0 [INFO] [stderr] Compiling backtrace v0.3.66 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking thread_local v1.1.4 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Compiling serde_json v1.0.95 [INFO] [stderr] Checking gimli v0.26.2 [INFO] [stderr] Checking globset v0.4.9 [INFO] [stderr] Checking miniz_oxide v0.5.4 [INFO] [stderr] Checking which v4.4.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking tempfile v3.5.0 [INFO] [stderr] Checking object v0.29.0 [INFO] [stderr] Checking ignore v0.4.18 [INFO] [stderr] Checking shlex v1.1.0 [INFO] [stderr] Checking itoa v1.0.6 [INFO] [stderr] Checking winnow v0.4.1 [INFO] [stderr] Compiling names v0.14.0 [INFO] [stderr] Checking rustc-demangle v0.1.21 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Compiling syn v1.0.107 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking os_type v2.6.0 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking predicates-core v1.0.6 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking elsa v1.8.1 [INFO] [stderr] Checking petgraph v0.6.3 [INFO] [stderr] Checking env_logger v0.10.0 [INFO] [stderr] Checking downcast-rs v1.2.0 [INFO] [stderr] Checking termtree v0.2.4 [INFO] [stderr] Checking git-config-env v0.1.5 [INFO] [stderr] Checking proc-exit v2.0.0 [INFO] [stderr] Checking termtree v0.4.0 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking predicates-tree v1.0.5 [INFO] [stderr] Checking globwalk v0.8.1 [INFO] [stderr] Checking snapbox-macros v0.3.4 [INFO] [stderr] Checking os_pipe v1.1.2 [INFO] [stderr] Checking predicates v3.0.3 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking filetime v0.2.19 [INFO] [stderr] Compiling clap_derive v4.3.0 [INFO] [stderr] Checking content_inspector v0.2.4 [INFO] [stderr] Checking similar v2.2.1 [INFO] [stderr] Checking dunce v1.0.3 [INFO] [stderr] Checking addr2line v0.17.0 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Checking assert_fs v1.0.13 [INFO] [stderr] Checking snapbox v0.4.11 [INFO] [stderr] Checking clap v4.3.0 [INFO] [stderr] Checking clap-verbosity-flag v2.0.1 [INFO] [stderr] Checking colorchoice-clap v1.0.0 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Checking bstr v1.5.0 [INFO] [stderr] Checking toml v0.5.9 [INFO] [stderr] Checking humantime-serde v1.1.1 [INFO] [stderr] Checking serde_yaml v0.8.26 [INFO] [stderr] Checking git2 v0.17.0 [INFO] [stderr] Checking human-panic v1.0.3 [INFO] [stderr] Checking git2-ext v0.6.0 [INFO] [stderr] Checking git-fixture v0.3.2 [INFO] [stderr] Checking git-branch-stash v0.10.0 [INFO] [stderr] Checking git-stack v0.10.17 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git/protect.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 7 | pub fn new<'p>(patterns: impl IntoIterator) -> eyre::Result { [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 12 | let ignores = ignores.build()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | Ok(Self { ignores }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git/repo.rs:136:31 [INFO] [stdout] | [INFO] [stdout] 129 | pub fn new(repo: git2::Repository) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | interned_strings: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph/mod.rs:208:9 [INFO] [stdout] | [INFO] [stdout] 206 | pub fn commit_set>(&mut self, id: git2::Oid, r: R) -> bool { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | let BoxedEntry { id: key, value } = r.into(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 208 | / self.commits [INFO] [stdout] 209 | | .entry(id) [INFO] [stdout] 210 | | .or_default() [INFO] [stdout] 211 | | .insert(key, value) [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/legacy/git/protect.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 7 | pub fn new<'p>(patterns: impl IntoIterator) -> eyre::Result { [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 12 | let ignores = ignores.build()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | Ok(Self { ignores }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/legacy/git/repo.rs:139:31 [INFO] [stdout] | [INFO] [stdout] 132 | pub fn new(repo: git2::Repository) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | interned_strings: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git/protect.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 7 | pub fn new<'p>(patterns: impl IntoIterator) -> eyre::Result { [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 12 | let ignores = ignores.build()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | Ok(Self { ignores }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git/repo.rs:136:31 [INFO] [stdout] | [INFO] [stdout] 129 | pub fn new(repo: git2::Repository) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | interned_strings: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph/mod.rs:208:9 [INFO] [stdout] | [INFO] [stdout] 206 | pub fn commit_set>(&mut self, id: git2::Oid, r: R) -> bool { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | let BoxedEntry { id: key, value } = r.into(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 208 | / self.commits [INFO] [stdout] 209 | | .entry(id) [INFO] [stdout] 210 | | .or_default() [INFO] [stdout] 211 | | .insert(key, value) [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/legacy/git/protect.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 7 | pub fn new<'p>(patterns: impl IntoIterator) -> eyre::Result { [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 12 | let ignores = ignores.build()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | Ok(Self { ignores }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/legacy/git/repo.rs:139:31 [INFO] [stdout] | [INFO] [stdout] 132 | pub fn new(repo: git2::Repository) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | interned_strings: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-stack` (lib test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-stack` (lib) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "a049732bb9861a897e9d13715ddc3aeabec5b565b7f5c0dcfc4dd0b703368237", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a049732bb9861a897e9d13715ddc3aeabec5b565b7f5c0dcfc4dd0b703368237", kill_on_drop: false }` [INFO] [stdout] a049732bb9861a897e9d13715ddc3aeabec5b565b7f5c0dcfc4dd0b703368237