[INFO] fetching crate git-repo-manager 0.7.18... [INFO] checking git-repo-manager-0.7.18 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate git-repo-manager 0.7.18 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate git-repo-manager 0.7.18 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-1-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate git-repo-manager 0.7.18 [INFO] finished tweaking crates.io crate git-repo-manager 0.7.18 [INFO] tweaked toml for crates.io crate git-repo-manager 0.7.18 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate git-repo-manager 0.7.18 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4503185d4fe56d7e521799fbc0bc8f8f32dcd73f0e47a0df9292f4cccda6c3e5 [INFO] running `Command { std: "docker" "start" "-a" "4503185d4fe56d7e521799fbc0bc8f8f32dcd73f0e47a0df9292f4cccda6c3e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4503185d4fe56d7e521799fbc0bc8f8f32dcd73f0e47a0df9292f4cccda6c3e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4503185d4fe56d7e521799fbc0bc8f8f32dcd73f0e47a0df9292f4cccda6c3e5", kill_on_drop: false }` [INFO] [stdout] 4503185d4fe56d7e521799fbc0bc8f8f32dcd73f0e47a0df9292f4cccda6c3e5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0582510bd3b2e768240de9052900efd830fc9dc761eb354722279da5349a481c [INFO] running `Command { std: "docker" "start" "-a" "0582510bd3b2e768240de9052900efd830fc9dc761eb354722279da5349a481c", kill_on_drop: false }` [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking rustls-pki-types v1.8.0 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking indexmap v2.4.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Compiling syn v2.0.76 [INFO] [stderr] Compiling rustls v0.23.12 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking webpki-roots v0.26.3 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Compiling git-repo-manager v0.7.18 (/opt/rustwide/workdir) [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking shellexpand v3.1.0 [INFO] [stderr] Checking url-escape v0.1.1 [INFO] [stderr] Compiling outdir-tempdir v0.2.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Compiling cc v1.1.14 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling libz-sys v1.1.20 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling libssh2-sys v0.3.0 [INFO] [stderr] Compiling libgit2-sys v0.17.0+1.8.1 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Checking parse_link_header v0.4.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking rustls-webpki v0.102.6 [INFO] [stderr] Checking comfy-table v7.1.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking git2 v0.19.0 [INFO] [stderr] Checking ureq v2.10.1 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo.rs:690:30 [INFO] [stdout] | [INFO] [stdout] 690 | .map(|branch| Ok(Branch(branch.map_err(convert_libgit2_error)?.0))) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo.rs:698:30 [INFO] [stdout] | [INFO] [stdout] 698 | .map(|branch| Ok(Branch(branch.map_err(convert_libgit2_error)?.0))) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo.rs:788:9 [INFO] [stdout] | [INFO] [stdout] 786 | let mut config = self.config()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 787 | [INFO] [stdout] 788 | / config [INFO] [stdout] 789 | | .set_bool(GIT_CONFIG_BARE_KEY, value) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo.rs:880:9 [INFO] [stdout] | [INFO] [stdout] 878 | let mut config = self.config()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 879 | [INFO] [stdout] 880 | / config [INFO] [stdout] 881 | | .set_str( [INFO] [stdout] 882 | | GIT_CONFIG_PUSH_DEFAULT, [INFO] [stdout] 883 | | match value { [INFO] [stdout] 884 | | GitPushDefaultSetting::Upstream => "upstream", [INFO] [stdout] 885 | | }, [INFO] [stdout] 886 | | ) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo.rs:1168:12 [INFO] [stdout] | [INFO] [stdout] 1159 | let remotes = self.0.remotes().map_err(convert_libgit2_error)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1168 | Ok(Some(RemoteHandle( [INFO] [stdout] | ____________^ [INFO] [stdout] 1169 | | self.0 [INFO] [stdout] 1170 | | .find_remote(remote_name) [INFO] [stdout] 1171 | | .map_err(convert_libgit2_error)?, [INFO] [stdout] 1172 | | ))) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo.rs:1502:12 [INFO] [stdout] | [INFO] [stdout] 1501 | pub fn to_commit(self) -> Result, String> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1502 | Ok(Commit( [INFO] [stdout] | ____________^ [INFO] [stdout] 1503 | | self.0 [INFO] [stdout] 1504 | | .into_reference() [INFO] [stdout] 1505 | | .peel_to_commit() [INFO] [stdout] 1506 | | .map_err(convert_libgit2_error)?, [INFO] [stdout] 1507 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo.rs:1522:12 [INFO] [stdout] | [INFO] [stdout] 1521 | pub fn commit_owned(self) -> Result, String> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1522 | Ok(Commit( [INFO] [stdout] | ____________^ [INFO] [stdout] 1523 | | self.0 [INFO] [stdout] 1524 | | .into_reference() [INFO] [stdout] 1525 | | .peel_to_commit() [INFO] [stdout] 1526 | | .map_err(convert_libgit2_error)?, [INFO] [stdout] 1527 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo.rs:1550:9 [INFO] [stdout] | [INFO] [stdout] 1549 | pub fn delete(mut self) -> Result<(), String> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1550 | self.0.delete().map_err(convert_libgit2_error) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/worktree.rs:333:20 [INFO] [stdout] | [INFO] [stdout] 326 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 327 | commit: Option>>, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 333 | extra: WithLocalTargetSelected::<'b> { [INFO] [stdout] | ____________________^ [INFO] [stdout] 334 | | local_branch_name: self.extra.local_branch_name, [INFO] [stdout] 335 | | // As we just called `check_local_branch`, we can be sure that [INFO] [stdout] 336 | | // `self.extra.local_branch` is set to some `Some` value [INFO] [stdout] 337 | | local_branch: self.extra.local_branch.into_inner().unwrap(), [INFO] [stdout] 338 | | target_commit: commit, [INFO] [stdout] 339 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/worktree.rs:352:20 [INFO] [stdout] | [INFO] [stdout] 346 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 352 | extra: WithRemoteTrackingBranch { [INFO] [stdout] | ____________________^ [INFO] [stdout] 353 | | local_branch_name: self.extra.local_branch_name, [INFO] [stdout] 354 | | local_branch: self.extra.local_branch, [INFO] [stdout] 355 | | target_commit: self.extra.target_commit, [INFO] [stdout] 356 | | remote_tracking_branch: branch.map(|(s1, s2)| (s1.to_string(), s2.to_string())), [INFO] [stdout] 357 | | prefix: prefix.map(|prefix| prefix.to_string()), [INFO] [stdout] 358 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/worktree.rs:651:34 [INFO] [stdout] | [INFO] [stdout] 616 | let default_branch_head = repo.default_branch()?.commit_owned()?; [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 651 | .or_else(|| Some(Box::new(default_branch_head))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo.rs:690:30 [INFO] [stdout] | [INFO] [stdout] 690 | .map(|branch| Ok(Branch(branch.map_err(convert_libgit2_error)?.0))) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo.rs:698:30 [INFO] [stdout] | [INFO] [stdout] 698 | .map(|branch| Ok(Branch(branch.map_err(convert_libgit2_error)?.0))) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo.rs:788:9 [INFO] [stdout] | [INFO] [stdout] 786 | let mut config = self.config()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 787 | [INFO] [stdout] 788 | / config [INFO] [stdout] 789 | | .set_bool(GIT_CONFIG_BARE_KEY, value) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo.rs:880:9 [INFO] [stdout] | [INFO] [stdout] 878 | let mut config = self.config()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 879 | [INFO] [stdout] 880 | / config [INFO] [stdout] 881 | | .set_str( [INFO] [stdout] 882 | | GIT_CONFIG_PUSH_DEFAULT, [INFO] [stdout] 883 | | match value { [INFO] [stdout] 884 | | GitPushDefaultSetting::Upstream => "upstream", [INFO] [stdout] 885 | | }, [INFO] [stdout] 886 | | ) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo.rs:1168:12 [INFO] [stdout] | [INFO] [stdout] 1159 | let remotes = self.0.remotes().map_err(convert_libgit2_error)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1168 | Ok(Some(RemoteHandle( [INFO] [stdout] | ____________^ [INFO] [stdout] 1169 | | self.0 [INFO] [stdout] 1170 | | .find_remote(remote_name) [INFO] [stdout] 1171 | | .map_err(convert_libgit2_error)?, [INFO] [stdout] 1172 | | ))) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo.rs:1502:12 [INFO] [stdout] | [INFO] [stdout] 1501 | pub fn to_commit(self) -> Result, String> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1502 | Ok(Commit( [INFO] [stdout] | ____________^ [INFO] [stdout] 1503 | | self.0 [INFO] [stdout] 1504 | | .into_reference() [INFO] [stdout] 1505 | | .peel_to_commit() [INFO] [stdout] 1506 | | .map_err(convert_libgit2_error)?, [INFO] [stdout] 1507 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo.rs:1522:12 [INFO] [stdout] | [INFO] [stdout] 1521 | pub fn commit_owned(self) -> Result, String> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1522 | Ok(Commit( [INFO] [stdout] | ____________^ [INFO] [stdout] 1523 | | self.0 [INFO] [stdout] 1524 | | .into_reference() [INFO] [stdout] 1525 | | .peel_to_commit() [INFO] [stdout] 1526 | | .map_err(convert_libgit2_error)?, [INFO] [stdout] 1527 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo.rs:1550:9 [INFO] [stdout] | [INFO] [stdout] 1549 | pub fn delete(mut self) -> Result<(), String> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1550 | self.0.delete().map_err(convert_libgit2_error) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/worktree.rs:333:20 [INFO] [stdout] | [INFO] [stdout] 326 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 327 | commit: Option>>, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 333 | extra: WithLocalTargetSelected::<'b> { [INFO] [stdout] | ____________________^ [INFO] [stdout] 334 | | local_branch_name: self.extra.local_branch_name, [INFO] [stdout] 335 | | // As we just called `check_local_branch`, we can be sure that [INFO] [stdout] 336 | | // `self.extra.local_branch` is set to some `Some` value [INFO] [stdout] 337 | | local_branch: self.extra.local_branch.into_inner().unwrap(), [INFO] [stdout] 338 | | target_commit: commit, [INFO] [stdout] 339 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/worktree.rs:352:20 [INFO] [stdout] | [INFO] [stdout] 346 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 352 | extra: WithRemoteTrackingBranch { [INFO] [stdout] | ____________________^ [INFO] [stdout] 353 | | local_branch_name: self.extra.local_branch_name, [INFO] [stdout] 354 | | local_branch: self.extra.local_branch, [INFO] [stdout] 355 | | target_commit: self.extra.target_commit, [INFO] [stdout] 356 | | remote_tracking_branch: branch.map(|(s1, s2)| (s1.to_string(), s2.to_string())), [INFO] [stdout] 357 | | prefix: prefix.map(|prefix| prefix.to_string()), [INFO] [stdout] 358 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/worktree.rs:651:34 [INFO] [stdout] | [INFO] [stdout] 616 | let default_branch_head = repo.default_branch()?.commit_owned()?; [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 651 | .or_else(|| Some(Box::new(default_branch_head))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-repo-manager` (lib test) due to 12 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 11 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-repo-manager` (lib) due to 12 previous errors [INFO] running `Command { std: "docker" "inspect" "0582510bd3b2e768240de9052900efd830fc9dc761eb354722279da5349a481c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0582510bd3b2e768240de9052900efd830fc9dc761eb354722279da5349a481c", kill_on_drop: false }` [INFO] [stdout] 0582510bd3b2e768240de9052900efd830fc9dc761eb354722279da5349a481c